[INFO] updating cached repository PerArneng/aventofcode2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PerArneng/aventofcode2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PerArneng/aventofcode2018" "work/ex/clippy-test-run/sources/stable/gh/PerArneng/aventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PerArneng/aventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PerArneng/aventofcode2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PerArneng/aventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PerArneng/aventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b117c73a79fc7f979876610cb4d37082418280f [INFO] sha for GitHub repo PerArneng/aventofcode2018: 5b117c73a79fc7f979876610cb4d37082418280f [INFO] validating manifest of PerArneng/aventofcode2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PerArneng/aventofcode2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PerArneng/aventofcode2018 [INFO] finished frobbing PerArneng/aventofcode2018 [INFO] frobbed toml for PerArneng/aventofcode2018 written to work/ex/clippy-test-run/sources/stable/gh/PerArneng/aventofcode2018/Cargo.toml [INFO] started frobbing PerArneng/aventofcode2018 [INFO] finished frobbing PerArneng/aventofcode2018 [INFO] frobbed toml for PerArneng/aventofcode2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PerArneng/aventofcode2018/Cargo.toml [INFO] crate PerArneng/aventofcode2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PerArneng/aventofcode2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PerArneng/aventofcode2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce1c50481850dd8d1bb0b04ba83eab10f977e68267fe09d83aa7012928317404 [INFO] running `"docker" "start" "-a" "ce1c50481850dd8d1bb0b04ba83eab10f977e68267fe09d83aa7012928317404"` [INFO] [stderr] Checking advent_of_code_2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1/part1.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return vector.into_iter().fold(0, |a,b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vector.into_iter().fold(0, |a,b| a + b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1/part2.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2/part1.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return doubles * tripples; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `doubles * tripples` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2/part2.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return found; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day1/part1.rs:10:44 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn calculate_sum_of_frequencies(vector:&Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day1/part1.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | return vector.into_iter().fold(0, |a,b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day1/part1.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | return vector.into_iter().fold(0, |a,b| a + b); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day1/part2.rs:13:46 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn find_first_duplicate_frequency(vector:&Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day2/part1.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | / if char_freq.contains_key(&chr) { [INFO] [stderr] 28 | | let current = *(char_freq.get(&chr).unwrap()); [INFO] [stderr] 29 | | char_freq.insert(chr, current + 1); [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | char_freq.insert(chr, 1); [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________________^ help: consider using: `char_freq.entry(chr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2/part1.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | let current = *(char_freq.get(&chr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&char_freq[&chr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1/part1.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return vector.into_iter().fold(0, |a,b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vector.into_iter().fold(0, |a,b| a + b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1/part2.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2/part1.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return doubles * tripples; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `doubles * tripples` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/day2/part1.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / char_freq [INFO] [stderr] 36 | | .values() [INFO] [stderr] 37 | | .map(|x| *x) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 35 | char_freq [INFO] [stderr] 36 | .values().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part1.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn calculate_checksum(ids:&Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part1.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | fn count_rep(reps:&Vec, rep:&Repetition) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Repetition]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2/part2.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return found; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part2.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | fn find_similar_ids(ids:&Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2/part2.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | println!(" result: {}", similar.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&similar[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day1/part1.rs:10:44 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn calculate_sum_of_frequencies(vector:&Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day1/part1.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | return vector.into_iter().fold(0, |a,b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day1/part1.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | return vector.into_iter().fold(0, |a,b| a + b); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day1/part2.rs:13:46 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn find_first_duplicate_frequency(vector:&Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day2/part1.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | / if char_freq.contains_key(&chr) { [INFO] [stderr] 28 | | let current = *(char_freq.get(&chr).unwrap()); [INFO] [stderr] 29 | | char_freq.insert(chr, current + 1); [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | char_freq.insert(chr, 1); [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________________^ help: consider using: `char_freq.entry(chr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2/part1.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | let current = *(char_freq.get(&chr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&char_freq[&chr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/day2/part1.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / char_freq [INFO] [stderr] 36 | | .values() [INFO] [stderr] 37 | | .map(|x| *x) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 35 | char_freq [INFO] [stderr] 36 | .values().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part1.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn calculate_checksum(ids:&Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part1.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | fn count_rep(reps:&Vec, rep:&Repetition) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Repetition]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2/part2/tests.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!("fgij", found_ids.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&found_ids[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part2.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | fn find_similar_ids(ids:&Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2/part2.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | println!(" result: {}", similar.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&similar[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.49s [INFO] running `"docker" "inspect" "ce1c50481850dd8d1bb0b04ba83eab10f977e68267fe09d83aa7012928317404"` [INFO] running `"docker" "rm" "-f" "ce1c50481850dd8d1bb0b04ba83eab10f977e68267fe09d83aa7012928317404"` [INFO] [stdout] ce1c50481850dd8d1bb0b04ba83eab10f977e68267fe09d83aa7012928317404