[INFO] updating cached repository Pctg-x8/android-defs-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Pctg-x8/android-defs-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Pctg-x8/android-defs-rs" "work/ex/clippy-test-run/sources/stable/gh/Pctg-x8/android-defs-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Pctg-x8/android-defs-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Pctg-x8/android-defs-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pctg-x8/android-defs-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pctg-x8/android-defs-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 973186d014108a8fec5254131663fbb0cd1c00ab [INFO] sha for GitHub repo Pctg-x8/android-defs-rs: 973186d014108a8fec5254131663fbb0cd1c00ab [INFO] validating manifest of Pctg-x8/android-defs-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Pctg-x8/android-defs-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Pctg-x8/android-defs-rs [INFO] finished frobbing Pctg-x8/android-defs-rs [INFO] frobbed toml for Pctg-x8/android-defs-rs written to work/ex/clippy-test-run/sources/stable/gh/Pctg-x8/android-defs-rs/Cargo.toml [INFO] started frobbing Pctg-x8/android-defs-rs [INFO] finished frobbing Pctg-x8/android-defs-rs [INFO] frobbed toml for Pctg-x8/android-defs-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pctg-x8/android-defs-rs/Cargo.toml [INFO] crate Pctg-x8/android-defs-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Pctg-x8/android-defs-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Pctg-x8/android-defs-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9113f83c19ce90713e0a98ac8fa4f052822689536b91a31001fd460ba3cc96f5 [INFO] running `"docker" "start" "-a" "9113f83c19ce90713e0a98ac8fa4f052822689536b91a31001fd460ba3cc96f5"` [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking jni-sys v0.3.0 [INFO] [stderr] Checking combine v2.5.2 [INFO] [stderr] Compiling jni v0.10.1 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking android v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | if read < 0 { return Err(IOError::from_raw_os_error(-read)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IOError::from_raw_os_error(-read))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | else { return Ok(read as _) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(read as _)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:66:52 [INFO] [stderr] | [INFO] [stderr] 66 | if unsafe { transmute::<_, i64>(p) < 0 } { return Err(IOError::new(ErrorKind::Other, "")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IOError::new(ErrorKind::Other, ""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | else { return Ok(p as _); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p as _)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: type `off_t` should have a camel case name such as `OffT` [INFO] [stderr] --> src/asset_manager.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub type off_t = c_longlong; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `off64_t` should have a camel case name such as `Off64T` [INFO] [stderr] --> src/asset_manager.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub type off64_t = c_longlong; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/asset_manager.rs:43:70 [INFO] [stderr] | [INFO] [stderr] 43 | unsafe { Asset::from_ptr(AAssetManager_open(self.0.as_ptr(), name, mode)) } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`i64`) to itself [INFO] [stderr] --> src/asset_manager.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | if unsafe { transmute::<_, i64>(p) < 0 } { return Err(IOError::new(ErrorKind::Other, "")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/looper.rs:9:56 [INFO] [stderr] | [INFO] [stderr] 9 | pub const ALOOPER_PREPARE_ALLOW_NON_CALLBACKS: c_int = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/looper.rs:11:40 [INFO] [stderr] | [INFO] [stderr] 11 | pub const ALOOPER_EVENT_INPUT: c_int = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/looper.rs:36:61 [INFO] [stderr] | [INFO] [stderr] 36 | unsafe { ALooper_pollAll(timeout, outfd, outevents, outdata) } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `android`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | if read < 0 { return Err(IOError::from_raw_os_error(-read)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IOError::from_raw_os_error(-read))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | else { return Ok(read as _) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(read as _)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:66:52 [INFO] [stderr] | [INFO] [stderr] 66 | if unsafe { transmute::<_, i64>(p) < 0 } { return Err(IOError::new(ErrorKind::Other, "")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IOError::new(ErrorKind::Other, ""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asset_manager.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | else { return Ok(p as _); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p as _)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: type `off_t` should have a camel case name such as `OffT` [INFO] [stderr] --> src/asset_manager.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub type off_t = c_longlong; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `off64_t` should have a camel case name such as `Off64T` [INFO] [stderr] --> src/asset_manager.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub type off64_t = c_longlong; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/asset_manager.rs:43:70 [INFO] [stderr] | [INFO] [stderr] 43 | unsafe { Asset::from_ptr(AAssetManager_open(self.0.as_ptr(), name, mode)) } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`i64`) to itself [INFO] [stderr] --> src/asset_manager.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | if unsafe { transmute::<_, i64>(p) < 0 } { return Err(IOError::new(ErrorKind::Other, "")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/looper.rs:9:56 [INFO] [stderr] | [INFO] [stderr] 9 | pub const ALOOPER_PREPARE_ALLOW_NON_CALLBACKS: c_int = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/looper.rs:11:40 [INFO] [stderr] | [INFO] [stderr] 11 | pub const ALOOPER_EVENT_INPUT: c_int = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/looper.rs:36:61 [INFO] [stderr] | [INFO] [stderr] 36 | unsafe { ALooper_pollAll(timeout, outfd, outevents, outdata) } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `android`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9113f83c19ce90713e0a98ac8fa4f052822689536b91a31001fd460ba3cc96f5"` [INFO] running `"docker" "rm" "-f" "9113f83c19ce90713e0a98ac8fa4f052822689536b91a31001fd460ba3cc96f5"` [INFO] [stdout] 9113f83c19ce90713e0a98ac8fa4f052822689536b91a31001fd460ba3cc96f5