[INFO] updating cached repository Parfyonator/merkle_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Parfyonator/merkle_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Parfyonator/merkle_tree" "work/ex/clippy-test-run/sources/stable/gh/Parfyonator/merkle_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Parfyonator/merkle_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Parfyonator/merkle_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Parfyonator/merkle_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Parfyonator/merkle_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f6b7198d3fd038d998f0dc6a081148368f09ed39 [INFO] sha for GitHub repo Parfyonator/merkle_tree: f6b7198d3fd038d998f0dc6a081148368f09ed39 [INFO] validating manifest of Parfyonator/merkle_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Parfyonator/merkle_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Parfyonator/merkle_tree [INFO] finished frobbing Parfyonator/merkle_tree [INFO] frobbed toml for Parfyonator/merkle_tree written to work/ex/clippy-test-run/sources/stable/gh/Parfyonator/merkle_tree/Cargo.toml [INFO] started frobbing Parfyonator/merkle_tree [INFO] finished frobbing Parfyonator/merkle_tree [INFO] frobbed toml for Parfyonator/merkle_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Parfyonator/merkle_tree/Cargo.toml [INFO] crate Parfyonator/merkle_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Parfyonator/merkle_tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Parfyonator/merkle_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3c9e942122402cf7838733063d378167024ef629b3f666caac83b643f4f860d [INFO] running `"docker" "start" "-a" "a3c9e942122402cf7838733063d378167024ef629b3f666caac83b643f4f860d"` [INFO] [stderr] Checking merkle_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/merkle_tree.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 115 | | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________^ help: try: `if &self.compute_hash() != &self.val { false } else { true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/merkle_tree.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 122 | | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________________^ help: try: `if &self.compute_hash() != &self.val { false } else { true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/merkle_tree.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 115 | | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________^ help: try: `if &self.compute_hash() != &self.val { false } else { true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/merkle_tree.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 122 | | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________________^ help: try: `if &self.compute_hash() != &self.val { false } else { true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_child` [INFO] [stderr] --> src/merkle_tree.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn add_child(&mut self, new_val: String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_children` [INFO] [stderr] --> src/merkle_tree.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | fn has_children(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/merkle_tree.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match file.read_to_string(&mut s) { [INFO] [stderr] 27 | | Err(why) => panic!("Can't create Leaf. Couldn't read {}: {}", display,why.description()), [INFO] [stderr] 28 | | Ok(_) => {}, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("Can't create Leaf. Couldn't read {}: {}", display,why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&self.compute_hash() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 115 | if self.compute_hash() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&self.compute_hash() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 122 | if self.compute_hash() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&self.compute_hash() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:127:24 [INFO] [stderr] | [INFO] [stderr] 127 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 127 | if self.compute_hash() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | if &sha.result_str() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&sha.result_str() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | if &sha.result_str() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 135 | if sha.result_str() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/merkle_tree.rs:177:27 [INFO] [stderr] | [INFO] [stderr] 177 | } else if v_1.len() == 0 { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v_1.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_child` [INFO] [stderr] --> src/merkle_tree.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn add_child(&mut self, new_val: String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_children` [INFO] [stderr] --> src/merkle_tree.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | fn has_children(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/merkle_tree.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match file.read_to_string(&mut s) { [INFO] [stderr] 27 | | Err(why) => panic!("Can't create Leaf. Couldn't read {}: {}", display,why.description()), [INFO] [stderr] 28 | | Ok(_) => {}, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("Can't create Leaf. Couldn't read {}: {}", display,why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&self.compute_hash() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 115 | if self.compute_hash() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&self.compute_hash() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 122 | if self.compute_hash() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&self.compute_hash() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:127:24 [INFO] [stderr] | [INFO] [stderr] 127 | if &self.compute_hash() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 127 | if self.compute_hash() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/merkle_tree.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | if &sha.result_str() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(&sha.result_str() != &self.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/merkle_tree.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | if &sha.result_str() != &self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 135 | if sha.result_str() != self.val { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/merkle_tree.rs:177:27 [INFO] [stderr] | [INFO] [stderr] 177 | } else if v_1.len() == 0 { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v_1.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "a3c9e942122402cf7838733063d378167024ef629b3f666caac83b643f4f860d"` [INFO] running `"docker" "rm" "-f" "a3c9e942122402cf7838733063d378167024ef629b3f666caac83b643f4f860d"` [INFO] [stdout] a3c9e942122402cf7838733063d378167024ef629b3f666caac83b643f4f860d