[INFO] updating cached repository Pand9/shapeOfYou [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Pand9/shapeOfYou [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Pand9/shapeOfYou" "work/ex/clippy-test-run/sources/stable/gh/Pand9/shapeOfYou"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Pand9/shapeOfYou'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Pand9/shapeOfYou" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pand9/shapeOfYou"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pand9/shapeOfYou'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 94265fe8974a5b3ea743fa6e41fdce24833fe5a0 [INFO] sha for GitHub repo Pand9/shapeOfYou: 94265fe8974a5b3ea743fa6e41fdce24833fe5a0 [INFO] validating manifest of Pand9/shapeOfYou on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Pand9/shapeOfYou on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Pand9/shapeOfYou [INFO] finished frobbing Pand9/shapeOfYou [INFO] frobbed toml for Pand9/shapeOfYou written to work/ex/clippy-test-run/sources/stable/gh/Pand9/shapeOfYou/Cargo.toml [INFO] started frobbing Pand9/shapeOfYou [INFO] finished frobbing Pand9/shapeOfYou [INFO] frobbed toml for Pand9/shapeOfYou written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pand9/shapeOfYou/Cargo.toml [INFO] crate Pand9/shapeOfYou has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Pand9/shapeOfYou against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Pand9/shapeOfYou:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85cc7d4f6cab3f3167f040789478f569fdcde2ef9a0ac01e3b93bede64006a28 [INFO] running `"docker" "start" "-a" "85cc7d4f6cab3f3167f040789478f569fdcde2ef9a0ac01e3b93bede64006a28"` [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | } else if stage == 1 { [INFO] [stderr] | ________________^ [INFO] [stderr] 83 | | if !body { [INFO] [stderr] 84 | | stage = 2 [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 82 | } else if stage == 1 && !body { [INFO] [stderr] 83 | stage = 2 [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | } else if stage == 2 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 125 | | if !body { [INFO] [stderr] 126 | | stage = 3 [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | } else if stage == 2 && !body { [INFO] [stderr] 125 | stage = 3 [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | fn is_light_green(p: &C) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `C` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | return Some(p.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | } else if stage == 1 { [INFO] [stderr] | ________________^ [INFO] [stderr] 83 | | if !body { [INFO] [stderr] 84 | | stage = 2 [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 82 | } else if stage == 1 && !body { [INFO] [stderr] 83 | stage = 2 [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | } else if stage == 2 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 125 | | if !body { [INFO] [stderr] 126 | | stage = 3 [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | } else if stage == 2 && !body { [INFO] [stderr] 125 | stage = 3 [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | fn is_light_green(p: &C) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `C` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | return Some(p.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.88s [INFO] running `"docker" "inspect" "85cc7d4f6cab3f3167f040789478f569fdcde2ef9a0ac01e3b93bede64006a28"` [INFO] running `"docker" "rm" "-f" "85cc7d4f6cab3f3167f040789478f569fdcde2ef9a0ac01e3b93bede64006a28"` [INFO] [stdout] 85cc7d4f6cab3f3167f040789478f569fdcde2ef9a0ac01e3b93bede64006a28