[INFO] updating cached repository PanDeliverance/rsnek [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PanDeliverance/rsnek [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PanDeliverance/rsnek" "work/ex/clippy-test-run/sources/stable/gh/PanDeliverance/rsnek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PanDeliverance/rsnek'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PanDeliverance/rsnek" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PanDeliverance/rsnek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PanDeliverance/rsnek'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c131feaa6dd3d94f5c9c0e614fabd49018ca0bd [INFO] sha for GitHub repo PanDeliverance/rsnek: 7c131feaa6dd3d94f5c9c0e614fabd49018ca0bd [INFO] validating manifest of PanDeliverance/rsnek on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PanDeliverance/rsnek on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PanDeliverance/rsnek [INFO] finished frobbing PanDeliverance/rsnek [INFO] frobbed toml for PanDeliverance/rsnek written to work/ex/clippy-test-run/sources/stable/gh/PanDeliverance/rsnek/Cargo.toml [INFO] started frobbing PanDeliverance/rsnek [INFO] finished frobbing PanDeliverance/rsnek [INFO] frobbed toml for PanDeliverance/rsnek written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PanDeliverance/rsnek/Cargo.toml [INFO] crate PanDeliverance/rsnek has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PanDeliverance/rsnek against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PanDeliverance/rsnek:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a504a23c9b147a424eb3a43b36cc7653d84719c4d30aa210ff6dd879a406b84b [INFO] running `"docker" "start" "-a" "a504a23c9b147a424eb3a43b36cc7653d84719c4d30aa210ff6dd879a406b84b"` [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling derivative v1.0.1 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.82.0 [INFO] [stderr] Checking rsnek v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `rectangle` [INFO] [stderr] --> src/snake.rs:2:21 [INFO] [stderr] | [INFO] [stderr] 2 | use piston_window::{rectangle, Context, G2d}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | x,y,BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | BLOCK_SIZE * (height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match dir { [INFO] [stderr] 76 | | Some(d) => self.direction = d, [INFO] [stderr] 77 | | None => () [INFO] [stderr] 78 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match dir { [INFO] [stderr] 116 | | Some(d) => moving_dir = d, [INFO] [stderr] 117 | | None => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused import: `rectangle` [INFO] [stderr] --> src/snake.rs:2:21 [INFO] [stderr] | [INFO] [stderr] 2 | use piston_window::{rectangle, Context, G2d}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | x,y,BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | BLOCK_SIZE * (height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match dir { [INFO] [stderr] 76 | | Some(d) => self.direction = d, [INFO] [stderr] 77 | | None => () [INFO] [stderr] 78 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match dir { [INFO] [stderr] 116 | | Some(d) => moving_dir = d, [INFO] [stderr] 117 | | None => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `"docker" "inspect" "a504a23c9b147a424eb3a43b36cc7653d84719c4d30aa210ff6dd879a406b84b"` [INFO] running `"docker" "rm" "-f" "a504a23c9b147a424eb3a43b36cc7653d84719c4d30aa210ff6dd879a406b84b"` [INFO] [stdout] a504a23c9b147a424eb3a43b36cc7653d84719c4d30aa210ff6dd879a406b84b