[INFO] updating cached repository PKoshkin/voxel_craft [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PKoshkin/voxel_craft [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PKoshkin/voxel_craft" "work/ex/clippy-test-run/sources/stable/gh/PKoshkin/voxel_craft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PKoshkin/voxel_craft'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PKoshkin/voxel_craft" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PKoshkin/voxel_craft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PKoshkin/voxel_craft'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2a2d6e84dd634e5608ac9ca2b0a5c8bdcd5ab96 [INFO] sha for GitHub repo PKoshkin/voxel_craft: a2a2d6e84dd634e5608ac9ca2b0a5c8bdcd5ab96 [INFO] validating manifest of PKoshkin/voxel_craft on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PKoshkin/voxel_craft on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PKoshkin/voxel_craft [INFO] finished frobbing PKoshkin/voxel_craft [INFO] frobbed toml for PKoshkin/voxel_craft written to work/ex/clippy-test-run/sources/stable/gh/PKoshkin/voxel_craft/Cargo.toml [INFO] started frobbing PKoshkin/voxel_craft [INFO] finished frobbing PKoshkin/voxel_craft [INFO] frobbed toml for PKoshkin/voxel_craft written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PKoshkin/voxel_craft/Cargo.toml [INFO] crate PKoshkin/voxel_craft has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PKoshkin/voxel_craft against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PKoshkin/voxel_craft:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f7a4a5322720b3836f1fdc9dcfbe92c3b1421ec333b2f52ef84331eae66918b [INFO] running `"docker" "start" "-a" "8f7a4a5322720b3836f1fdc9dcfbe92c3b1421ec333b2f52ef84331eae66918b"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Compiling glium v0.20.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking voxel_craft v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | normal_map: normal_map [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `normal_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/model.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | map: map [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/model.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | voxel_size: voxel_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `voxel_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | map_size: map_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `map_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | voxels: voxels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `voxels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | camera_position: camera_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `camera_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/camera.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/camera.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | aspect_ratio: aspect_ratio, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aspect_ratio` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | directory: directory [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/view.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | normal_map: normal_map [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `normal_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/model.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | map: map [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/model.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | voxel_size: voxel_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `voxel_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | map_size: map_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `map_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | voxels: voxels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `voxels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/map.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | camera_position: camera_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `camera_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/camera.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/camera.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | aspect_ratio: aspect_ratio, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aspect_ratio` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game_application/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | directory: directory [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game_application/map.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return self.vertices.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.vertices.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game_application/camera.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let fov: f32 = 3.141592 / 3.0; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/game_application/marching_cubes.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Vector3` [INFO] [stderr] --> src/game_application/marching_cubes.rs:2:32 [INFO] [stderr] | [INFO] [stderr] 2 | use game_application::cgmath::{Vector3, Point3}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `game_application::geometry::normalize` [INFO] [stderr] --> src/game_application/marching_cubes.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use game_application::geometry::normalize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game_application/map.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return self.vertices.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.vertices.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game_application/camera.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let fov: f32 = 3.141592 / 3.0; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/game_application/marching_cubes.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Vector3` [INFO] [stderr] --> src/game_application/marching_cubes.rs:2:32 [INFO] [stderr] | [INFO] [stderr] 2 | use game_application::cgmath::{Vector3, Point3}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `game_application::geometry::normalize` [INFO] [stderr] --> src/game_application/marching_cubes.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use game_application::geometry::normalize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event` [INFO] [stderr] --> src/game_application/view.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^ help: consider using `_event` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event` [INFO] [stderr] --> src/game_application/model.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^ help: consider using `_event` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `camera_position` [INFO] [stderr] --> src/game_application/map.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | fn need_to_redraw(&self, camera_position: Point3) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_camera_position` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `triangles` [INFO] [stderr] --> src/game_application/mesh.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | for (point, triangles) in self.point_neighbors.iter() { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_triangles` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `init_points_program` [INFO] [stderr] --> src/game_application/view.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn init_points_program(display: &glium::Display, directory: &str) -> glium::Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `handle_event` [INFO] [stderr] --> src/game_application/view.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `handle_event` [INFO] [stderr] --> src/game_application/model.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_application/vertex.rs:12:74 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(point: &Point3, normal: &Vector3, tex_coords: &[f32; 2], voxel_size: f32) -> Vertex { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game_application/map.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | for z in 0..(*height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=*height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game_application/map.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | self.vertices.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.vertices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/game_application/camera.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let fov: f32 = 3.141592 / 3.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game_application/marching_cubes.rs:284:29 [INFO] [stderr] | [INFO] [stderr] 284 | pub fn process_cube(voxels: &Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game_application/marching_cubes.rs:314:29 [INFO] [stderr] | [INFO] [stderr] 314 | pub fn get_vertices(voxels: &Vec>>, voxel_size: f32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game_application/diamond_square.rs:57:47 [INFO] [stderr] | [INFO] [stderr] 57 | result[x][y] = result[x][y] / (counter as f64) + get_delta(random, roughness, square_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(counter)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game_application/diamond_square.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | result[x][y] = result[x][y] / (counter as f64) + get_delta(random, roughness, square_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/game_application/mesh.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Eq, Hash, Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/game_application/mesh.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / impl PartialEq for Triangle { [INFO] [stderr] 43 | | fn eq(&self, other: &Triangle) -> bool { [INFO] [stderr] 44 | | let self_set: HashSet<&Point> = HashSet::from_iter(self.points.iter()); [INFO] [stderr] 45 | | let other_set: HashSet<&Point> = HashSet::from_iter(other.points.iter()); [INFO] [stderr] 46 | | self_set == other_set [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/game_application/mesh.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | #[derive(Eq, Hash, Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/game_application/mesh.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / impl PartialEq for Edge { [INFO] [stderr] 70 | | fn eq(&self, other: &Edge) -> bool { [INFO] [stderr] 71 | | let self_set: HashSet<&Point> = HashSet::from_iter(self.points.iter()); [INFO] [stderr] 72 | | let other_set: HashSet<&Point> = HashSet::from_iter(other.points.iter()); [INFO] [stderr] 73 | | self_set == other_set [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/game_application/mesh.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | / if !self.edge_neighbors.contains_key(&edge) { [INFO] [stderr] 116 | | self.edge_neighbors.insert(edge, Vec::new()); [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.edge_neighbors.entry(edge).or_insert(Vec::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event` [INFO] [stderr] --> src/game_application/view.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^ help: consider using `_event` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event` [INFO] [stderr] --> src/game_application/model.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^ help: consider using `_event` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `camera_position` [INFO] [stderr] --> src/game_application/map.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | fn need_to_redraw(&self, camera_position: Point3) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_camera_position` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `triangles` [INFO] [stderr] --> src/game_application/mesh.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | for (point, triangles) in self.point_neighbors.iter() { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_triangles` instead [INFO] [stderr] [INFO] [stderr] error: Could not compile `voxel_craft`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `init_points_program` [INFO] [stderr] --> src/game_application/view.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn init_points_program(display: &glium::Display, directory: &str) -> glium::Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `handle_event` [INFO] [stderr] --> src/game_application/view.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `handle_event` [INFO] [stderr] --> src/game_application/model.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn handle_event(&mut self, event: &glutin::WindowEvent) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_application/vertex.rs:12:74 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(point: &Point3, normal: &Vector3, tex_coords: &[f32; 2], voxel_size: f32) -> Vertex { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game_application/map.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | for z in 0..(*height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=*height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game_application/map.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | self.vertices.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.vertices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/game_application/camera.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let fov: f32 = 3.141592 / 3.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game_application/marching_cubes.rs:284:29 [INFO] [stderr] | [INFO] [stderr] 284 | pub fn process_cube(voxels: &Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game_application/marching_cubes.rs:314:29 [INFO] [stderr] | [INFO] [stderr] 314 | pub fn get_vertices(voxels: &Vec>>, voxel_size: f32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game_application/diamond_square.rs:57:47 [INFO] [stderr] | [INFO] [stderr] 57 | result[x][y] = result[x][y] / (counter as f64) + get_delta(random, roughness, square_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(counter)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game_application/diamond_square.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | result[x][y] = result[x][y] / (counter as f64) + get_delta(random, roughness, square_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/game_application/mesh.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Eq, Hash, Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/game_application/mesh.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / impl PartialEq for Triangle { [INFO] [stderr] 43 | | fn eq(&self, other: &Triangle) -> bool { [INFO] [stderr] 44 | | let self_set: HashSet<&Point> = HashSet::from_iter(self.points.iter()); [INFO] [stderr] 45 | | let other_set: HashSet<&Point> = HashSet::from_iter(other.points.iter()); [INFO] [stderr] 46 | | self_set == other_set [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/game_application/mesh.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | #[derive(Eq, Hash, Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/game_application/mesh.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / impl PartialEq for Edge { [INFO] [stderr] 70 | | fn eq(&self, other: &Edge) -> bool { [INFO] [stderr] 71 | | let self_set: HashSet<&Point> = HashSet::from_iter(self.points.iter()); [INFO] [stderr] 72 | | let other_set: HashSet<&Point> = HashSet::from_iter(other.points.iter()); [INFO] [stderr] 73 | | self_set == other_set [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/game_application/mesh.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | / if !self.edge_neighbors.contains_key(&edge) { [INFO] [stderr] 116 | | self.edge_neighbors.insert(edge, Vec::new()); [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.edge_neighbors.entry(edge).or_insert(Vec::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `voxel_craft`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8f7a4a5322720b3836f1fdc9dcfbe92c3b1421ec333b2f52ef84331eae66918b"` [INFO] running `"docker" "rm" "-f" "8f7a4a5322720b3836f1fdc9dcfbe92c3b1421ec333b2f52ef84331eae66918b"` [INFO] [stdout] 8f7a4a5322720b3836f1fdc9dcfbe92c3b1421ec333b2f52ef84331eae66918b