[INFO] updating cached repository OwenChia/URL-Shortener [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/OwenChia/URL-Shortener [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/OwenChia/URL-Shortener" "work/ex/clippy-test-run/sources/stable/gh/OwenChia/URL-Shortener"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OwenChia/URL-Shortener'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/OwenChia/URL-Shortener" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OwenChia/URL-Shortener"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OwenChia/URL-Shortener'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 485a9bccfc48a84aa8fc4dbaea71962b2ac19351 [INFO] sha for GitHub repo OwenChia/URL-Shortener: 485a9bccfc48a84aa8fc4dbaea71962b2ac19351 [INFO] validating manifest of OwenChia/URL-Shortener on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of OwenChia/URL-Shortener on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing OwenChia/URL-Shortener [INFO] finished frobbing OwenChia/URL-Shortener [INFO] frobbed toml for OwenChia/URL-Shortener written to work/ex/clippy-test-run/sources/stable/gh/OwenChia/URL-Shortener/Cargo.toml [INFO] started frobbing OwenChia/URL-Shortener [INFO] finished frobbing OwenChia/URL-Shortener [INFO] frobbed toml for OwenChia/URL-Shortener written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OwenChia/URL-Shortener/Cargo.toml [INFO] crate OwenChia/URL-Shortener has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting OwenChia/URL-Shortener against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/OwenChia/URL-Shortener:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97ca0f949cf822d1780cf0adc31c0acf7bcd3c0ffd6a8a7a9ad39128f5222dc8 [INFO] running `"docker" "start" "-a" "97ca0f949cf822d1780cf0adc31c0acf7bcd3c0ffd6a8a7a9ad39128f5222dc8"` [INFO] [stderr] Checking rand_core v0.1.0 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling actix-web v0.5.6 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking uuid v0.6.3 [INFO] [stderr] Compiling syn v0.13.2 [INFO] [stderr] Checking http v0.1.5 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking rand v0.5.0-pre.1 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling backtrace v0.3.6 [INFO] [stderr] Checking crossbeam-channel v0.1.2 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Checking h2 v0.1.6 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Compiling serde_derive v1.0.43 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Compiling actix v0.5.6 [INFO] [stderr] Checking shorturl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/database.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let _: () = try!(con.set(&hashed_url, &msg.url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/database.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let _:() = try!(con.del(&msg.hashed_url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/handler.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | Ok(s) => format!("{}", s.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/handler.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(s) => format!("{}", s.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/database.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let _: () = try!(con.set(&hashed_url, &msg.url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/database.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let _:() = try!(con.del(&msg.hashed_url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/handler.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | Ok(s) => format!("{}", s.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/handler.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(s) => format!("{}", s.unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 10s [INFO] running `"docker" "inspect" "97ca0f949cf822d1780cf0adc31c0acf7bcd3c0ffd6a8a7a9ad39128f5222dc8"` [INFO] running `"docker" "rm" "-f" "97ca0f949cf822d1780cf0adc31c0acf7bcd3c0ffd6a8a7a9ad39128f5222dc8"` [INFO] [stdout] 97ca0f949cf822d1780cf0adc31c0acf7bcd3c0ffd6a8a7a9ad39128f5222dc8