[INFO] updating cached repository Overv/bf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Overv/bf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Overv/bf" "work/ex/clippy-test-run/sources/stable/gh/Overv/bf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Overv/bf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Overv/bf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Overv/bf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Overv/bf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 698173c0c0d4314436f389e86d6bfe8ce03e3ba8 [INFO] sha for GitHub repo Overv/bf: 698173c0c0d4314436f389e86d6bfe8ce03e3ba8 [INFO] validating manifest of Overv/bf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Overv/bf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Overv/bf [INFO] finished frobbing Overv/bf [INFO] frobbed toml for Overv/bf written to work/ex/clippy-test-run/sources/stable/gh/Overv/bf/Cargo.toml [INFO] started frobbing Overv/bf [INFO] finished frobbing Overv/bf [INFO] frobbed toml for Overv/bf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Overv/bf/Cargo.toml [INFO] crate Overv/bf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Overv/bf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Overv/bf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2561cb509d8be80b8167e5bc2da21e81e20382a3a0e0a05864c8455093ba4c89 [INFO] running `"docker" "start" "-a" "2561cb509d8be80b8167e5bc2da21e81e20382a3a0e0a05864c8455093ba4c89"` [INFO] [stderr] Checking bf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match op { [INFO] [stderr] 50 | | Some(op) => operations.push(op), [INFO] [stderr] 51 | | None => () [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(op) = op { operations.push(op) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match instr { [INFO] [stderr] 83 | | Some(instr) => program.push(instr), [INFO] [stderr] 84 | | None => () [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(instr) = instr { program.push(instr) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | fn run(instructions: &Vec, tape: &mut Vec, data_pointer: &mut usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match op { [INFO] [stderr] 50 | | Some(op) => operations.push(op), [INFO] [stderr] 51 | | None => () [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(op) = op { operations.push(op) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match instr { [INFO] [stderr] 83 | | Some(instr) => program.push(instr), [INFO] [stderr] 84 | | None => () [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(instr) = instr { program.push(instr) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | fn run(instructions: &Vec, tape: &mut Vec, data_pointer: &mut usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "2561cb509d8be80b8167e5bc2da21e81e20382a3a0e0a05864c8455093ba4c89"` [INFO] running `"docker" "rm" "-f" "2561cb509d8be80b8167e5bc2da21e81e20382a3a0e0a05864c8455093ba4c89"` [INFO] [stdout] 2561cb509d8be80b8167e5bc2da21e81e20382a3a0e0a05864c8455093ba4c89