[INFO] updating cached repository OtterCode/opf-manifest-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/OtterCode/opf-manifest-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/OtterCode/opf-manifest-generator" "work/ex/clippy-test-run/sources/stable/gh/OtterCode/opf-manifest-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OtterCode/opf-manifest-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/OtterCode/opf-manifest-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OtterCode/opf-manifest-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OtterCode/opf-manifest-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] be2b89ab51260fd0c0c167fe251c607fd75f0a00 [INFO] sha for GitHub repo OtterCode/opf-manifest-generator: be2b89ab51260fd0c0c167fe251c607fd75f0a00 [INFO] validating manifest of OtterCode/opf-manifest-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of OtterCode/opf-manifest-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing OtterCode/opf-manifest-generator [INFO] finished frobbing OtterCode/opf-manifest-generator [INFO] frobbed toml for OtterCode/opf-manifest-generator written to work/ex/clippy-test-run/sources/stable/gh/OtterCode/opf-manifest-generator/Cargo.toml [INFO] started frobbing OtterCode/opf-manifest-generator [INFO] finished frobbing OtterCode/opf-manifest-generator [INFO] frobbed toml for OtterCode/opf-manifest-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OtterCode/opf-manifest-generator/Cargo.toml [INFO] crate OtterCode/opf-manifest-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting OtterCode/opf-manifest-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/OtterCode/opf-manifest-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4580572705bb26f90bfcece470e1b4efab2b3c4e4f813d8b111d9ff7ffdea33 [INFO] running `"docker" "start" "-a" "f4580572705bb26f90bfcece470e1b4efab2b3c4e4f813d8b111d9ff7ffdea33"` [INFO] [stderr] Checking manifest-generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | File { path: path, mimetype: mimetype, filename: filename } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | File { path: path, mimetype: mimetype, filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mimetype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | File { path: path, mimetype: mimetype, filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | File { path: path, mimetype: mimetype, filename: filename } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | File { path: path, mimetype: mimetype, filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mimetype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | File { path: path, mimetype: mimetype, filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | .map(|s| s.starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | .map(|s| s.starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.11s [INFO] running `"docker" "inspect" "f4580572705bb26f90bfcece470e1b4efab2b3c4e4f813d8b111d9ff7ffdea33"` [INFO] running `"docker" "rm" "-f" "f4580572705bb26f90bfcece470e1b4efab2b3c4e4f813d8b111d9ff7ffdea33"` [INFO] [stdout] f4580572705bb26f90bfcece470e1b4efab2b3c4e4f813d8b111d9ff7ffdea33