[INFO] updating cached repository Oroneki/rust_decompressor
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Oroneki/rust_decompressor
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Oroneki/rust_decompressor" "work/ex/clippy-test-run/sources/stable/gh/Oroneki/rust_decompressor"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Oroneki/rust_decompressor'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Oroneki/rust_decompressor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Oroneki/rust_decompressor"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Oroneki/rust_decompressor'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 35b0c124a2b10fb0e3c02c999a3c7a940fe11b82
[INFO] sha for GitHub repo Oroneki/rust_decompressor: 35b0c124a2b10fb0e3c02c999a3c7a940fe11b82
[INFO] validating manifest of Oroneki/rust_decompressor on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Oroneki/rust_decompressor on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Oroneki/rust_decompressor
[INFO] finished frobbing Oroneki/rust_decompressor
[INFO] frobbed toml for Oroneki/rust_decompressor written to work/ex/clippy-test-run/sources/stable/gh/Oroneki/rust_decompressor/Cargo.toml
[INFO] started frobbing Oroneki/rust_decompressor
[INFO] finished frobbing Oroneki/rust_decompressor
[INFO] frobbed toml for Oroneki/rust_decompressor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Oroneki/rust_decompressor/Cargo.toml
[INFO] crate Oroneki/rust_decompressor has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Oroneki/rust_decompressor against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Oroneki/rust_decompressor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bd9338d735684cdc64fdd3530727a50a2d368ca17e04ae52a5c1cc5dcf2be763
[INFO] running `"docker" "start" "-a" "bd9338d735684cdc64fdd3530727a50a2d368ca17e04ae52a5c1cc5dcf2be763"`
[INFO] [stderr]    Compiling miniz_oxide_c_api v0.1.3
[INFO] [stderr]     Checking miniz_oxide v0.1.3
[INFO] [stderr]     Checking flate2 v1.0.2
[INFO] [stderr]     Checking zip v0.4.2
[INFO] [stderr]     Checking decompressor v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:30:16
[INFO] [stderr]    |
[INFO] [stderr] 30 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 31 | |             if entry.path().extension().unwrap() == "zip" {
[INFO] [stderr] 32 | |                 vec.push(FolderSubItem::Zip(
[INFO] [stderr] 33 | |                     entry.path().to_str().unwrap().clone().to_string(),
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |             }
[INFO] [stderr] 38 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 30 |         } else if entry.path().extension().unwrap() == "zip" {
[INFO] [stderr] 31 |     vec.push(FolderSubItem::Zip(
[INFO] [stderr] 32 |         entry.path().to_str().unwrap().clone().to_string(),
[INFO] [stderr] 33 |     ));
[INFO] [stderr] 34 | } else {
[INFO] [stderr] 35 |     vec.push(FolderSubItem::OtherFile);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 |                     entry.path().to_str().unwrap().clone().to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 33 |                     &(*entry.path().to_str().unwrap()).clone().to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 33 |                     &str::clone(entry.path().to_str().unwrap()).to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/main.rs:56:36
[INFO] [stderr]    |
[INFO] [stderr] 56 |         if sub_list.iter().any(|i| is_it_a_subfolder(&i) == true) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_it_a_subfolder(&i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/main.rs:62:25
[INFO] [stderr]    |
[INFO] [stderr] 62 |             .filter(|z| is_it_a_zipfile(&z) == true)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_it_a_zipfile(&z)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `decompressor`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:30:16
[INFO] [stderr]    |
[INFO] [stderr] 30 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 31 | |             if entry.path().extension().unwrap() == "zip" {
[INFO] [stderr] 32 | |                 vec.push(FolderSubItem::Zip(
[INFO] [stderr] 33 | |                     entry.path().to_str().unwrap().clone().to_string(),
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |             }
[INFO] [stderr] 38 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 30 |         } else if entry.path().extension().unwrap() == "zip" {
[INFO] [stderr] 31 |     vec.push(FolderSubItem::Zip(
[INFO] [stderr] 32 |         entry.path().to_str().unwrap().clone().to_string(),
[INFO] [stderr] 33 |     ));
[INFO] [stderr] 34 | } else {
[INFO] [stderr] 35 |     vec.push(FolderSubItem::OtherFile);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 |                     entry.path().to_str().unwrap().clone().to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 33 |                     &(*entry.path().to_str().unwrap()).clone().to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 33 |                     &str::clone(entry.path().to_str().unwrap()).to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/main.rs:56:36
[INFO] [stderr]    |
[INFO] [stderr] 56 |         if sub_list.iter().any(|i| is_it_a_subfolder(&i) == true) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_it_a_subfolder(&i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/main.rs:62:25
[INFO] [stderr]    |
[INFO] [stderr] 62 |             .filter(|z| is_it_a_zipfile(&z) == true)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_it_a_zipfile(&z)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `decompressor`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "bd9338d735684cdc64fdd3530727a50a2d368ca17e04ae52a5c1cc5dcf2be763"`
[INFO] running `"docker" "rm" "-f" "bd9338d735684cdc64fdd3530727a50a2d368ca17e04ae52a5c1cc5dcf2be763"`
[INFO] [stdout] bd9338d735684cdc64fdd3530727a50a2d368ca17e04ae52a5c1cc5dcf2be763