[INFO] updating cached repository OrangeChris/lua-in-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/OrangeChris/lua-in-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/OrangeChris/lua-in-rust" "work/ex/clippy-test-run/sources/stable/gh/OrangeChris/lua-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OrangeChris/lua-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/OrangeChris/lua-in-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OrangeChris/lua-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OrangeChris/lua-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1fe1278e3a6de7a242dde2dc9b4cd757dec5405a [INFO] sha for GitHub repo OrangeChris/lua-in-rust: 1fe1278e3a6de7a242dde2dc9b4cd757dec5405a [INFO] validating manifest of OrangeChris/lua-in-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of OrangeChris/lua-in-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing OrangeChris/lua-in-rust [INFO] finished frobbing OrangeChris/lua-in-rust [INFO] frobbed toml for OrangeChris/lua-in-rust written to work/ex/clippy-test-run/sources/stable/gh/OrangeChris/lua-in-rust/Cargo.toml [INFO] started frobbing OrangeChris/lua-in-rust [INFO] finished frobbing OrangeChris/lua-in-rust [INFO] frobbed toml for OrangeChris/lua-in-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OrangeChris/lua-in-rust/Cargo.toml [INFO] crate OrangeChris/lua-in-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting OrangeChris/lua-in-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/OrangeChris/lua-in-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2f5cbfec04162cd90dc30515bf644f974b5dd74c1a2068a138a482fcc2db8b56 [INFO] running `"docker" "start" "-a" "2f5cbfec04162cd90dc30515bf644f974b5dd74c1a2068a138a482fcc2db8b56"` [INFO] [stderr] Checking lua v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/eval.rs:103:65 [INFO] [stderr] | [INFO] [stderr] 103 | (Number(n1), Number(n2)) => stack.push(Bool(n1 == n2)), [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(n1 - n2).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/eval.rs:103:65 [INFO] [stderr] | [INFO] [stderr] 103 | (Number(n1), Number(n2)) => stack.push(Bool(n1 == n2)), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/eval.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | (Number(n1), Number(n2)) => stack.push(Bool(n1 != n2)), [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(n1 - n2).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/eval.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | (Number(n1), Number(n2)) => stack.push(Bool(n1 != n2)), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / loop { [INFO] [stderr] 142 | | if let Some(Token::Or) = self.lookahead { [INFO] [stderr] 143 | | self.next(); [INFO] [stderr] 144 | | let mut old_output = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(Token::Or) = self.lookahead { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / loop { [INFO] [stderr] 164 | | if let Some(Token::And) = self.lookahead { [INFO] [stderr] 165 | | self.next(); [INFO] [stderr] 166 | | let mut old_output = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(Token::And) = self.lookahead { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lua`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/eval.rs:103:65 [INFO] [stderr] | [INFO] [stderr] 103 | (Number(n1), Number(n2)) => stack.push(Bool(n1 == n2)), [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(n1 - n2).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/eval.rs:103:65 [INFO] [stderr] | [INFO] [stderr] 103 | (Number(n1), Number(n2)) => stack.push(Bool(n1 == n2)), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/eval.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | (Number(n1), Number(n2)) => stack.push(Bool(n1 != n2)), [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(n1 - n2).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/eval.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | (Number(n1), Number(n2)) => stack.push(Bool(n1 != n2)), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:218:42 [INFO] [stderr] | [INFO] [stderr] 218 | assert_eq!(LuaVal::Number(1.0), *env.get("a").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&env["a"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:234:14 [INFO] [stderr] | [INFO] [stderr] 234 | *env.get("key").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&env["key"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:248:41 [INFO] [stderr] | [INFO] [stderr] 248 | assert_eq!(LuaVal::Bool(true), *env.get("a").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&env["a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:268:34 [INFO] [stderr] | [INFO] [stderr] 268 | assert_eq!(Bool(false), *env.get("key").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&env["key"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/eval.rs:288:34 [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(Number(5.0), *env.get("a").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&env["a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / loop { [INFO] [stderr] 142 | | if let Some(Token::Or) = self.lookahead { [INFO] [stderr] 143 | | self.next(); [INFO] [stderr] 144 | | let mut old_output = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(Token::Or) = self.lookahead { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / loop { [INFO] [stderr] 164 | | if let Some(Token::And) = self.lookahead { [INFO] [stderr] 165 | | self.next(); [INFO] [stderr] 166 | | let mut old_output = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(Token::And) = self.lookahead { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lua`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2f5cbfec04162cd90dc30515bf644f974b5dd74c1a2068a138a482fcc2db8b56"` [INFO] running `"docker" "rm" "-f" "2f5cbfec04162cd90dc30515bf644f974b5dd74c1a2068a138a482fcc2db8b56"` [INFO] [stdout] 2f5cbfec04162cd90dc30515bf644f974b5dd74c1a2068a138a482fcc2db8b56