[INFO] updating cached repository OptimisticPeach/perlin_noise [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/OptimisticPeach/perlin_noise [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/OptimisticPeach/perlin_noise" "work/ex/clippy-test-run/sources/stable/gh/OptimisticPeach/perlin_noise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OptimisticPeach/perlin_noise'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/OptimisticPeach/perlin_noise" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OptimisticPeach/perlin_noise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OptimisticPeach/perlin_noise'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a60c984124e5a3aa37bc47dcdc01bf7ed05f2749 [INFO] sha for GitHub repo OptimisticPeach/perlin_noise: a60c984124e5a3aa37bc47dcdc01bf7ed05f2749 [INFO] validating manifest of OptimisticPeach/perlin_noise on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of OptimisticPeach/perlin_noise on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing OptimisticPeach/perlin_noise [INFO] finished frobbing OptimisticPeach/perlin_noise [INFO] frobbed toml for OptimisticPeach/perlin_noise written to work/ex/clippy-test-run/sources/stable/gh/OptimisticPeach/perlin_noise/Cargo.toml [INFO] started frobbing OptimisticPeach/perlin_noise [INFO] finished frobbing OptimisticPeach/perlin_noise [INFO] frobbed toml for OptimisticPeach/perlin_noise written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OptimisticPeach/perlin_noise/Cargo.toml [INFO] crate OptimisticPeach/perlin_noise has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting OptimisticPeach/perlin_noise against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/OptimisticPeach/perlin_noise:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70e72e1299281dc7f335d97b3f689c01b515b01594386bb10575671c1a8073a6 [INFO] running `"docker" "start" "-a" "70e72e1299281dc7f335d97b3f689c01b515b01594386bb10575671c1a8073a6"` [INFO] [stderr] Compiling proc-macro2 v0.4.17 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking perlin_noise v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:49 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:52 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:60 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:49 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:52 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:60 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin/interpolators.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | return start + ((end - start) * percent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start + ((end - start) * percent)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/perlin/random_2d.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin/interpolators.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | return start + ((end - start) * percent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start + ((end - start) * percent)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/perlin/random_2d.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width_main` [INFO] [stderr] --> src/perlin/random_2d.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | width_main: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height_main` [INFO] [stderr] --> src/perlin/random_2d.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | height_main: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_accessed` [INFO] [stderr] --> src/perlin/random_2d.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn is_accessed(&self, x: usize, y: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `recipr` is used as a loop counter. Consider using `for (recipr, item) in (0..depth).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/perlin/mod.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | for depth_index in (0..depth).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..(size - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for in perlin.iter_mut().take((size - 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:208:14 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..(sizex) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 208 | for in perlin.iter_mut().take((sizex)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width_main` [INFO] [stderr] --> src/perlin/random_2d.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | width_main: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height_main` [INFO] [stderr] --> src/perlin/random_2d.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | height_main: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_accessed` [INFO] [stderr] --> src/perlin/random_2d.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn is_accessed(&self, x: usize, y: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `recipr` is used as a loop counter. Consider using `for (recipr, item) in (0..depth).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/perlin/mod.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | for depth_index in (0..depth).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..(size - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for in perlin.iter_mut().take((size - 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:208:14 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..(sizex) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 208 | for in perlin.iter_mut().take((sizex)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:49 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:52 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:60 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:49 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn bilinear(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:52 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin/interpolators.rs:9:60 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn circle_lerp(a: f32, b: f32, c: f32, d: f32, x: f32, y: f32) -> f32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin/interpolators.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | return start + ((end - start) * percent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start + ((end - start) * percent)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the variable `recipr` is used as a loop counter. Consider using `for (recipr, item) in (0..depth).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/perlin/mod.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | for depth_index in (0..depth).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..(size - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for in perlin.iter_mut().take((size - 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:208:14 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..(sizex) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 208 | for in perlin.iter_mut().take((sizex)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perlin/interpolators.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | return start + ((end - start) * percent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start + ((end - start) * percent)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the variable `recipr` is used as a loop counter. Consider using `for (recipr, item) in (0..depth).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/perlin/mod.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | for depth_index in (0..depth).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..(size - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for in perlin.iter_mut().take((size - 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perlin`. [INFO] [stderr] --> src/perlin/mod.rs:208:14 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..(sizex) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 208 | for in perlin.iter_mut().take((sizex)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.94s [INFO] running `"docker" "inspect" "70e72e1299281dc7f335d97b3f689c01b515b01594386bb10575671c1a8073a6"` [INFO] running `"docker" "rm" "-f" "70e72e1299281dc7f335d97b3f689c01b515b01594386bb10575671c1a8073a6"` [INFO] [stdout] 70e72e1299281dc7f335d97b3f689c01b515b01594386bb10575671c1a8073a6