[INFO] updating cached repository Ophirr33/sbtio
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Ophirr33/sbtio
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Ophirr33/sbtio" "work/ex/clippy-test-run/sources/stable/gh/Ophirr33/sbtio"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ophirr33/sbtio'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Ophirr33/sbtio" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/sbtio"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/sbtio'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e3e081bd52e6c3b666e35e489679df67a67bb841
[INFO] sha for GitHub repo Ophirr33/sbtio: e3e081bd52e6c3b666e35e489679df67a67bb841
[INFO] validating manifest of Ophirr33/sbtio on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Ophirr33/sbtio on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Ophirr33/sbtio
[INFO] finished frobbing Ophirr33/sbtio
[INFO] frobbed toml for Ophirr33/sbtio written to work/ex/clippy-test-run/sources/stable/gh/Ophirr33/sbtio/Cargo.toml
[INFO] started frobbing Ophirr33/sbtio
[INFO] finished frobbing Ophirr33/sbtio
[INFO] frobbed toml for Ophirr33/sbtio written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/sbtio/Cargo.toml
[INFO] crate Ophirr33/sbtio has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Ophirr33/sbtio against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ophirr33/sbtio:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4c02869559132364ad37889b771d9d57365c2bfa30155d36aea55c4ba5fae108
[INFO] running `"docker" "start" "-a" "4c02869559132364ad37889b771d9d57365c2bfa30155d36aea55c4ba5fae108"`
[INFO] [stderr]     Checking unix_socket v0.5.0
[INFO] [stderr]     Checking ctrlc v3.1.1
[INFO] [stderr]     Checking error-chain v0.11.0
[INFO] [stderr]     Checking syslog v4.0.0
[INFO] [stderr]     Checking sbtio v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 | const RTHREAD: &'static str = "reader";
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 | const WTHREAD: &'static str = "writer";
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 | const RTHREAD: &'static str = "reader";
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 | const WTHREAD: &'static str = "writer";
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/conn.rs:27:22
[INFO] [stderr]    |
[INFO] [stderr] 27 |                     .ok_or(io::Error::new(invalid, "Invalid tcp address"))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(invalid, "Invalid tcp address"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/conn.rs:46:57
[INFO] [stderr]    |
[INFO] [stderr] 46 |             Conn::Tcp(stream) => stream.try_clone().map(|new| Conn::Tcp(new)),
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Conn::Tcp`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/conn.rs:48:58
[INFO] [stderr]    |
[INFO] [stderr] 48 |             Conn::Unix(stream) => stream.try_clone().map(|new| Conn::Unix(new)),
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Conn::Unix`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/conn.rs:27:22
[INFO] [stderr]    |
[INFO] [stderr] 27 |                     .ok_or(io::Error::new(invalid, "Invalid tcp address"))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(invalid, "Invalid tcp address"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/conn.rs:46:57
[INFO] [stderr]    |
[INFO] [stderr] 46 |             Conn::Tcp(stream) => stream.try_clone().map(|new| Conn::Tcp(new)),
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Conn::Tcp`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/conn.rs:48:58
[INFO] [stderr]    |
[INFO] [stderr] 48 |             Conn::Unix(stream) => stream.try_clone().map(|new| Conn::Unix(new)),
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Conn::Unix`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/sbt.rs:45:15
[INFO] [stderr]    |
[INFO] [stderr] 45 |     fn to_uri(self) -> String {
[INFO] [stderr]    |               ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/sbt.rs:85:28
[INFO] [stderr]    |
[INFO] [stderr] 85 |             if len >= 4 && &self.headers[len - 4..] == &[b'\r', b'\n', b'\r', b'\n'] {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 85 |             if len >= 4 && self.headers[len - 4..] == [b'\r', b'\n', b'\r', b'\n'] {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/sbt.rs:45:15
[INFO] [stderr]    |
[INFO] [stderr] 45 |     fn to_uri(self) -> String {
[INFO] [stderr]    |               ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/sbt.rs:85:28
[INFO] [stderr]    |
[INFO] [stderr] 85 |             if len >= 4 && &self.headers[len - 4..] == &[b'\r', b'\n', b'\r', b'\n'] {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 85 |             if len >= 4 && self.headers[len - 4..] == [b'\r', b'\n', b'\r', b'\n'] {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.03s
[INFO] running `"docker" "inspect" "4c02869559132364ad37889b771d9d57365c2bfa30155d36aea55c4ba5fae108"`
[INFO] running `"docker" "rm" "-f" "4c02869559132364ad37889b771d9d57365c2bfa30155d36aea55c4ba5fae108"`
[INFO] [stdout] 4c02869559132364ad37889b771d9d57365c2bfa30155d36aea55c4ba5fae108