[INFO] updating cached repository Ophirr33/NEUCourseNotification [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ophirr33/NEUCourseNotification [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ophirr33/NEUCourseNotification" "work/ex/clippy-test-run/sources/stable/gh/Ophirr33/NEUCourseNotification"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ophirr33/NEUCourseNotification'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ophirr33/NEUCourseNotification" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/NEUCourseNotification"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/NEUCourseNotification'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e12a4b9d1e15af25918b1f05e4d394ac622b8e1 [INFO] sha for GitHub repo Ophirr33/NEUCourseNotification: 7e12a4b9d1e15af25918b1f05e4d394ac622b8e1 [INFO] validating manifest of Ophirr33/NEUCourseNotification on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ophirr33/NEUCourseNotification on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ophirr33/NEUCourseNotification [INFO] finished frobbing Ophirr33/NEUCourseNotification [INFO] frobbed toml for Ophirr33/NEUCourseNotification written to work/ex/clippy-test-run/sources/stable/gh/Ophirr33/NEUCourseNotification/Cargo.toml [INFO] started frobbing Ophirr33/NEUCourseNotification [INFO] finished frobbing Ophirr33/NEUCourseNotification [INFO] frobbed toml for Ophirr33/NEUCourseNotification written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/NEUCourseNotification/Cargo.toml [INFO] crate Ophirr33/NEUCourseNotification has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ophirr33/NEUCourseNotification against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ophirr33/NEUCourseNotification:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f3b872fbfafbe03379fb03de3de0ceda37bad189fd29974fd87c9d685351585 [INFO] running `"docker" "start" "-a" "7f3b872fbfafbe03379fb03de3de0ceda37bad189fd29974fd87c9d685351585"` [INFO] [stderr] Checking linked-hash-map v0.2.1 [INFO] [stderr] Compiling libsqlite3-sys v0.7.1 [INFO] [stderr] Checking nix v0.8.0 [INFO] [stderr] Compiling email v0.0.16 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking shared_child v0.2.1 [INFO] [stderr] Checking error-chain v0.8.1 [INFO] [stderr] Checking lru-cache v0.1.0 [INFO] [stderr] Checking rusqlite v0.10.1 [INFO] [stderr] Checking lettre v0.6.2 [INFO] [stderr] Checking os_pipe v0.5.1 [INFO] [stderr] Checking duct v0.8.0 [INFO] [stderr] Checking neu_course_notification v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | course_id: course_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `course_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | course_id: course_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `course_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | course_num: course_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `course_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | term_id: term_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `term_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | url: url [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:95:15 [INFO] [stderr] | [INFO] [stderr] 95 | DAO { conn: conn } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | course_num: course_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `course_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | term_id: term_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `term_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | url: url [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:95:15 [INFO] [stderr] | [INFO] [stderr] 95 | DAO { conn: conn } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:246:36 [INFO] [stderr] | [INFO] [stderr] 246 | assert_eq!(courses[0].term_id, 201760); [INFO] [stderr] | ^^^^^^ help: consider: `201_760` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | let mut dao = DAO::new(Connection::open_in_memory().unwrap()); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | fn create_courses(&mut self, courses: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Course]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:162:39 [INFO] [stderr] | [INFO] [stderr] 162 | .fold(email_base.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `email_base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | fn create_courses(&mut self, courses: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Course]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:162:39 [INFO] [stderr] | [INFO] [stderr] 162 | .fold(email_base.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `email_base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.01s [INFO] running `"docker" "inspect" "7f3b872fbfafbe03379fb03de3de0ceda37bad189fd29974fd87c9d685351585"` [INFO] running `"docker" "rm" "-f" "7f3b872fbfafbe03379fb03de3de0ceda37bad189fd29974fd87c9d685351585"` [INFO] [stdout] 7f3b872fbfafbe03379fb03de3de0ceda37bad189fd29974fd87c9d685351585