[INFO] updating cached repository OpenEnergyDashboard/harf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/OpenEnergyDashboard/harf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/OpenEnergyDashboard/harf" "work/ex/clippy-test-run/sources/stable/gh/OpenEnergyDashboard/harf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OpenEnergyDashboard/harf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/OpenEnergyDashboard/harf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OpenEnergyDashboard/harf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OpenEnergyDashboard/harf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5b731808478c4ceb0da3ff41a59a72541e67d1b [INFO] sha for GitHub repo OpenEnergyDashboard/harf: b5b731808478c4ceb0da3ff41a59a72541e67d1b [INFO] validating manifest of OpenEnergyDashboard/harf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of OpenEnergyDashboard/harf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing OpenEnergyDashboard/harf [INFO] finished frobbing OpenEnergyDashboard/harf [INFO] frobbed toml for OpenEnergyDashboard/harf written to work/ex/clippy-test-run/sources/stable/gh/OpenEnergyDashboard/harf/Cargo.toml [INFO] started frobbing OpenEnergyDashboard/harf [INFO] finished frobbing OpenEnergyDashboard/harf [INFO] frobbed toml for OpenEnergyDashboard/harf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OpenEnergyDashboard/harf/Cargo.toml [INFO] crate OpenEnergyDashboard/harf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting OpenEnergyDashboard/harf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/OpenEnergyDashboard/harf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef943457bf077bc40ae17421141412bb42e51366f39655a2597285d54f3e0f4f [INFO] running `"docker" "start" "-a" "ef943457bf077bc40ae17421141412bb42e51366f39655a2597285d54f3e0f4f"` [INFO] [stderr] Checking hyper v0.11.15 [INFO] [stderr] Checking harf v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:112:35 [INFO] [stderr] | [INFO] [stderr] 112 | Err(e) => (false, format!("{}", e.description())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | .expect(&format!("Could not restart systemd unit {}", &unit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not restart systemd unit {}", &unit))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | .expect(&format!("Could not execute command '{}'", &cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not execute command '{}'", &cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:112:35 [INFO] [stderr] | [INFO] [stderr] 112 | Err(e) => (false, format!("{}", e.description())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.description().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | .expect(&format!("Could not restart systemd unit {}", &unit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not restart systemd unit {}", &unit))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | .expect(&format!("Could not execute command '{}'", &cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not execute command '{}'", &cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.23s [INFO] running `"docker" "inspect" "ef943457bf077bc40ae17421141412bb42e51366f39655a2597285d54f3e0f4f"` [INFO] running `"docker" "rm" "-f" "ef943457bf077bc40ae17421141412bb42e51366f39655a2597285d54f3e0f4f"` [INFO] [stdout] ef943457bf077bc40ae17421141412bb42e51366f39655a2597285d54f3e0f4f