[INFO] updating cached repository Oozekip/rust-graphics [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Oozekip/rust-graphics [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Oozekip/rust-graphics" "work/ex/clippy-test-run/sources/stable/gh/Oozekip/rust-graphics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Oozekip/rust-graphics'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Oozekip/rust-graphics" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Oozekip/rust-graphics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Oozekip/rust-graphics'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b98d31a78d87f42af07b19c0cb16516277910db [INFO] sha for GitHub repo Oozekip/rust-graphics: 9b98d31a78d87f42af07b19c0cb16516277910db [INFO] validating manifest of Oozekip/rust-graphics on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Oozekip/rust-graphics on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Oozekip/rust-graphics [INFO] finished frobbing Oozekip/rust-graphics [INFO] frobbed toml for Oozekip/rust-graphics written to work/ex/clippy-test-run/sources/stable/gh/Oozekip/rust-graphics/Cargo.toml [INFO] started frobbing Oozekip/rust-graphics [INFO] finished frobbing Oozekip/rust-graphics [INFO] frobbed toml for Oozekip/rust-graphics written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Oozekip/rust-graphics/Cargo.toml [INFO] crate Oozekip/rust-graphics has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Oozekip/rust-graphics against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Oozekip/rust-graphics:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5cb7c3f5021c990cf9ee064ef77fb60e869f74bcd5114584796c51b268954758 [INFO] running `"docker" "start" "-a" "5cb7c3f5021c990cf9ee064ef77fb60e869f74bcd5114584796c51b268954758"` [INFO] [stderr] Checking gfx_window_glutin v0.18.0 [INFO] [stderr] Checking rust-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | g: g, [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | light_type: light_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | light_meta: light_meta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | uv: uv, [INFO] [stderr] | ^^^^^^ help: replace it with: `uv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | rotation: rotation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rotation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | specular_power: specular_power, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `specular_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | g: g, [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | light_type: light_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | light_meta: light_meta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | uv: uv, [INFO] [stderr] | ^^^^^^ help: replace it with: `uv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | rotation: rotation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rotation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | specular_power: specular_power, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `specular_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: function is never used: `center_verts` [INFO] [stderr] --> src/mesh_loader.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn center_verts(verts: &[Vector3]) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_tri_from_caps` [INFO] [stderr] --> src/mesh_loader.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / fn get_tri_from_caps( [INFO] [stderr] 151 | | caps: &Captures, [INFO] [stderr] 152 | | uv_compute: &Option, [INFO] [stderr] 153 | | normal_compute: &Option, [INFO] [stderr] ... | [INFO] [stderr] 228 | | (v1, v2, v3) [INFO] [stderr] 229 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | uv_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | normal_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | fn get_tri_regex(uv_fn: &Option, normal_fn: &Option) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:131:54 [INFO] [stderr] | [INFO] [stderr] 131 | fn get_tri_regex(uv_fn: &Option, normal_fn: &Option) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | uv_compute: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | normal_compute: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:233:12 [INFO] [stderr] | [INFO] [stderr] 233 | uv_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:234:16 [INFO] [stderr] | [INFO] [stderr] 234 | normal_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mesh_loader.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | / if let &Some(ref func) = uv_fn { [INFO] [stderr] 298 | | uvs_raw = verts_raw.iter().map(func).collect(); [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 297 | if let Some(ref func) = *uv_fn { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `center_verts` [INFO] [stderr] --> src/mesh_loader.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn center_verts(verts: &[Vector3]) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_tri_from_caps` [INFO] [stderr] --> src/mesh_loader.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / fn get_tri_from_caps( [INFO] [stderr] 151 | | caps: &Captures, [INFO] [stderr] 152 | | uv_compute: &Option, [INFO] [stderr] 153 | | normal_compute: &Option, [INFO] [stderr] ... | [INFO] [stderr] 228 | | (v1, v2, v3) [INFO] [stderr] 229 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | uv_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | normal_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | fn get_tri_regex(uv_fn: &Option, normal_fn: &Option) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:131:54 [INFO] [stderr] | [INFO] [stderr] 131 | fn get_tri_regex(uv_fn: &Option, normal_fn: &Option) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | uv_compute: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | normal_compute: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:233:12 [INFO] [stderr] | [INFO] [stderr] 233 | uv_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mesh_loader.rs:234:16 [INFO] [stderr] | [INFO] [stderr] 234 | normal_fn: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mesh_loader.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | / if let &Some(ref func) = uv_fn { [INFO] [stderr] 298 | | uvs_raw = verts_raw.iter().map(func).collect(); [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 297 | if let Some(ref func) = *uv_fn { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:151:32 [INFO] [stderr] | [INFO] [stderr] 151 | let dt = nano as f32 / 1000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:151:32 [INFO] [stderr] | [INFO] [stderr] 151 | let dt = nano as f32 / 1000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.62s [INFO] running `"docker" "inspect" "5cb7c3f5021c990cf9ee064ef77fb60e869f74bcd5114584796c51b268954758"` [INFO] running `"docker" "rm" "-f" "5cb7c3f5021c990cf9ee064ef77fb60e869f74bcd5114584796c51b268954758"` [INFO] [stdout] 5cb7c3f5021c990cf9ee064ef77fb60e869f74bcd5114584796c51b268954758