[INFO] updating cached repository OneMoreByte/ftp-downloader
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/OneMoreByte/ftp-downloader
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/OneMoreByte/ftp-downloader" "work/ex/clippy-test-run/sources/stable/gh/OneMoreByte/ftp-downloader"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OneMoreByte/ftp-downloader'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/OneMoreByte/ftp-downloader" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OneMoreByte/ftp-downloader"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OneMoreByte/ftp-downloader'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1e2df1590183656dd2f046acff2a55ba5da87776
[INFO] sha for GitHub repo OneMoreByte/ftp-downloader: 1e2df1590183656dd2f046acff2a55ba5da87776
[INFO] validating manifest of OneMoreByte/ftp-downloader on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of OneMoreByte/ftp-downloader on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing OneMoreByte/ftp-downloader
[INFO] finished frobbing OneMoreByte/ftp-downloader
[INFO] frobbed toml for OneMoreByte/ftp-downloader written to work/ex/clippy-test-run/sources/stable/gh/OneMoreByte/ftp-downloader/Cargo.toml
[INFO] started frobbing OneMoreByte/ftp-downloader
[INFO] finished frobbing OneMoreByte/ftp-downloader
[INFO] frobbed toml for OneMoreByte/ftp-downloader written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OneMoreByte/ftp-downloader/Cargo.toml
[INFO] crate OneMoreByte/ftp-downloader has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting OneMoreByte/ftp-downloader against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/OneMoreByte/ftp-downloader:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ba0d6a529854ae4a5e06318b8f3c2f9c32117c7cf7ae0406793d3fb24fd7655a
[INFO] running `"docker" "start" "-a" "ba0d6a529854ae4a5e06318b8f3c2f9c32117c7cf7ae0406793d3fb24fd7655a"`
[INFO] [stderr]     Checking num-traits v0.1.34
[INFO] [stderr]     Checking regex-syntax v0.3.4
[INFO] [stderr]     Checking memchr v0.1.11
[INFO] [stderr]     Checking thread-id v2.0.0
[INFO] [stderr]     Checking aho-corasick v0.5.2
[INFO] [stderr]     Checking thread_local v0.2.6
[INFO] [stderr]     Checking num-integer v0.1.32
[INFO] [stderr]     Checking num-iter v0.1.32
[INFO] [stderr]     Checking num v0.1.34
[INFO] [stderr]     Checking regex v0.1.73
[INFO] [stderr]     Checking chrono v0.2.25
[INFO] [stderr]     Checking ftp v2.0.0
[INFO] [stderr]     Checking ftpdown v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/config.rs:126:13
[INFO] [stderr]     |
[INFO] [stderr] 126 |             print!("\n");
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:337:29
[INFO] [stderr]     |
[INFO] [stderr] 337 |                             print!("\r\n");
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: consider choosing a more descriptive name
[INFO] [stderr]    --> src/main.rs:393:9
[INFO] [stderr]     |
[INFO] [stderr] 393 |     let __ = _a.read_to_string(&mut b);
[INFO] [stderr]     |         ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::just_underscores_and_digits)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/config.rs:126:13
[INFO] [stderr]     |
[INFO] [stderr] 126 |             print!("\n");
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:337:29
[INFO] [stderr]     |
[INFO] [stderr] 337 |                             print!("\r\n");
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: consider choosing a more descriptive name
[INFO] [stderr]    --> src/main.rs:393:9
[INFO] [stderr]     |
[INFO] [stderr] 393 |     let __ = _a.read_to_string(&mut b);
[INFO] [stderr]     |         ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::just_underscores_and_digits)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ftp::FtpStream`
[INFO] [stderr]   --> src/main.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use ftp::FtpStream;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/main.rs:332:37
[INFO] [stderr]     |
[INFO] [stderr] 332 | /                                     ((lsize.checked_mul(100).unwrap())
[INFO] [stderr] 333 | |                                          .checked_div(rsize.unwrap())
[INFO] [stderr] 334 | |                                          .unwrap()),
[INFO] [stderr]     | |___________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 332 |                                     (lsize.checked_mul(100).unwrap())
[INFO] [stderr] 333 |                                          .checked_div(rsize.unwrap())
[INFO] [stderr] 334 |                                          .unwrap(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/main.rs:332:37
[INFO] [stderr]     |
[INFO] [stderr] 332 | /                                     ((lsize.checked_mul(100).unwrap())
[INFO] [stderr] 333 | |                                          .checked_div(rsize.unwrap())
[INFO] [stderr] 334 | |                                          .unwrap()),
[INFO] [stderr]     | |___________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/util.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let mut config_dir = env::home_dir().unwrap().to_str().unwrap().to_string();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:387:22
[INFO] [stderr]     |
[INFO] [stderr] 387 |     let mut conf_d = env::home_dir().unwrap().to_str().unwrap().to_string();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dr`
[INFO] [stderr]    --> src/main.rs:217:51
[INFO] [stderr]     |
[INFO] [stderr] 217 | fn download_from_site(mut config: config::Config, dr: bool) -> std::io::Result<()> {
[INFO] [stderr]     |                                                   ^^ help: consider using `_dr` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dir`
[INFO] [stderr]    --> src/main.rs:347:29
[INFO] [stderr]     |
[INFO] [stderr] 347 |             fn download_dir(dir: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                             ^^^ help: consider using `_dir` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `file`
[INFO] [stderr]    --> src/main.rs:352:29
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                             ^^^^ help: consider using `_file` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:219:9
[INFO] [stderr]     |
[INFO] [stderr] 219 |     let mut ftpstream = config.get_ftpstream();
[INFO] [stderr]     |         ----^^^^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:347:57
[INFO] [stderr]     |
[INFO] [stderr] 347 |             fn download_dir(dir: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                                                         ----^^^^^^^^^
[INFO] [stderr]     |                                                         |
[INFO] [stderr]     |                                                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:352:25
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                         ----^^^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:352:58
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                                                          ----^^^^^^^^^
[INFO] [stderr]     |                                                          |
[INFO] [stderr]     |                                                          help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `download_dir`
[INFO] [stderr]    --> src/main.rs:347:13
[INFO] [stderr]     |
[INFO] [stderr] 347 |             fn download_dir(dir: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `fix_name`
[INFO] [stderr]    --> src/main.rs:352:13
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:11:29
[INFO] [stderr]    |
[INFO] [stderr] 11 |         let loc = temp.find(";").unwrap();
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:28:44
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let remfile = &remfile[..remfile.rfind(";").unwrap().checked_sub(";".len()).unwrap()];
[INFO] [stderr]    |                                            ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:29:41
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let remfile = &remfile[remfile.find("[").unwrap().checked_add("[".len()).unwrap()..];
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config.rs:54:8
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if dlable_f.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dlable_f.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:100:30
[INFO] [stderr]     |
[INFO] [stderr] 100 |             if line.contains(":") {
[INFO] [stderr]     |                              ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/util.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         config_raw.read_to_string(&mut buff);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:241:21
[INFO] [stderr]     |
[INFO] [stderr] 241 |                     t = t + 1;
[INFO] [stderr]     |                     ^^^^^^^^^ help: replace it with: `t += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:248:43
[INFO] [stderr]     |
[INFO] [stderr] 248 |             fn is_downloaded(fileandpath: &String, rsz: &usize) -> Option<bool> {
[INFO] [stderr]     |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:248:57
[INFO] [stderr]     |
[INFO] [stderr] 248 |             fn is_downloaded(fileandpath: &String, rsz: &usize) -> Option<bool> {
[INFO] [stderr]     |                                                         ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:259:28
[INFO] [stderr]     |
[INFO] [stderr] 259 |             fn is_dir(loc: &String) -> bool {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:281:43
[INFO] [stderr]     |
[INFO] [stderr] 281 |                 fn get_filename(full_loc: &String) -> String {
[INFO] [stderr]     |                                           ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 281 |                 fn get_filename(full_loc: &str) -> String {
[INFO] [stderr]     |                                           ^^^^
[INFO] [stderr] help: change `full_loc.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 288 |                     let mut loc: String = full_loc.to_string();
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:403:41
[INFO] [stderr]     |
[INFO] [stderr] 403 |     let (_s1, _s2) = b.split_at(b.rfind("}").unwrap().checked_add("}".len()).unwrap());
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'}'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ftp::FtpStream`
[INFO] [stderr]   --> src/main.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use ftp::FtpStream;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/main.rs:332:37
[INFO] [stderr]     |
[INFO] [stderr] 332 | /                                     ((lsize.checked_mul(100).unwrap())
[INFO] [stderr] 333 | |                                          .checked_div(rsize.unwrap())
[INFO] [stderr] 334 | |                                          .unwrap()),
[INFO] [stderr]     | |___________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 332 |                                     (lsize.checked_mul(100).unwrap())
[INFO] [stderr] 333 |                                          .checked_div(rsize.unwrap())
[INFO] [stderr] 334 |                                          .unwrap(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/main.rs:332:37
[INFO] [stderr]     |
[INFO] [stderr] 332 | /                                     ((lsize.checked_mul(100).unwrap())
[INFO] [stderr] 333 | |                                          .checked_div(rsize.unwrap())
[INFO] [stderr] 334 | |                                          .unwrap()),
[INFO] [stderr]     | |___________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/util.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let mut config_dir = env::home_dir().unwrap().to_str().unwrap().to_string();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:387:22
[INFO] [stderr]     |
[INFO] [stderr] 387 |     let mut conf_d = env::home_dir().unwrap().to_str().unwrap().to_string();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dr`
[INFO] [stderr]    --> src/main.rs:217:51
[INFO] [stderr]     |
[INFO] [stderr] 217 | fn download_from_site(mut config: config::Config, dr: bool) -> std::io::Result<()> {
[INFO] [stderr]     |                                                   ^^ help: consider using `_dr` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dir`
[INFO] [stderr]    --> src/main.rs:347:29
[INFO] [stderr]     |
[INFO] [stderr] 347 |             fn download_dir(dir: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                             ^^^ help: consider using `_dir` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `file`
[INFO] [stderr]    --> src/main.rs:352:29
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                             ^^^^ help: consider using `_file` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:219:9
[INFO] [stderr]     |
[INFO] [stderr] 219 |     let mut ftpstream = config.get_ftpstream();
[INFO] [stderr]     |         ----^^^^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:347:57
[INFO] [stderr]     |
[INFO] [stderr] 347 |             fn download_dir(dir: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                                                         ----^^^^^^^^^
[INFO] [stderr]     |                                                         |
[INFO] [stderr]     |                                                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:352:25
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                         ----^^^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:352:58
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |                                                          ----^^^^^^^^^
[INFO] [stderr]     |                                                          |
[INFO] [stderr]     |                                                          help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `download_dir`
[INFO] [stderr]    --> src/main.rs:347:13
[INFO] [stderr]     |
[INFO] [stderr] 347 |             fn download_dir(dir: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `fix_name`
[INFO] [stderr]    --> src/main.rs:352:13
[INFO] [stderr]     |
[INFO] [stderr] 352 |             fn fix_name(mut file: &config::Downloadable, mut ftpstream: ftp::FtpStream) -> ftp::FtpStream {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:11:29
[INFO] [stderr]    |
[INFO] [stderr] 11 |         let loc = temp.find(";").unwrap();
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:28:44
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let remfile = &remfile[..remfile.rfind(";").unwrap().checked_sub(";".len()).unwrap()];
[INFO] [stderr]    |                                            ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:29:41
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let remfile = &remfile[remfile.find("[").unwrap().checked_add("[".len()).unwrap()..];
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config.rs:54:8
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if dlable_f.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dlable_f.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:100:30
[INFO] [stderr]     |
[INFO] [stderr] 100 |             if line.contains(":") {
[INFO] [stderr]     |                              ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/util.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         config_raw.read_to_string(&mut buff);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:241:21
[INFO] [stderr]     |
[INFO] [stderr] 241 |                     t = t + 1;
[INFO] [stderr]     |                     ^^^^^^^^^ help: replace it with: `t += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:248:43
[INFO] [stderr]     |
[INFO] [stderr] 248 |             fn is_downloaded(fileandpath: &String, rsz: &usize) -> Option<bool> {
[INFO] [stderr]     |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:248:57
[INFO] [stderr]     |
[INFO] [stderr] 248 |             fn is_downloaded(fileandpath: &String, rsz: &usize) -> Option<bool> {
[INFO] [stderr]     |                                                         ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:259:28
[INFO] [stderr]     |
[INFO] [stderr] 259 |             fn is_dir(loc: &String) -> bool {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:281:43
[INFO] [stderr]     |
[INFO] [stderr] 281 |                 fn get_filename(full_loc: &String) -> String {
[INFO] [stderr]     |                                           ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 281 |                 fn get_filename(full_loc: &str) -> String {
[INFO] [stderr]     |                                           ^^^^
[INFO] [stderr] help: change `full_loc.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 288 |                     let mut loc: String = full_loc.to_string();
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:403:41
[INFO] [stderr]     |
[INFO] [stderr] 403 |     let (_s1, _s2) = b.split_at(b.rfind("}").unwrap().checked_add("}".len()).unwrap());
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'}'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.69s
[INFO] running `"docker" "inspect" "ba0d6a529854ae4a5e06318b8f3c2f9c32117c7cf7ae0406793d3fb24fd7655a"`
[INFO] running `"docker" "rm" "-f" "ba0d6a529854ae4a5e06318b8f3c2f9c32117c7cf7ae0406793d3fb24fd7655a"`
[INFO] [stdout] ba0d6a529854ae4a5e06318b8f3c2f9c32117c7cf7ae0406793d3fb24fd7655a