[INFO] updating cached repository OffBlockway/OffBlockwayMiningClient [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/OffBlockway/OffBlockwayMiningClient [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/OffBlockway/OffBlockwayMiningClient" "work/ex/clippy-test-run/sources/stable/gh/OffBlockway/OffBlockwayMiningClient"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OffBlockway/OffBlockwayMiningClient'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/OffBlockway/OffBlockwayMiningClient" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OffBlockway/OffBlockwayMiningClient"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OffBlockway/OffBlockwayMiningClient'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6fc1cfb70b1656b364916575b4405331ae0f6a8f [INFO] sha for GitHub repo OffBlockway/OffBlockwayMiningClient: 6fc1cfb70b1656b364916575b4405331ae0f6a8f [INFO] validating manifest of OffBlockway/OffBlockwayMiningClient on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of OffBlockway/OffBlockwayMiningClient on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing OffBlockway/OffBlockwayMiningClient [INFO] finished frobbing OffBlockway/OffBlockwayMiningClient [INFO] frobbed toml for OffBlockway/OffBlockwayMiningClient written to work/ex/clippy-test-run/sources/stable/gh/OffBlockway/OffBlockwayMiningClient/Cargo.toml [INFO] started frobbing OffBlockway/OffBlockwayMiningClient [INFO] finished frobbing OffBlockway/OffBlockwayMiningClient [INFO] frobbed toml for OffBlockway/OffBlockwayMiningClient written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OffBlockway/OffBlockwayMiningClient/Cargo.toml [INFO] crate OffBlockway/OffBlockwayMiningClient has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting OffBlockway/OffBlockwayMiningClient against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/OffBlockway/OffBlockwayMiningClient:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89a2fddd15a2e933752795e8c5b8ff24e45d02785c8aa702b661daa7e8749035 [INFO] running `"docker" "start" "-a" "89a2fddd15a2e933752795e8c5b8ff24e45d02785c8aa702b661daa7e8749035"` [INFO] [stderr] Checking sha3 v0.6.0 [INFO] [stderr] Checking off_blockway v0.0.8 [INFO] [stderr] Checking mining_client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | print!( "{}\n", styling::HEADER ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | print!( "{}\n", styling::HEADER ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/json.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | pass [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/json.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | let pass = Passport [INFO] [stderr] | ____________________^ [INFO] [stderr] 122 | | { [INFO] [stderr] 123 | | [INFO] [stderr] 124 | | uid: unique_hash, [INFO] [stderr] ... | [INFO] [stderr] 127 | | [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/json.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | miner [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/json.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | let miner = Miner [INFO] [stderr] | _____________________^ [INFO] [stderr] 208 | | { [INFO] [stderr] 209 | | [INFO] [stderr] 210 | | // Sets the fields of the miner to the values calculated above [INFO] [stderr] ... | [INFO] [stderr] 214 | | [INFO] [stderr] 215 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/json.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | pass [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/json.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | let pass = Passport [INFO] [stderr] | ____________________^ [INFO] [stderr] 122 | | { [INFO] [stderr] 123 | | [INFO] [stderr] 124 | | uid: unique_hash, [INFO] [stderr] ... | [INFO] [stderr] 127 | | [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/json.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | miner [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/json.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | let miner = Miner [INFO] [stderr] | _____________________^ [INFO] [stderr] 208 | | { [INFO] [stderr] 209 | | [INFO] [stderr] 210 | | // Sets the fields of the miner to the values calculated above [INFO] [stderr] ... | [INFO] [stderr] 214 | | [INFO] [stderr] 215 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/json.rs:263:33 [INFO] [stderr] | [INFO] [stderr] 263 | let transaction = &*nodes.get( i ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `nodes[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json.rs:470:24 [INFO] [stderr] | [INFO] [stderr] 470 | let question = self.log.get( index ).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.log.get( index )` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | file.read_to_string( &mut buffer ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:233:55 [INFO] [stderr] | [INFO] [stderr] 233 | println!( "\nOption {}: {}\n", index + 1, options.get( index ).unwrap() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `options[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:245:29 [INFO] [stderr] | [INFO] [stderr] 245 | if input.clone() == question.correct().to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `question.correct()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/json.rs:263:33 [INFO] [stderr] | [INFO] [stderr] 263 | let transaction = &*nodes.get( i ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `nodes[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json.rs:470:24 [INFO] [stderr] | [INFO] [stderr] 470 | let question = self.log.get( index ).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.log.get( index )` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | file.read_to_string( &mut buffer ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:233:55 [INFO] [stderr] | [INFO] [stderr] 233 | println!( "\nOption {}: {}\n", index + 1, options.get( index ).unwrap() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `options[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:245:29 [INFO] [stderr] | [INFO] [stderr] 245 | if input.clone() == question.correct().to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `question.correct()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.12s [INFO] running `"docker" "inspect" "89a2fddd15a2e933752795e8c5b8ff24e45d02785c8aa702b661daa7e8749035"` [INFO] running `"docker" "rm" "-f" "89a2fddd15a2e933752795e8c5b8ff24e45d02785c8aa702b661daa7e8749035"` [INFO] [stdout] 89a2fddd15a2e933752795e8c5b8ff24e45d02785c8aa702b661daa7e8749035