[INFO] updating cached repository Object905/rust_srt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Object905/rust_srt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Object905/rust_srt" "work/ex/clippy-test-run/sources/stable/gh/Object905/rust_srt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Object905/rust_srt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Object905/rust_srt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Object905/rust_srt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Object905/rust_srt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 635366837df69939fb4a1ffc144d24ff9c0da13e [INFO] sha for GitHub repo Object905/rust_srt: 635366837df69939fb4a1ffc144d24ff9c0da13e [INFO] validating manifest of Object905/rust_srt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Object905/rust_srt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Object905/rust_srt [INFO] finished frobbing Object905/rust_srt [INFO] frobbed toml for Object905/rust_srt written to work/ex/clippy-test-run/sources/stable/gh/Object905/rust_srt/Cargo.toml [INFO] started frobbing Object905/rust_srt [INFO] finished frobbing Object905/rust_srt [INFO] frobbed toml for Object905/rust_srt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Object905/rust_srt/Cargo.toml [INFO] crate Object905/rust_srt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Object905/rust_srt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Object905/rust_srt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9249028c44ced7c236de61cd87e33b86cb5148866893bafd40de384e81ef0802 [INFO] running `"docker" "start" "-a" "9249028c44ced7c236de61cd87e33b86cb5148866893bafd40de384e81ef0802"` [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.6 [INFO] [stderr] Checking aho-corasick v0.5.2 [INFO] [stderr] Checking regex v0.1.73 [INFO] [stderr] Checking srt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | miliseconds: miliseconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | miliseconds: miliseconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/utils.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/utils.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | miliseconds: miliseconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timestamp.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | miliseconds: miliseconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/utils.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/utils.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subline.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subtitles.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timestamp.rs:379:46 [INFO] [stderr] | [INFO] [stderr] 379 | let t1 = Timestamp::new(0, 0, 3, 600000); [INFO] [stderr] | ^^^^^^ help: consider: `600_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timestamp.rs:441:47 [INFO] [stderr] | [INFO] [stderr] 441 | let t3 = Timestamp::from_microseconds(61001000); [INFO] [stderr] | ^^^^^^^^ help: consider: `61_001_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | result += self.miliseconds as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.miliseconds)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | result += (self.seconds as u64) * 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | result += (self.minutes as u64) * 60_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | result += (self.hours as u64) * 360_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | let mut miliseconds = (self.miliseconds + other.miliseconds) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.miliseconds + other.miliseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:107:27 [INFO] [stderr] | [INFO] [stderr] 107 | let mut seconds = (self.seconds + other.seconds) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.seconds + other.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | let mut minutes = (self.minutes + other.minutes) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.minutes + other.minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let mut hours = (self.hours + other.hours) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.hours + other.hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | let to_seconds = miliseconds / 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | miliseconds -= to_seconds * 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:118:38 [INFO] [stderr] | [INFO] [stderr] 118 | let to_minutes = seconds / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | seconds -= to_minutes * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:124:36 [INFO] [stderr] | [INFO] [stderr] 124 | let to_hours = minutes / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | minutes -= to_hours * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:146:47 [INFO] [stderr] | [INFO] [stderr] 146 | let to_seconds = self.miliseconds / 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:148:44 [INFO] [stderr] | [INFO] [stderr] 148 | self.miliseconds -= to_seconds * 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:152:43 [INFO] [stderr] | [INFO] [stderr] 152 | let to_minutes = self.seconds / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:154:40 [INFO] [stderr] | [INFO] [stderr] 154 | self.seconds -= to_minutes * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:158:41 [INFO] [stderr] | [INFO] [stderr] 158 | let to_hours = self.minutes / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | self.minutes -= to_hours * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/timestamp.rs:230:12 [INFO] [stderr] | [INFO] [stderr] 230 | if self < &mut other { [INFO] [stderr] | ^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: item `subtitles::Subtitles` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/subtitles.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / impl Subtitles { [INFO] [stderr] 18 | | /// Returns the number of elements. [INFO] [stderr] 19 | | pub fn len(&self) -> usize { [INFO] [stderr] 20 | | self.inner.len() [INFO] [stderr] ... | [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/subtitles.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | indexed_subline.as_ref().map(|elem| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 54 | || if elem.index != index as u32 { [INFO] [stderr] 55 | || panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stderr] 56 | || sorted and also unterlying SubLine's indices must be correct"); [INFO] [stderr] 57 | || } [INFO] [stderr] 58 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(elem) = indexed_subline.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/subtitles.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | indexed_subline.as_ref().map(|elem| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 72 | || if elem.index != index as u32 { [INFO] [stderr] 73 | || panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stderr] 74 | || sorted and also unterlying SubLine's indices must be correct"); [INFO] [stderr] 75 | || } [INFO] [stderr] 76 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(elem) = indexed_subline.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:114:25 [INFO] [stderr] | [INFO] [stderr] 114 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:142:25 [INFO] [stderr] | [INFO] [stderr] 142 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:167:25 [INFO] [stderr] | [INFO] [stderr] 167 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/subtitles.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | / fn index<'a>(&'a self, index: usize) -> &'a Self::Output { [INFO] [stderr] 308 | | &self.inner[index] [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `srt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | result += self.miliseconds as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.miliseconds)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | result += (self.seconds as u64) * 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | result += (self.minutes as u64) * 60_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | result += (self.hours as u64) * 360_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | let mut miliseconds = (self.miliseconds + other.miliseconds) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.miliseconds + other.miliseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:107:27 [INFO] [stderr] | [INFO] [stderr] 107 | let mut seconds = (self.seconds + other.seconds) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.seconds + other.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | let mut minutes = (self.minutes + other.minutes) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.minutes + other.minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timestamp.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let mut hours = (self.hours + other.hours) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.hours + other.hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | let to_seconds = miliseconds / 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | miliseconds -= to_seconds * 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:118:38 [INFO] [stderr] | [INFO] [stderr] 118 | let to_minutes = seconds / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | seconds -= to_minutes * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:124:36 [INFO] [stderr] | [INFO] [stderr] 124 | let to_hours = minutes / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/timestamp.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | minutes -= to_hours * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:146:47 [INFO] [stderr] | [INFO] [stderr] 146 | let to_seconds = self.miliseconds / 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:148:44 [INFO] [stderr] | [INFO] [stderr] 148 | self.miliseconds -= to_seconds * 1000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:152:43 [INFO] [stderr] | [INFO] [stderr] 152 | let to_minutes = self.seconds / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:154:40 [INFO] [stderr] | [INFO] [stderr] 154 | self.seconds -= to_minutes * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:158:41 [INFO] [stderr] | [INFO] [stderr] 158 | let to_hours = self.minutes / 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/timestamp.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | self.minutes -= to_hours * 60; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/timestamp.rs:230:12 [INFO] [stderr] | [INFO] [stderr] 230 | if self < &mut other { [INFO] [stderr] | ^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/timestamp.rs:282:18 [INFO] [stderr] | [INFO] [stderr] 282 | let t2 = t1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `t1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/timestamp.rs:324:22 [INFO] [stderr] | [INFO] [stderr] 324 | let t2 = t1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `t1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/timestamp.rs:332:22 [INFO] [stderr] | [INFO] [stderr] 332 | let t2 = t1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `t1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/timestamp.rs:398:22 [INFO] [stderr] | [INFO] [stderr] 398 | let t3 = t2.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `t2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: item `subtitles::Subtitles` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/subtitles.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / impl Subtitles { [INFO] [stderr] 18 | | /// Returns the number of elements. [INFO] [stderr] 19 | | pub fn len(&self) -> usize { [INFO] [stderr] 20 | | self.inner.len() [INFO] [stderr] ... | [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/subtitles.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | indexed_subline.as_ref().map(|elem| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 54 | || if elem.index != index as u32 { [INFO] [stderr] 55 | || panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stderr] 56 | || sorted and also unterlying SubLine's indices must be correct"); [INFO] [stderr] 57 | || } [INFO] [stderr] 58 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(elem) = indexed_subline.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/subtitles.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | indexed_subline.as_ref().map(|elem| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 72 | || if elem.index != index as u32 { [INFO] [stderr] 73 | || panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stderr] 74 | || sorted and also unterlying SubLine's indices must be correct"); [INFO] [stderr] 75 | || } [INFO] [stderr] 76 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(elem) = indexed_subline.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:114:25 [INFO] [stderr] | [INFO] [stderr] 114 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:142:25 [INFO] [stderr] | [INFO] [stderr] 142 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subtitles.rs:167:25 [INFO] [stderr] | [INFO] [stderr] 167 | let guess = self.inner.get(guess_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.inner[guess_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/subtitles.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | / fn index<'a>(&'a self, index: usize) -> &'a Self::Output { [INFO] [stderr] 308 | | &self.inner[index] [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `srt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9249028c44ced7c236de61cd87e33b86cb5148866893bafd40de384e81ef0802"` [INFO] running `"docker" "rm" "-f" "9249028c44ced7c236de61cd87e33b86cb5148866893bafd40de384e81ef0802"` [INFO] [stdout] 9249028c44ced7c236de61cd87e33b86cb5148866893bafd40de384e81ef0802