[INFO] updating cached repository NyxCode/heaven-on-earth [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NyxCode/heaven-on-earth [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NyxCode/heaven-on-earth" "work/ex/clippy-test-run/sources/stable/gh/NyxCode/heaven-on-earth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NyxCode/heaven-on-earth'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NyxCode/heaven-on-earth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NyxCode/heaven-on-earth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NyxCode/heaven-on-earth'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3504ec7cc901b0078a96f7bcdef5247e89fb3263 [INFO] sha for GitHub repo NyxCode/heaven-on-earth: 3504ec7cc901b0078a96f7bcdef5247e89fb3263 [INFO] validating manifest of NyxCode/heaven-on-earth on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NyxCode/heaven-on-earth on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NyxCode/heaven-on-earth [INFO] finished frobbing NyxCode/heaven-on-earth [INFO] frobbed toml for NyxCode/heaven-on-earth written to work/ex/clippy-test-run/sources/stable/gh/NyxCode/heaven-on-earth/Cargo.toml [INFO] started frobbing NyxCode/heaven-on-earth [INFO] finished frobbing NyxCode/heaven-on-earth [INFO] frobbed toml for NyxCode/heaven-on-earth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NyxCode/heaven-on-earth/Cargo.toml [INFO] crate NyxCode/heaven-on-earth has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NyxCode/heaven-on-earth against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NyxCode/heaven-on-earth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b469a0ebc1aeae367953cf4dddc2f1d4ab3bd5c2aab2e956279f43c0f71a30df [INFO] running `"docker" "start" "-a" "b469a0ebc1aeae367953cf4dddc2f1d4ab3bd5c2aab2e956279f43c0f71a30df"` [INFO] [stderr] Compiling proc-macro2 v0.4.14 [INFO] [stderr] Checking enquote v1.0.3 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Checking immeta v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking cron v0.6.0 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking job_scheduler v1.0.5 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking wallpaper v2.0.0 [INFO] [stderr] Checking heaven-on-earth v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub const CONFIG_FILE_NAME: &'static str = "config.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | pub const RUN_BY_DEFAULT: &'static str = ".run-on-default"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration.rs:8:25 [INFO] [stderr] | [INFO] [stderr] 8 | pub const INSTALL_DIR: &'static str = ".heaven-on-earth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/platform/linux.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Command` [INFO] [stderr] --> src/platform/linux.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::process::Command; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub const CONFIG_FILE_NAME: &'static str = "config.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | pub const RUN_BY_DEFAULT: &'static str = ".run-on-default"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration.rs:8:25 [INFO] [stderr] | [INFO] [stderr] 8 | pub const INSTALL_DIR: &'static str = ".heaven-on-earth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/platform/linux.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Command` [INFO] [stderr] --> src/platform/linux.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::process::Command; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/platform/linux.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn install(config: &Configuration) -> Result<(), String> { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `current_exe_name` [INFO] [stderr] --> src/utils.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn current_exe_name() -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/configuration.rs:105:32 [INFO] [stderr] | [INFO] [stderr] 105 | fn get(settings: &Vec, selector: F) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Settings]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/configuration.rs:121:47 [INFO] [stderr] | [INFO] [stderr] 121 | min_res: get(&settings, |setting| setting.min_res.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `setting.min_res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reddit.rs:73:23 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn identifier(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utils.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | .ok_or_else(|| format!("Could not get filename"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not get filename".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utils.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | .ok_or_else(|| format!("Could not convert to string")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not convert to string".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wallpaper.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | / match already_downloaded_file { [INFO] [stderr] 202 | | Some(file) => { [INFO] [stderr] 203 | | self.file = Some(file.clone()); [INFO] [stderr] 204 | | let mut file = [INFO] [stderr] ... | [INFO] [stderr] 211 | | None => (), [INFO] [stderr] 212 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Some(file) = already_downloaded_file { [INFO] [stderr] 202 | self.file = Some(file.clone()); [INFO] [stderr] 203 | let mut file = [INFO] [stderr] 204 | File::open(file).map_err(|error| format!("Could not open file: {}", error))?; [INFO] [stderr] 205 | let mut bytes = Vec::new(); [INFO] [stderr] 206 | file.read(&mut bytes) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:102:57 [INFO] [stderr] | [INFO] [stderr] 102 | fn run_repeating(config: &Configuration, cron_expr: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/platform/linux.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn install(config: &Configuration) -> Result<(), String> { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `current_exe_name` [INFO] [stderr] --> src/utils.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn current_exe_name() -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/configuration.rs:105:32 [INFO] [stderr] | [INFO] [stderr] 105 | fn get(settings: &Vec, selector: F) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Settings]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/configuration.rs:121:47 [INFO] [stderr] | [INFO] [stderr] 121 | min_res: get(&settings, |setting| setting.min_res.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `setting.min_res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reddit.rs:73:23 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn identifier(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utils.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | .ok_or_else(|| format!("Could not get filename"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not get filename".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utils.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | .ok_or_else(|| format!("Could not convert to string")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not convert to string".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wallpaper.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | / match already_downloaded_file { [INFO] [stderr] 202 | | Some(file) => { [INFO] [stderr] 203 | | self.file = Some(file.clone()); [INFO] [stderr] 204 | | let mut file = [INFO] [stderr] ... | [INFO] [stderr] 211 | | None => (), [INFO] [stderr] 212 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Some(file) = already_downloaded_file { [INFO] [stderr] 202 | self.file = Some(file.clone()); [INFO] [stderr] 203 | let mut file = [INFO] [stderr] 204 | File::open(file).map_err(|error| format!("Could not open file: {}", error))?; [INFO] [stderr] 205 | let mut bytes = Vec::new(); [INFO] [stderr] 206 | file.read(&mut bytes) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:102:57 [INFO] [stderr] | [INFO] [stderr] 102 | fn run_repeating(config: &Configuration, cron_expr: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.42s [INFO] running `"docker" "inspect" "b469a0ebc1aeae367953cf4dddc2f1d4ab3bd5c2aab2e956279f43c0f71a30df"` [INFO] running `"docker" "rm" "-f" "b469a0ebc1aeae367953cf4dddc2f1d4ab3bd5c2aab2e956279f43c0f71a30df"` [INFO] [stdout] b469a0ebc1aeae367953cf4dddc2f1d4ab3bd5c2aab2e956279f43c0f71a30df