[INFO] updating cached repository Nyrox/celtic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Nyrox/celtic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Nyrox/celtic" "work/ex/clippy-test-run/sources/stable/gh/Nyrox/celtic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nyrox/celtic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Nyrox/celtic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nyrox/celtic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nyrox/celtic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e47cc259500019dafd71abcf99868fcd3e99fa5f [INFO] sha for GitHub repo Nyrox/celtic: e47cc259500019dafd71abcf99868fcd3e99fa5f [INFO] validating manifest of Nyrox/celtic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Nyrox/celtic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Nyrox/celtic [INFO] finished frobbing Nyrox/celtic [INFO] frobbed toml for Nyrox/celtic written to work/ex/clippy-test-run/sources/stable/gh/Nyrox/celtic/Cargo.toml [INFO] started frobbing Nyrox/celtic [INFO] finished frobbing Nyrox/celtic [INFO] frobbed toml for Nyrox/celtic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nyrox/celtic/Cargo.toml [INFO] crate Nyrox/celtic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Nyrox/celtic against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Nyrox/celtic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef3cf4146b288047409ec5f683da52a1feab8846db889b7d0c6489549cc4c95f [INFO] running `"docker" "start" "-a" "ef3cf4146b288047409ec5f683da52a1feab8846db889b7d0c6489549cc4c95f"` [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling derive-error-chain v0.11.0 [INFO] [stderr] Checking dotenv v0.11.0 [INFO] [stderr] Checking nomorebullshit-compiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/macros.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | return Ok(MacroValue::STRING(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MacroValue::STRING(buffer))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:130:3 [INFO] [stderr] | [INFO] [stderr] 130 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | if c == '#' { [INFO] [stderr] | _____________^ [INFO] [stderr] 57 | | if chars.peek().unwrap() == &'[' { [INFO] [stderr] 58 | | chars.next(); [INFO] [stderr] 59 | | // Heeey we encountered a macro [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | if c == '#' && chars.peek().unwrap() == &'[' { [INFO] [stderr] 57 | chars.next(); [INFO] [stderr] 58 | // Heeey we encountered a macro [INFO] [stderr] 59 | let mut macro_inner = (|| { [INFO] [stderr] 60 | let mut buffer = String::new(); [INFO] [stderr] 61 | while let Some(c) = chars.next() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:87:11 [INFO] [stderr] | [INFO] [stderr] 87 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:2 [INFO] [stderr] | [INFO] [stderr] 187 | return env::var(&arguments[0]).unwrap_or("undefined".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::var(&arguments[0]).unwrap_or("undefined".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:252:2 [INFO] [stderr] | [INFO] [stderr] 252 | return arguments; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:265:2 [INFO] [stderr] | [INFO] [stderr] 265 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:276:2 [INFO] [stderr] | [INFO] [stderr] 276 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/macros.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | return Ok(MacroValue::STRING(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MacroValue::STRING(buffer))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:130:3 [INFO] [stderr] | [INFO] [stderr] 130 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | if c == '#' { [INFO] [stderr] | _____________^ [INFO] [stderr] 57 | | if chars.peek().unwrap() == &'[' { [INFO] [stderr] 58 | | chars.next(); [INFO] [stderr] 59 | | // Heeey we encountered a macro [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | if c == '#' && chars.peek().unwrap() == &'[' { [INFO] [stderr] 57 | chars.next(); [INFO] [stderr] 58 | // Heeey we encountered a macro [INFO] [stderr] 59 | let mut macro_inner = (|| { [INFO] [stderr] 60 | let mut buffer = String::new(); [INFO] [stderr] 61 | while let Some(c) = chars.next() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:87:11 [INFO] [stderr] | [INFO] [stderr] 87 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:2 [INFO] [stderr] | [INFO] [stderr] 187 | return env::var(&arguments[0]).unwrap_or("undefined".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::var(&arguments[0]).unwrap_or("undefined".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:252:2 [INFO] [stderr] | [INFO] [stderr] 252 | return arguments; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:265:2 [INFO] [stderr] | [INFO] [stderr] 265 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:276:2 [INFO] [stderr] | [INFO] [stderr] 276 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/main.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | if let Some(input) = options.input { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:167:6 [INFO] [stderr] | [INFO] [stderr] 167 | let mut output = ExecutionContext::new(&buffer).execute(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `env` [INFO] [stderr] --> src/main.rs:186:1 [INFO] [stderr] | [INFO] [stderr] 186 | fn env(arguments: Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_word_if` [INFO] [stderr] --> src/main.rs:268:1 [INFO] [stderr] | [INFO] [stderr] 268 | fn parse_word_if, Cond: Fn(char) -> bool>(chars: &mut It, cond: Cond) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:164:2 [INFO] [stderr] | [INFO] [stderr] 164 | input_file.read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `outFile` should have a snake case name such as `out_file` [INFO] [stderr] --> src/main.rs:171:6 [INFO] [stderr] | [INFO] [stderr] 171 | let mut outFile = File::create(options.out.unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:172:2 [INFO] [stderr] | [INFO] [stderr] 172 | outFile.write_all(output.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:187:33 [INFO] [stderr] | [INFO] [stderr] 187 | return env::var(&arguments[0]).unwrap_or("undefined".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "undefined".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:202:2 [INFO] [stderr] | [INFO] [stderr] 202 | let mut arguments = Vec::new(); [INFO] [stderr] | _____^ [INFO] [stderr] 203 | | if chars.peek().unwrap().is_alphanumeric() { [INFO] [stderr] 204 | | arguments = parse_arguments(&mut chars); [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let arguments = if chars.peek().unwrap().is_alphanumeric() { parse_arguments(&mut chars) } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:271:22 [INFO] [stderr] | [INFO] [stderr] 271 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/main.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | if let Some(input) = options.input { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:167:6 [INFO] [stderr] | [INFO] [stderr] 167 | let mut output = ExecutionContext::new(&buffer).execute(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `env` [INFO] [stderr] --> src/main.rs:186:1 [INFO] [stderr] | [INFO] [stderr] 186 | fn env(arguments: Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_word_if` [INFO] [stderr] --> src/main.rs:268:1 [INFO] [stderr] | [INFO] [stderr] 268 | fn parse_word_if, Cond: Fn(char) -> bool>(chars: &mut It, cond: Cond) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:164:2 [INFO] [stderr] | [INFO] [stderr] 164 | input_file.read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `outFile` should have a snake case name such as `out_file` [INFO] [stderr] --> src/main.rs:171:6 [INFO] [stderr] | [INFO] [stderr] 171 | let mut outFile = File::create(options.out.unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:172:2 [INFO] [stderr] | [INFO] [stderr] 172 | outFile.write_all(output.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:187:33 [INFO] [stderr] | [INFO] [stderr] 187 | return env::var(&arguments[0]).unwrap_or("undefined".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "undefined".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:202:2 [INFO] [stderr] | [INFO] [stderr] 202 | let mut arguments = Vec::new(); [INFO] [stderr] | _____^ [INFO] [stderr] 203 | | if chars.peek().unwrap().is_alphanumeric() { [INFO] [stderr] 204 | | arguments = parse_arguments(&mut chars); [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let arguments = if chars.peek().unwrap().is_alphanumeric() { parse_arguments(&mut chars) } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:271:22 [INFO] [stderr] | [INFO] [stderr] 271 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.28s [INFO] running `"docker" "inspect" "ef3cf4146b288047409ec5f683da52a1feab8846db889b7d0c6489549cc4c95f"` [INFO] running `"docker" "rm" "-f" "ef3cf4146b288047409ec5f683da52a1feab8846db889b7d0c6489549cc4c95f"` [INFO] [stdout] ef3cf4146b288047409ec5f683da52a1feab8846db889b7d0c6489549cc4c95f