[INFO] updating cached repository NurbsOtter/tinyrs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/NurbsOtter/tinyrs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/NurbsOtter/tinyrs" "work/ex/clippy-test-run/sources/stable/gh/NurbsOtter/tinyrs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NurbsOtter/tinyrs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/NurbsOtter/tinyrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NurbsOtter/tinyrs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NurbsOtter/tinyrs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] aa40777f101da5fc3aab4374d854ff892dbec612
[INFO] sha for GitHub repo NurbsOtter/tinyrs: aa40777f101da5fc3aab4374d854ff892dbec612
[INFO] validating manifest of NurbsOtter/tinyrs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of NurbsOtter/tinyrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing NurbsOtter/tinyrs
[INFO] finished frobbing NurbsOtter/tinyrs
[INFO] frobbed toml for NurbsOtter/tinyrs written to work/ex/clippy-test-run/sources/stable/gh/NurbsOtter/tinyrs/Cargo.toml
[INFO] started frobbing NurbsOtter/tinyrs
[INFO] finished frobbing NurbsOtter/tinyrs
[INFO] frobbed toml for NurbsOtter/tinyrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NurbsOtter/tinyrs/Cargo.toml
[INFO] crate NurbsOtter/tinyrs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting NurbsOtter/tinyrs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NurbsOtter/tinyrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e3f67bc471b38e63fac1ca4f13cb8168272580518a45177fd84f9faa352210fe
[INFO] running `"docker" "start" "-a" "e3f67bc471b38e63fac1ca4f13cb8168272580518a45177fd84f9faa352210fe"`
[INFO] [stderr]     Checking ws v0.7.3
[INFO] [stderr]     Checking iron v0.5.1
[INFO] [stderr]     Checking mount v0.3.0
[INFO] [stderr]     Checking router v0.5.1
[INFO] [stderr]     Checking logger v0.3.0
[INFO] [stderr]     Checking staticfile v0.4.0
[INFO] [stderr]     Checking tinyrs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/socket_server/client.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |     Client{id:id,out:out,gamestate:gs}
[INFO] [stderr]    |            ^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/socket_server/client.rs:39:15
[INFO] [stderr]    |
[INFO] [stderr] 39 |     Client{id:id,out:out,gamestate:gs}
[INFO] [stderr]    |                  ^^^^^^^ help: replace it with: `out`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/socket_server/client.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |     Client{id:id,out:out,gamestate:gs}
[INFO] [stderr]    |            ^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/socket_server/client.rs:39:15
[INFO] [stderr]    |
[INFO] [stderr] 39 |     Client{id:id,out:out,gamestate:gs}
[INFO] [stderr]    |                  ^^^^^^^ help: replace it with: `out`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `env_logger`
[INFO] [stderr]  --> src/web_server/mod.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use env_logger;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `socket_server::gamestate`
[INFO] [stderr]  --> src/socket_server/client.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use socket_server::gamestate;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `socket_server::client::Client`
[INFO] [stderr]  --> src/socket_server/gamestate.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use socket_server::client::Client;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/socket_server/mod.rs:17:4
[INFO] [stderr]    |
[INFO] [stderr] 17 |             return client;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: remove `return` as shown: `client`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `env_logger`
[INFO] [stderr]  --> src/web_server/mod.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use env_logger;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `socket_server::gamestate`
[INFO] [stderr]  --> src/socket_server/client.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use socket_server::gamestate;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `socket_server::client::Client`
[INFO] [stderr]  --> src/socket_server/gamestate.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use socket_server::client::Client;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/socket_server/mod.rs:17:4
[INFO] [stderr]    |
[INFO] [stderr] 17 |             return client;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: remove `return` as shown: `client`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/socket_server/mod.rs:20:8
[INFO] [stderr]    |
[INFO] [stderr] 20 |             Err(err) =>println!("Socket error"),
[INFO] [stderr]    |                 ^^^ help: consider using `_err` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/socket_server/mod.rs:20:8
[INFO] [stderr]    |
[INFO] [stderr] 20 |             Err(err) =>println!("Socket error"),
[INFO] [stderr]    |                 ^^^ help: consider using `_err` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `hello_test`
[INFO] [stderr]  --> src/web_server/mod.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn hello_test(_: &mut Request)->IronResult<Response>{
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `hello_test`
[INFO] [stderr]  --> src/web_server/mod.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn hello_test(_: &mut Request)->IronResult<Response>{
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method `sendAll` should have a snake case name such as `send_all`
[INFO] [stderr]   --> src/socket_server/gamestate.rs:19:2
[INFO] [stderr]    |
[INFO] [stderr] 19 |       pub fn sendAll(&mut self, message: String,id: u64){
[INFO] [stderr]    |  _____^
[INFO] [stderr] 20 | |         for (key,_) in &self.clients{
[INFO] [stderr] 21 | |             if *key != id{
[INFO] [stderr] 22 | |                 match self.clients.get(&key){
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's keys
[INFO] [stderr]   --> src/socket_server/gamestate.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for (key,_) in &self.clients{
[INFO] [stderr]    |                        ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for key in self.clients.keys(){
[INFO] [stderr]    |             ^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/socket_server/gamestate.rs:23:16
[INFO] [stderr]    |
[INFO] [stderr] 23 |                     Some(c)=>{c.send(message.clone());},
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:15:2
[INFO] [stderr]    |
[INFO] [stderr] 15 |     handle.join();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: method `sendAll` should have a snake case name such as `send_all`
[INFO] [stderr]   --> src/socket_server/gamestate.rs:19:2
[INFO] [stderr]    |
[INFO] [stderr] 19 |       pub fn sendAll(&mut self, message: String,id: u64){
[INFO] [stderr]    |  _____^
[INFO] [stderr] 20 | |         for (key,_) in &self.clients{
[INFO] [stderr] 21 | |             if *key != id{
[INFO] [stderr] 22 | |                 match self.clients.get(&key){
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's keys
[INFO] [stderr]   --> src/socket_server/gamestate.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for (key,_) in &self.clients{
[INFO] [stderr]    |                        ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for key in self.clients.keys(){
[INFO] [stderr]    |             ^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/socket_server/gamestate.rs:23:16
[INFO] [stderr]    |
[INFO] [stderr] 23 |                     Some(c)=>{c.send(message.clone());},
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:15:2
[INFO] [stderr]    |
[INFO] [stderr] 15 |     handle.join();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.64s
[INFO] running `"docker" "inspect" "e3f67bc471b38e63fac1ca4f13cb8168272580518a45177fd84f9faa352210fe"`
[INFO] running `"docker" "rm" "-f" "e3f67bc471b38e63fac1ca4f13cb8168272580518a45177fd84f9faa352210fe"`
[INFO] [stdout] e3f67bc471b38e63fac1ca4f13cb8168272580518a45177fd84f9faa352210fe