[INFO] updating cached repository NougatRillettes/rust-hlbuf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NougatRillettes/rust-hlbuf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NougatRillettes/rust-hlbuf" "work/ex/clippy-test-run/sources/stable/gh/NougatRillettes/rust-hlbuf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NougatRillettes/rust-hlbuf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NougatRillettes/rust-hlbuf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NougatRillettes/rust-hlbuf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NougatRillettes/rust-hlbuf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a8f30c7f80970d3e19730778de180e7b672768c [INFO] sha for GitHub repo NougatRillettes/rust-hlbuf: 6a8f30c7f80970d3e19730778de180e7b672768c [INFO] validating manifest of NougatRillettes/rust-hlbuf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NougatRillettes/rust-hlbuf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NougatRillettes/rust-hlbuf [INFO] finished frobbing NougatRillettes/rust-hlbuf [INFO] frobbed toml for NougatRillettes/rust-hlbuf written to work/ex/clippy-test-run/sources/stable/gh/NougatRillettes/rust-hlbuf/Cargo.toml [INFO] started frobbing NougatRillettes/rust-hlbuf [INFO] finished frobbing NougatRillettes/rust-hlbuf [INFO] frobbed toml for NougatRillettes/rust-hlbuf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NougatRillettes/rust-hlbuf/Cargo.toml [INFO] crate NougatRillettes/rust-hlbuf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NougatRillettes/rust-hlbuf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NougatRillettes/rust-hlbuf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eafef82317d45ad22c749f06244a72d956cb156c55d0626ae383a20ba267636c [INFO] running `"docker" "start" "-a" "eafef82317d45ad22c749f06244a72d956cb156c55d0626ae383a20ba267636c"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `test`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking hlbuf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter_hlbuf.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read_hlbuf.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter_hlbuf.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read_hlbuf.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/read_hlbuf.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | &mut self.buf[0..keep_size].clone_from_slice(tmp_buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.buf[0..keep_size].clone_from_slice(tmp_buf);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/read_hlbuf.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | &mut self.buf[0..keep_size].clone_from_slice(tmp_buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.buf[0..keep_size].clone_from_slice(tmp_buf);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "eafef82317d45ad22c749f06244a72d956cb156c55d0626ae383a20ba267636c"` [INFO] running `"docker" "rm" "-f" "eafef82317d45ad22c749f06244a72d956cb156c55d0626ae383a20ba267636c"` [INFO] [stdout] eafef82317d45ad22c749f06244a72d956cb156c55d0626ae383a20ba267636c