[INFO] updating cached repository NotLeet/rust-file-manipulation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NotLeet/rust-file-manipulation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NotLeet/rust-file-manipulation" "work/ex/clippy-test-run/sources/stable/gh/NotLeet/rust-file-manipulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NotLeet/rust-file-manipulation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NotLeet/rust-file-manipulation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NotLeet/rust-file-manipulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NotLeet/rust-file-manipulation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c75de95ac165463be89515ba8807d99d1159fe37 [INFO] sha for GitHub repo NotLeet/rust-file-manipulation: c75de95ac165463be89515ba8807d99d1159fe37 [INFO] validating manifest of NotLeet/rust-file-manipulation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NotLeet/rust-file-manipulation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NotLeet/rust-file-manipulation [INFO] finished frobbing NotLeet/rust-file-manipulation [INFO] frobbed toml for NotLeet/rust-file-manipulation written to work/ex/clippy-test-run/sources/stable/gh/NotLeet/rust-file-manipulation/Cargo.toml [INFO] started frobbing NotLeet/rust-file-manipulation [INFO] finished frobbing NotLeet/rust-file-manipulation [INFO] frobbed toml for NotLeet/rust-file-manipulation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NotLeet/rust-file-manipulation/Cargo.toml [INFO] crate NotLeet/rust-file-manipulation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NotLeet/rust-file-manipulation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NotLeet/rust-file-manipulation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83b18f310a7431ec6b1f94f6473eed288f28db861eec350f2369cc156498d2c2 [INFO] running `"docker" "start" "-a" "83b18f310a7431ec6b1f94f6473eed288f28db861eec350f2369cc156498d2c2"` [INFO] [stderr] Checking read_file v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return Err(err.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `expr` [INFO] [stderr] --> src/main.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(expr) => { [INFO] [stderr] | ^^^^ help: consider using `_expr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | Err(err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file_path` [INFO] [stderr] --> src/main.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_file_number(file_path: &PathBuf) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_file_path` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_file_number` [INFO] [stderr] --> src/main.rs:81:1 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_file_number(file_path: &PathBuf) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | let ref arg_ref = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^----------- help: try: `let arg_ref = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:47:78 [INFO] [stderr] | [INFO] [stderr] 47 | else if path.file_name().unwrap() == "read_file.exe" { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 48 | | continue [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | if extension_str == "txt" { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 45 | | continue [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `read_file`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return Err(err.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `expr` [INFO] [stderr] --> src/main.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(expr) => { [INFO] [stderr] | ^^^^ help: consider using `_expr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | Err(err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file_path` [INFO] [stderr] --> src/main.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_file_number(file_path: &PathBuf) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_file_path` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_file_number` [INFO] [stderr] --> src/main.rs:81:1 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_file_number(file_path: &PathBuf) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | let ref arg_ref = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^----------- help: try: `let arg_ref = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:47:78 [INFO] [stderr] | [INFO] [stderr] 47 | else if path.file_name().unwrap() == "read_file.exe" { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 48 | | continue [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | if extension_str == "txt" { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 45 | | continue [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `read_file`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "83b18f310a7431ec6b1f94f6473eed288f28db861eec350f2369cc156498d2c2"` [INFO] running `"docker" "rm" "-f" "83b18f310a7431ec6b1f94f6473eed288f28db861eec350f2369cc156498d2c2"` [INFO] [stdout] 83b18f310a7431ec6b1f94f6473eed288f28db861eec350f2369cc156498d2c2