[INFO] updating cached repository NotIntMan/LessSignificantBit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NotIntMan/LessSignificantBit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NotIntMan/LessSignificantBit" "work/ex/clippy-test-run/sources/stable/gh/NotIntMan/LessSignificantBit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NotIntMan/LessSignificantBit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NotIntMan/LessSignificantBit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NotIntMan/LessSignificantBit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NotIntMan/LessSignificantBit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 609b67c402f9fb0cabe563b0b783f993412e5034 [INFO] sha for GitHub repo NotIntMan/LessSignificantBit: 609b67c402f9fb0cabe563b0b783f993412e5034 [INFO] validating manifest of NotIntMan/LessSignificantBit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NotIntMan/LessSignificantBit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NotIntMan/LessSignificantBit [INFO] finished frobbing NotIntMan/LessSignificantBit [INFO] frobbed toml for NotIntMan/LessSignificantBit written to work/ex/clippy-test-run/sources/stable/gh/NotIntMan/LessSignificantBit/Cargo.toml [INFO] started frobbing NotIntMan/LessSignificantBit [INFO] finished frobbing NotIntMan/LessSignificantBit [INFO] frobbed toml for NotIntMan/LessSignificantBit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NotIntMan/LessSignificantBit/Cargo.toml [INFO] crate NotIntMan/LessSignificantBit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NotIntMan/LessSignificantBit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NotIntMan/LessSignificantBit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1011d5a910a27fd54604b8ee3108ca69dd54df70dcc2d28650481110460f91a5 [INFO] running `"docker" "start" "-a" "1011d5a910a27fd54604b8ee3108ca69dd54df70dcc2d28650481110460f91a5"` [INFO] [stderr] Checking either v1.2.0 [INFO] [stderr] Checking threadpool v1.7.0 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.16.0 [INFO] [stderr] Checking lab1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stgr.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stgr.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stgr.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stgr.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stgr.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stgr.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stgr.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | return (num & (1 << bit)) > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(num & (1 << bit)) > 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stgr.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stgr.rs:162:4 [INFO] [stderr] | [INFO] [stderr] 162 | return TripleIterator::new([ [INFO] [stderr] | _____________^ [INFO] [stderr] 163 | | (pixel.data[0] & 1) == 1, [INFO] [stderr] 164 | | (pixel.data[1] & 1) == 1, [INFO] [stderr] 165 | | (pixel.data[2] & 1) == 1, [INFO] [stderr] 166 | | ]); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 162 | TripleIterator::new([ [INFO] [stderr] 163 | (pixel.data[0] & 1) == 1, [INFO] [stderr] 164 | (pixel.data[1] & 1) == 1, [INFO] [stderr] 165 | (pixel.data[2] & 1) == 1, [INFO] [stderr] 166 | ]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/stgr.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 180 | | if has(num, bit) { [INFO] [stderr] 181 | | num - pow [INFO] [stderr] 182 | | } else { [INFO] [stderr] 183 | | num [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | } else if has(num, bit) { [INFO] [stderr] 180 | num - pow [INFO] [stderr] 181 | } else { [INFO] [stderr] 182 | num [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return arguments.next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `arguments.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stgr.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | fn format_pixel(pixel: &Rgba, x: u32, y: u32) -> String { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Rgba` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stgr.rs:191:16 [INFO] [stderr] | [INFO] [stderr] 191 | let mut vec = Vec::from(msg.into_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `msg.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | if trim.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trim.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let _ = img.save(&mut fout, image::BMP).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stgr.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | return (num & (1 << bit)) > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(num & (1 << bit)) > 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stgr.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stgr.rs:162:4 [INFO] [stderr] | [INFO] [stderr] 162 | return TripleIterator::new([ [INFO] [stderr] | _____________^ [INFO] [stderr] 163 | | (pixel.data[0] & 1) == 1, [INFO] [stderr] 164 | | (pixel.data[1] & 1) == 1, [INFO] [stderr] 165 | | (pixel.data[2] & 1) == 1, [INFO] [stderr] 166 | | ]); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 162 | TripleIterator::new([ [INFO] [stderr] 163 | (pixel.data[0] & 1) == 1, [INFO] [stderr] 164 | (pixel.data[1] & 1) == 1, [INFO] [stderr] 165 | (pixel.data[2] & 1) == 1, [INFO] [stderr] 166 | ]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/stgr.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 180 | | if has(num, bit) { [INFO] [stderr] 181 | | num - pow [INFO] [stderr] 182 | | } else { [INFO] [stderr] 183 | | num [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | } else if has(num, bit) { [INFO] [stderr] 180 | num - pow [INFO] [stderr] 181 | } else { [INFO] [stderr] 182 | num [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return arguments.next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `arguments.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stgr.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | fn format_pixel(pixel: &Rgba, x: u32, y: u32) -> String { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Rgba` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stgr.rs:191:16 [INFO] [stderr] | [INFO] [stderr] 191 | let mut vec = Vec::from(msg.into_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `msg.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/stgr.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | let mut iter = input.iter().map(|v| *v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `input.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/stgr.rs:253:21 [INFO] [stderr] | [INFO] [stderr] 253 | let mut it = input.into_iter().map(|a| *a == 1); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | if trim.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trim.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let _ = img.save(&mut fout, image::BMP).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lab1`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1011d5a910a27fd54604b8ee3108ca69dd54df70dcc2d28650481110460f91a5"` [INFO] running `"docker" "rm" "-f" "1011d5a910a27fd54604b8ee3108ca69dd54df70dcc2d28650481110460f91a5"` [INFO] [stdout] 1011d5a910a27fd54604b8ee3108ca69dd54df70dcc2d28650481110460f91a5