[INFO] updating cached repository NogikuchiKBYS/SaBiPT [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NogikuchiKBYS/SaBiPT [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NogikuchiKBYS/SaBiPT" "work/ex/clippy-test-run/sources/stable/gh/NogikuchiKBYS/SaBiPT"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NogikuchiKBYS/SaBiPT'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NogikuchiKBYS/SaBiPT" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NogikuchiKBYS/SaBiPT"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NogikuchiKBYS/SaBiPT'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] feb586eb47b52ac81b2e421e7253a7d44f66e69d [INFO] sha for GitHub repo NogikuchiKBYS/SaBiPT: feb586eb47b52ac81b2e421e7253a7d44f66e69d [INFO] validating manifest of NogikuchiKBYS/SaBiPT on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NogikuchiKBYS/SaBiPT on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NogikuchiKBYS/SaBiPT [INFO] finished frobbing NogikuchiKBYS/SaBiPT [INFO] frobbed toml for NogikuchiKBYS/SaBiPT written to work/ex/clippy-test-run/sources/stable/gh/NogikuchiKBYS/SaBiPT/Cargo.toml [INFO] started frobbing NogikuchiKBYS/SaBiPT [INFO] finished frobbing NogikuchiKBYS/SaBiPT [INFO] frobbed toml for NogikuchiKBYS/SaBiPT written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NogikuchiKBYS/SaBiPT/Cargo.toml [INFO] crate NogikuchiKBYS/SaBiPT has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NogikuchiKBYS/SaBiPT against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NogikuchiKBYS/SaBiPT:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d52d3f8769322d529d6a4cecac0dcfab0c805ef61fbc49489e756fa78ebc2880 [INFO] running `"docker" "start" "-a" "d52d3f8769322d529d6a4cecac0dcfab0c805ef61fbc49489e756fa78ebc2880"` [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking sabipt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/hobounds.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/hobounds.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | next: next, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/hobounds.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum/rgb.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | RGB { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum/rgb.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | RGB { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum/rgb.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | RGB { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/scene.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | let mut r = p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | emissive: emissive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emissive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | geom: geom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `geom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | SampleResult { v: s.v, pdf: pdf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | pdf: pdf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | gnorm: gnorm, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gnorm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | gnorm: gnorm, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gnorm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/shape.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | let c = [c0, c1, c2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | snorm: snorm, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `snorm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:205:17 [INFO] [stderr] | [INFO] [stderr] 205 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | Ray { o: o, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | Ray { o: o, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | o: o, [INFO] [stderr] | ^^^^ help: replace it with: `o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | Self { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | Self { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | v : v, [INFO] [stderr] | ^^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/hobounds.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/hobounds.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | next: next, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/hobounds.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum/rgb.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | RGB { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum/rgb.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | RGB { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum/rgb.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | RGB { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/scene.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | let mut r = p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | emissive: emissive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emissive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | geom: geom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `geom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | SampleResult { v: s.v, pdf: pdf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | pdf: pdf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | gnorm: gnorm, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gnorm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | gnorm: gnorm, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gnorm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/shape.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | let c = [c0, c1, c2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | snorm: snorm, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `snorm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:205:17 [INFO] [stderr] | [INFO] [stderr] 205 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | Ray { o: o, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | Ray { o: o, d: d } [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | o: o, [INFO] [stderr] | ^^^^ help: replace it with: `o` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | Self { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | Self { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | v : v, [INFO] [stderr] | ^^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/geometry.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | area_pdf [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/geometry.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | let area_pdf = pdf * self.gnorm.dot(&u).abs() / (r * r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return l; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | return self.put_vertices(rng, scene, vec![first_vertex]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.put_vertices(rng, scene, vec![first_vertex])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return vs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `vs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | return l; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/geometry.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | area_pdf [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/geometry.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | let area_pdf = pdf * self.gnorm.dot(&u).abs() / (r * r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return l; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | return self.put_vertices(rng, scene, vec![first_vertex]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.put_vertices(rng, scene, vec![first_vertex])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return vs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `vs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | return l; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pos` [INFO] [stderr] --> src/util/hobounds.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..D::dim() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for (i, ) in pos.iter().enumerate().take(D::dim()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `end`. [INFO] [stderr] --> src/util/hobounds.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..D::dim() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in end.iter_mut().take(D::dim()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/spectrum/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | const ZERO: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/spectrum/mod.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | const ZERO: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/spectrum/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | const ONE: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/spectrum/mod.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | const ONE: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | file.write(slice_u8).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::SceneBuilder` [INFO] [stderr] --> src/scene.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> SceneBuilder { [INFO] [stderr] 42 | | SceneBuilder { [INFO] [stderr] 43 | | objects: vec![], [INFO] [stderr] 44 | | materials: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | impl Default for scene::SceneBuilder { [INFO] [stderr] 41 | fn default() -> Self { [INFO] [stderr] 42 | Self::new() [INFO] [stderr] 43 | } [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/scene.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | let mat = self.materials.get(&mat).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.materials[&mat]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/scene.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | let mat = self.materials.get(&mat).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.materials[&mat]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/scene.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | !self.hit(&ray, 1e-3, distance - 1e-3).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.hit(&ray, 1e-3, distance - 1e-3).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/scene.rs:180:37 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn sample_light(&self, rng: &mut Box) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/scene.rs:184:39 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn sample_surface(&self, rng: &mut Box) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/material/mod.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | fn sample_in(&self, rng: &mut Box, local_out: &Norm3f) -> SampleResult<(S, BSDFInfo, Norm3f)>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material/mod.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | let mut dir = dir_sample.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dir_sample.v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material/mod.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | let mut dir = dir_sample.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dir_sample.v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/object.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | fn sample_surface(&self, rng: &mut Box) -> Option>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geometry.rs:95:39 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn bsdf_sample_in(&self, rng: &mut Box, wo: &Norm3f) -> SampleResult<(RGB, BSDFInfo, Norm3f)> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/shape.rs:15:35 [INFO] [stderr] | [INFO] [stderr] 15 | fn sample_surface(&self, rng: &mut Box) -> SampleResult; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/shape.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for (i, ) in c.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/shape.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for (i, ) in c.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/shape.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | bb.max = bb.max + Vec3f::new(1.0, 1.0, 1.0) * 1e-3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bb.max += Vec3f::new(1.0, 1.0, 1.0) * 1e-3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/shape.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | bb.min = bb.min - Vec3f::new(1.0, 1.0, 1.0) * 1e-3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bb.min -= Vec3f::new(1.0, 1.0, 1.0) * 1e-3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sampler.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | fn sample(&self, rng: &mut Box) -> SampleResult; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `v` [INFO] [stderr] --> src/sampler.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | for i in 0 .. D::dim() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for (i, ) in v.iter_mut().enumerate().take(D::dim()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bvh.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | for ref obj in subtree_objects.iter() { [INFO] [stderr] | ^^^^^^^ ---------------------- help: try: `let obj = &subtree_objects.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bvh::BVH` [INFO] [stderr] --> src/bvh.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / pub fn new() -> Self { [INFO] [stderr] 161 | | BVH { root: None } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | fn render_pixel(&self, rng: &mut Box, camera: &Camera, scene: &Arc, ix: na::Point2) -> RGB; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/render.rs:122:16 [INFO] [stderr] | [INFO] [stderr] 122 | if !hit.material.bsdf.only_specular() && !(bounce == self.max_bounce) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!hit.material.bsdf.only_specular() && bounce != self.max_bounce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | 'trace_loop: for bounce in 0..self.max_bounce + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.max_bounce` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:181:43 [INFO] [stderr] | [INFO] [stderr] 181 | fn put_light_vertices<'a>(&self, rng: &mut Box, scene: &'a Arc) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:204:91 [INFO] [stderr] | [INFO] [stderr] 204 | let flux = light_point.v.material.emission.unwrap_or(RGB::ZERO) * gterm / (trial_count as Float) / [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trial_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:221:14 [INFO] [stderr] | [INFO] [stderr] 221 | rng: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:241:14 [INFO] [stderr] | [INFO] [stderr] 241 | rng: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/render.rs:299:12 [INFO] [stderr] | [INFO] [stderr] 299 | if self.max_length <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.max_length == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render.rs:303:29 [INFO] [stderr] | [INFO] [stderr] 303 | let max_length = if camera_path.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!camera_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render.rs:312:23 [INFO] [stderr] | [INFO] [stderr] 312 | for length in 2..max_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `2..=max_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `camera_index` is used to index `camera_path` [INFO] [stderr] --> src/render.rs:315:33 [INFO] [stderr] | [INFO] [stderr] 315 | for camera_index in 0..camera_path.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 315 | for (camera_index, ) in camera_path.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sabipt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is used to index `pos` [INFO] [stderr] --> src/util/hobounds.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..D::dim() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for (i, ) in pos.iter().enumerate().take(D::dim()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `end`. [INFO] [stderr] --> src/util/hobounds.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..D::dim() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in end.iter_mut().take(D::dim()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/spectrum/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | const ZERO: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/spectrum/mod.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | const ZERO: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/spectrum/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | const ONE: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/spectrum/mod.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | const ONE: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | file.write(slice_u8).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::SceneBuilder` [INFO] [stderr] --> src/scene.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> SceneBuilder { [INFO] [stderr] 42 | | SceneBuilder { [INFO] [stderr] 43 | | objects: vec![], [INFO] [stderr] 44 | | materials: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | impl Default for scene::SceneBuilder { [INFO] [stderr] 41 | fn default() -> Self { [INFO] [stderr] 42 | Self::new() [INFO] [stderr] 43 | } [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/scene.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | let mat = self.materials.get(&mat).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.materials[&mat]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/scene.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | let mat = self.materials.get(&mat).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.materials[&mat]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/scene.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | !self.hit(&ray, 1e-3, distance - 1e-3).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.hit(&ray, 1e-3, distance - 1e-3).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/scene.rs:180:37 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn sample_light(&self, rng: &mut Box) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/scene.rs:184:39 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn sample_surface(&self, rng: &mut Box) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/material/mod.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | fn sample_in(&self, rng: &mut Box, local_out: &Norm3f) -> SampleResult<(S, BSDFInfo, Norm3f)>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material/mod.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | let mut dir = dir_sample.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dir_sample.v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material/mod.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | let mut dir = dir_sample.v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dir_sample.v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/object.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | fn sample_surface(&self, rng: &mut Box) -> Option>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geometry.rs:95:39 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn bsdf_sample_in(&self, rng: &mut Box, wo: &Norm3f) -> SampleResult<(RGB, BSDFInfo, Norm3f)> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/shape.rs:15:35 [INFO] [stderr] | [INFO] [stderr] 15 | fn sample_surface(&self, rng: &mut Box) -> SampleResult; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/shape.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for (i, ) in c.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/shape.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for (i, ) in c.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/shape.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | bb.max = bb.max + Vec3f::new(1.0, 1.0, 1.0) * 1e-3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bb.max += Vec3f::new(1.0, 1.0, 1.0) * 1e-3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/shape.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | bb.min = bb.min - Vec3f::new(1.0, 1.0, 1.0) * 1e-3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bb.min -= Vec3f::new(1.0, 1.0, 1.0) * 1e-3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sampler.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | fn sample(&self, rng: &mut Box) -> SampleResult; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `v` [INFO] [stderr] --> src/sampler.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | for i in 0 .. D::dim() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for (i, ) in v.iter_mut().enumerate().take(D::dim()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bvh.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | for ref obj in subtree_objects.iter() { [INFO] [stderr] | ^^^^^^^ ---------------------- help: try: `let obj = &subtree_objects.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bvh::BVH` [INFO] [stderr] --> src/bvh.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / pub fn new() -> Self { [INFO] [stderr] 161 | | BVH { root: None } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | fn render_pixel(&self, rng: &mut Box, camera: &Camera, scene: &Arc, ix: na::Point2) -> RGB; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/render.rs:122:16 [INFO] [stderr] | [INFO] [stderr] 122 | if !hit.material.bsdf.only_specular() && !(bounce == self.max_bounce) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!hit.material.bsdf.only_specular() && bounce != self.max_bounce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | 'trace_loop: for bounce in 0..self.max_bounce + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.max_bounce` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:181:43 [INFO] [stderr] | [INFO] [stderr] 181 | fn put_light_vertices<'a>(&self, rng: &mut Box, scene: &'a Arc) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:204:91 [INFO] [stderr] | [INFO] [stderr] 204 | let flux = light_point.v.material.emission.unwrap_or(RGB::ZERO) * gterm / (trial_count as Float) / [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(trial_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:221:14 [INFO] [stderr] | [INFO] [stderr] 221 | rng: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/render.rs:241:14 [INFO] [stderr] | [INFO] [stderr] 241 | rng: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&mut Rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/render.rs:299:12 [INFO] [stderr] | [INFO] [stderr] 299 | if self.max_length <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.max_length == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render.rs:303:29 [INFO] [stderr] | [INFO] [stderr] 303 | let max_length = if camera_path.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!camera_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render.rs:312:23 [INFO] [stderr] | [INFO] [stderr] 312 | for length in 2..max_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `2..=max_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `camera_index` is used to index `camera_path` [INFO] [stderr] --> src/render.rs:315:33 [INFO] [stderr] | [INFO] [stderr] 315 | for camera_index in 0..camera_path.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 315 | for (camera_index, ) in camera_path.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sabipt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d52d3f8769322d529d6a4cecac0dcfab0c805ef61fbc49489e756fa78ebc2880"` [INFO] running `"docker" "rm" "-f" "d52d3f8769322d529d6a4cecac0dcfab0c805ef61fbc49489e756fa78ebc2880"` [INFO] [stdout] d52d3f8769322d529d6a4cecac0dcfab0c805ef61fbc49489e756fa78ebc2880