[INFO] updating cached repository Nobuyuki-Tokuchi/cent_rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Nobuyuki-Tokuchi/cent_rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Nobuyuki-Tokuchi/cent_rust" "work/ex/clippy-test-run/sources/stable/gh/Nobuyuki-Tokuchi/cent_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nobuyuki-Tokuchi/cent_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Nobuyuki-Tokuchi/cent_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nobuyuki-Tokuchi/cent_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nobuyuki-Tokuchi/cent_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 45872c159b0064bda839464ee4f63fd66b839767
[INFO] sha for GitHub repo Nobuyuki-Tokuchi/cent_rust: 45872c159b0064bda839464ee4f63fd66b839767
[INFO] validating manifest of Nobuyuki-Tokuchi/cent_rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Nobuyuki-Tokuchi/cent_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Nobuyuki-Tokuchi/cent_rust
[INFO] finished frobbing Nobuyuki-Tokuchi/cent_rust
[INFO] frobbed toml for Nobuyuki-Tokuchi/cent_rust written to work/ex/clippy-test-run/sources/stable/gh/Nobuyuki-Tokuchi/cent_rust/Cargo.toml
[INFO] started frobbing Nobuyuki-Tokuchi/cent_rust
[INFO] finished frobbing Nobuyuki-Tokuchi/cent_rust
[INFO] frobbed toml for Nobuyuki-Tokuchi/cent_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nobuyuki-Tokuchi/cent_rust/Cargo.toml
[INFO] crate Nobuyuki-Tokuchi/cent_rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Nobuyuki-Tokuchi/cent_rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Nobuyuki-Tokuchi/cent_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8634bef4f5377dab0d646de9eeafcc781407f4aea5811ff4c4c06b3287fe0f97
[INFO] running `"docker" "start" "-a" "8634bef4f5377dab0d646de9eeafcc781407f4aea5811ff4c4c06b3287fe0f97"`
[INFO] [stderr]     Checking cent v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/sh2003lk.rs:15:54
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn compile(code: &cent::CentCode, out_file_name: &String) -> Result<(), String> {
[INFO] [stderr]    |                                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/cent/sh2003lk.rs:33:29
[INFO] [stderr]    |
[INFO] [stderr] 33 |             let func_name = subroutine.get(1).unwrap();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subroutine[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/cent/sh2003lk.rs:34:25
[INFO] [stderr]    |
[INFO] [stderr] 34 |             let count = subroutine.get(2).unwrap();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subroutine[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/cent/sh2003lk.rs:42:57
[INFO] [stderr]    |
[INFO] [stderr] 42 |             subr_table.insert(subr_name, Vec::from_iter(subroutine.iter().skip(1).map(|x| x.clone())));
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `subroutine.iter().skip(1).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cent/sh2003lk.rs:64:57
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn write_operation(state: &mut OutputState, operations: &Vec<String>, subr_table: &HashMap<&String, Vec<String>>) -> Result<(), String> {
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cent/sh2003lk.rs:100:29
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 let count = state.xok_label.get(func_name).unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.xok_label[func_name]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/cent/sh2003lk.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 | /                 match &subr_table.get(subr_name) {
[INFO] [stderr] 116 | |                     &Some(data) => try!(write_operation(&mut *state, &data, &subr_table).map_err(|err| err.to_string())),
[INFO] [stderr] 117 | |                     &None => return Err(format!("Not found subroutine name: {}", subr_name)),
[INFO] [stderr] 118 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 115 |                 match subr_table.get(subr_name) {
[INFO] [stderr] 116 |                     Some(data) => try!(write_operation(&mut *state, &data, &subr_table).map_err(|err| err.to_string())),
[INFO] [stderr] 117 |                     None => return Err(format!("Not found subroutine name: {}", subr_name)),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/sh2003lk.rs:135:34
[INFO] [stderr]     |
[INFO] [stderr] 135 | fn to_cent_operation (operation: &String) -> Result<String, String> {
[INFO] [stderr]     |                                  ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 135 | fn to_cent_operation (operation: &str) -> Result<String, String> {
[INFO] [stderr]     |                                  ^^^^
[INFO] [stderr] help: change `operation.as_str()` to
[INFO] [stderr]     |
[INFO] [stderr] 136 |     match operation {
[INFO] [stderr]     |           ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/sh2003lk.rs:162:62
[INFO] [stderr]     |
[INFO] [stderr] 162 | fn to_control_operation (state: &mut OutputState, operation: &String) -> Result<String, String> {
[INFO] [stderr]     |                                                              ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 162 | fn to_control_operation (state: &mut OutputState, operation: &str) -> Result<String, String> {
[INFO] [stderr]     |                                                              ^^^^
[INFO] [stderr] help: change `operation.as_str()` to
[INFO] [stderr]     |
[INFO] [stderr] 163 |     match operation {
[INFO] [stderr]     |           ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cent/sh2003lk.rs:205:27
[INFO] [stderr]     |
[INFO] [stderr] 205 |                 let snd = state.label_stack.get(state.label_stack.len() - 1).unwrap();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `state.label_stack[state.label_stack.len() - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/sh2003lk.rs:252:62
[INFO] [stderr]     |
[INFO] [stderr] 252 | fn to_compare_operation (state: &mut OutputState, operation: &String) -> Result<String, String> {
[INFO] [stderr]     |                                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:35:25
[INFO] [stderr]    |
[INFO] [stderr] 35 | pub fn is_keyword(word: &String) -> bool {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:39:29
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub fn is_lk_operator(word: &String) -> bool {
[INFO] [stderr]    |                             ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub fn is_lk_operator(word: &str) -> bool {
[INFO] [stderr]    |                             ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:44:31
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn is_cent_operator(word: &String) -> bool {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn is_cent_operator(word: &str) -> bool {
[INFO] [stderr]    |                               ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:49:34
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn is_control_operator(word: &String) -> bool {
[INFO] [stderr]    |                                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn is_control_operator(word: &str) -> bool {
[INFO] [stderr]    |                                  ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:54:34
[INFO] [stderr]    |
[INFO] [stderr] 54 | pub fn is_compare_operator(word: &String) -> bool {
[INFO] [stderr]    |                                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 54 | pub fn is_compare_operator(word: &str) -> bool {
[INFO] [stderr]    |                                  ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cent/mod.rs:64:38
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn split_word<'a>(in_file_names: &Vec<String>) -> Result<CentCode, String> {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/cent/mod.rs:64:19
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn split_word<'a>(in_file_names: &Vec<String>) -> Result<CentCode, String> {
[INFO] [stderr]    |                   ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:82:43
[INFO] [stderr]    |
[INFO] [stderr] 82 |     fn read_file(&mut self, in_file_name: &String) -> Result<(), String> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/cent/mod.rs:164:90
[INFO] [stderr]     |
[INFO] [stderr] 164 |     fn append_last(&mut self, buffer: &mut String, subr_list: &mut Vec<String>, is_subr: &bool) {
[INFO] [stderr]     |                                                                                          ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cent/mod.rs:165:12
[INFO] [stderr]     |
[INFO] [stderr] 165 |         if buffer.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/cent/mod.rs:223:21
[INFO] [stderr]     |
[INFO] [stderr] 223 | fn check_code(code: &Vec<String>) -> Result<(), String> {
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/mod.rs:264:32
[INFO] [stderr]     |
[INFO] [stderr] 264 | fn check_subroutine_name(name: &String) -> bool {
[INFO] [stderr]     |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/sh2003lk.rs:15:54
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn compile(code: &cent::CentCode, out_file_name: &String) -> Result<(), String> {
[INFO] [stderr]    |                                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/cent/sh2003lk.rs:33:29
[INFO] [stderr]    |
[INFO] [stderr] 33 |             let func_name = subroutine.get(1).unwrap();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subroutine[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/cent/sh2003lk.rs:34:25
[INFO] [stderr]    |
[INFO] [stderr] 34 |             let count = subroutine.get(2).unwrap();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subroutine[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/cent/sh2003lk.rs:42:57
[INFO] [stderr]    |
[INFO] [stderr] 42 |             subr_table.insert(subr_name, Vec::from_iter(subroutine.iter().skip(1).map(|x| x.clone())));
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `subroutine.iter().skip(1).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cent/sh2003lk.rs:64:57
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn write_operation(state: &mut OutputState, operations: &Vec<String>, subr_table: &HashMap<&String, Vec<String>>) -> Result<(), String> {
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cent/sh2003lk.rs:100:29
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 let count = state.xok_label.get(func_name).unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.xok_label[func_name]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/cent/sh2003lk.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 | /                 match &subr_table.get(subr_name) {
[INFO] [stderr] 116 | |                     &Some(data) => try!(write_operation(&mut *state, &data, &subr_table).map_err(|err| err.to_string())),
[INFO] [stderr] 117 | |                     &None => return Err(format!("Not found subroutine name: {}", subr_name)),
[INFO] [stderr] 118 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 115 |                 match subr_table.get(subr_name) {
[INFO] [stderr] 116 |                     Some(data) => try!(write_operation(&mut *state, &data, &subr_table).map_err(|err| err.to_string())),
[INFO] [stderr] 117 |                     None => return Err(format!("Not found subroutine name: {}", subr_name)),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/sh2003lk.rs:135:34
[INFO] [stderr]     |
[INFO] [stderr] 135 | fn to_cent_operation (operation: &String) -> Result<String, String> {
[INFO] [stderr]     |                                  ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 135 | fn to_cent_operation (operation: &str) -> Result<String, String> {
[INFO] [stderr]     |                                  ^^^^
[INFO] [stderr] help: change `operation.as_str()` to
[INFO] [stderr]     |
[INFO] [stderr] 136 |     match operation {
[INFO] [stderr]     |           ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/sh2003lk.rs:162:62
[INFO] [stderr]     |
[INFO] [stderr] 162 | fn to_control_operation (state: &mut OutputState, operation: &String) -> Result<String, String> {
[INFO] [stderr]     |                                                              ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 162 | fn to_control_operation (state: &mut OutputState, operation: &str) -> Result<String, String> {
[INFO] [stderr]     |                                                              ^^^^
[INFO] [stderr] help: change `operation.as_str()` to
[INFO] [stderr]     |
[INFO] [stderr] 163 |     match operation {
[INFO] [stderr]     |           ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cent/sh2003lk.rs:205:27
[INFO] [stderr]     |
[INFO] [stderr] 205 |                 let snd = state.label_stack.get(state.label_stack.len() - 1).unwrap();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `state.label_stack[state.label_stack.len() - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/sh2003lk.rs:252:62
[INFO] [stderr]     |
[INFO] [stderr] 252 | fn to_compare_operation (state: &mut OutputState, operation: &String) -> Result<String, String> {
[INFO] [stderr]     |                                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:35:25
[INFO] [stderr]    |
[INFO] [stderr] 35 | pub fn is_keyword(word: &String) -> bool {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:39:29
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub fn is_lk_operator(word: &String) -> bool {
[INFO] [stderr]    |                             ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub fn is_lk_operator(word: &str) -> bool {
[INFO] [stderr]    |                             ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:44:31
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn is_cent_operator(word: &String) -> bool {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn is_cent_operator(word: &str) -> bool {
[INFO] [stderr]    |                               ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:49:34
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn is_control_operator(word: &String) -> bool {
[INFO] [stderr]    |                                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn is_control_operator(word: &str) -> bool {
[INFO] [stderr]    |                                  ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:54:34
[INFO] [stderr]    |
[INFO] [stderr] 54 | pub fn is_compare_operator(word: &String) -> bool {
[INFO] [stderr]    |                                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 54 | pub fn is_compare_operator(word: &str) -> bool {
[INFO] [stderr]    |                                  ^^^^
[INFO] [stderr] help: change `word.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let data = &word;
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cent/mod.rs:64:38
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn split_word<'a>(in_file_names: &Vec<String>) -> Result<CentCode, String> {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/cent/mod.rs:64:19
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn split_word<'a>(in_file_names: &Vec<String>) -> Result<CentCode, String> {
[INFO] [stderr]    |                   ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cent/mod.rs:82:43
[INFO] [stderr]    |
[INFO] [stderr] 82 |     fn read_file(&mut self, in_file_name: &String) -> Result<(), String> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/cent/mod.rs:164:90
[INFO] [stderr]     |
[INFO] [stderr] 164 |     fn append_last(&mut self, buffer: &mut String, subr_list: &mut Vec<String>, is_subr: &bool) {
[INFO] [stderr]     |                                                                                          ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cent/mod.rs:165:12
[INFO] [stderr]     |
[INFO] [stderr] 165 |         if buffer.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/cent/mod.rs:223:21
[INFO] [stderr]     |
[INFO] [stderr] 223 | fn check_code(code: &Vec<String>) -> Result<(), String> {
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cent/mod.rs:264:32
[INFO] [stderr]     |
[INFO] [stderr] 264 | fn check_subroutine_name(name: &String) -> bool {
[INFO] [stderr]     |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "8634bef4f5377dab0d646de9eeafcc781407f4aea5811ff4c4c06b3287fe0f97"`
[INFO] running `"docker" "rm" "-f" "8634bef4f5377dab0d646de9eeafcc781407f4aea5811ff4c4c06b3287fe0f97"`
[INFO] [stdout] 8634bef4f5377dab0d646de9eeafcc781407f4aea5811ff4c4c06b3287fe0f97