[INFO] updating cached repository NoahTheDuke/rust_ackermann [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NoahTheDuke/rust_ackermann [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NoahTheDuke/rust_ackermann" "work/ex/clippy-test-run/sources/stable/gh/NoahTheDuke/rust_ackermann"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NoahTheDuke/rust_ackermann'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NoahTheDuke/rust_ackermann" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NoahTheDuke/rust_ackermann"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NoahTheDuke/rust_ackermann'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5253f63b823de6ed03cb5f63bf028e1dd3cc3424 [INFO] sha for GitHub repo NoahTheDuke/rust_ackermann: 5253f63b823de6ed03cb5f63bf028e1dd3cc3424 [INFO] validating manifest of NoahTheDuke/rust_ackermann on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NoahTheDuke/rust_ackermann on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NoahTheDuke/rust_ackermann [INFO] finished frobbing NoahTheDuke/rust_ackermann [INFO] frobbed toml for NoahTheDuke/rust_ackermann written to work/ex/clippy-test-run/sources/stable/gh/NoahTheDuke/rust_ackermann/Cargo.toml [INFO] started frobbing NoahTheDuke/rust_ackermann [INFO] finished frobbing NoahTheDuke/rust_ackermann [INFO] frobbed toml for NoahTheDuke/rust_ackermann written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NoahTheDuke/rust_ackermann/Cargo.toml [INFO] crate NoahTheDuke/rust_ackermann has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NoahTheDuke/rust_ackermann against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NoahTheDuke/rust_ackermann:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c16c6ff5cf8dc53f2211147f1dde31eb6572d4df1cf72448cffd05edbf22f89 [INFO] running `"docker" "start" "-a" "5c16c6ff5cf8dc53f2211147f1dde31eb6572d4df1cf72448cffd05edbf22f89"` [INFO] [stderr] Checking ackermann v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / if cache.contains_key(&(m, n)) { [INFO] [stderr] 61 | | *cache.get(&(m, n)).unwrap() [INFO] [stderr] 62 | | } else { [INFO] [stderr] 63 | | let s = _ack_with_cache(cache, m, n - 2); [INFO] [stderr] ... | [INFO] [stderr] 68 | | res [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ help: consider using: `cache.entry((m, n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:66:27 [INFO] [stderr] | [INFO] [stderr] 66 | let res = (s..(t + 1)).fold(0, |acc, x| _ack_comparator(cache, m, acc, x)); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(s..=t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | for n_builder in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / if cache.contains_key(&(m, n)) { [INFO] [stderr] 61 | | *cache.get(&(m, n)).unwrap() [INFO] [stderr] 62 | | } else { [INFO] [stderr] 63 | | let s = _ack_with_cache(cache, m, n - 2); [INFO] [stderr] ... | [INFO] [stderr] 68 | | res [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ help: consider using: `cache.entry((m, n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:66:27 [INFO] [stderr] | [INFO] [stderr] 66 | let res = (s..(t + 1)).fold(0, |acc, x| _ack_comparator(cache, m, acc, x)); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(s..=t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | for n_builder in 2..(cache_result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `2..=cache_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | for n_builder in (current_cache.previous_result + 1)..(current_cache.result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((current_cache.previous_result + 1)..=current_cache.result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | for j in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:153:18 [INFO] [stderr] | [INFO] [stderr] 153 | for k in 2..(v11 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `2..=v11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | for k in (r_use[1] + 1)..(v11 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((r_use[1] + 1)..=v11)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | for n_builder in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | for n_builder in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | for n_builder in 2..(cache_result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `2..=cache_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | for n_builder in (current_cache.previous_result + 1)..(current_cache.result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((current_cache.previous_result + 1)..=current_cache.result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | for j in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:198:26 [INFO] [stderr] | [INFO] [stderr] 198 | for n_builder in 2..(previous_result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `2..=previous_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:205:26 [INFO] [stderr] | [INFO] [stderr] 205 | for n_builder in (cache[1] + 1)..(previous_result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((cache[1] + 1)..=previous_result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:153:18 [INFO] [stderr] | [INFO] [stderr] 153 | for k in 2..(v11 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `2..=v11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | for k in (r_use[1] + 1)..(v11 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((r_use[1] + 1)..=v11)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | for n_builder in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:198:26 [INFO] [stderr] | [INFO] [stderr] 198 | for n_builder in 2..(previous_result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `2..=previous_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:205:26 [INFO] [stderr] | [INFO] [stderr] 205 | for n_builder in (cache[1] + 1)..(previous_result + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((cache[1] + 1)..=previous_result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.30s [INFO] running `"docker" "inspect" "5c16c6ff5cf8dc53f2211147f1dde31eb6572d4df1cf72448cffd05edbf22f89"` [INFO] running `"docker" "rm" "-f" "5c16c6ff5cf8dc53f2211147f1dde31eb6572d4df1cf72448cffd05edbf22f89"` [INFO] [stdout] 5c16c6ff5cf8dc53f2211147f1dde31eb6572d4df1cf72448cffd05edbf22f89