[INFO] updating cached repository Noah2610/learning-ggez.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Noah2610/learning-ggez.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Noah2610/learning-ggez.rs" "work/ex/clippy-test-run/sources/stable/gh/Noah2610/learning-ggez.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Noah2610/learning-ggez.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Noah2610/learning-ggez.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noah2610/learning-ggez.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noah2610/learning-ggez.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41f3444c914f0efe08856611218f18800bfd788f [INFO] sha for GitHub repo Noah2610/learning-ggez.rs: 41f3444c914f0efe08856611218f18800bfd788f [INFO] validating manifest of Noah2610/learning-ggez.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Noah2610/learning-ggez.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Noah2610/learning-ggez.rs [INFO] finished frobbing Noah2610/learning-ggez.rs [INFO] frobbed toml for Noah2610/learning-ggez.rs written to work/ex/clippy-test-run/sources/stable/gh/Noah2610/learning-ggez.rs/Cargo.toml [INFO] started frobbing Noah2610/learning-ggez.rs [INFO] finished frobbing Noah2610/learning-ggez.rs [INFO] frobbed toml for Noah2610/learning-ggez.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noah2610/learning-ggez.rs/Cargo.toml [INFO] crate Noah2610/learning-ggez.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Noah2610/learning-ggez.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Noah2610/learning-ggez.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fc64e05c78b9c7c78ba05eb521f77a9d4ae8046ab1425e9ae855686f9bbf5bf [INFO] running `"docker" "start" "-a" "3fc64e05c78b9c7c78ba05eb521f77a9d4ae8046ab1425e9ae855686f9bbf5bf"` [INFO] [stderr] Checking topdown v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / return [ [INFO] [stderr] 62 | | top_left.x, top_left.y, [INFO] [stderr] 63 | | self.size.w, self.size.h [INFO] [stderr] 64 | | ].into(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | [ [INFO] [stderr] 62 | top_left.x, top_left.y, [INFO] [stderr] 63 | self.size.w, self.size.h [INFO] [stderr] 64 | ].into() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / return ( [INFO] [stderr] 72 | | ( [INFO] [stderr] 73 | | ( [INFO] [stderr] 74 | | self_sides.left >= othr_sides.left && [INFO] [stderr] ... | [INFO] [stderr] 88 | | ) [INFO] [stderr] 89 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | ( [INFO] [stderr] 72 | ( [INFO] [stderr] 73 | ( [INFO] [stderr] 74 | self_sides.left >= othr_sides.left && [INFO] [stderr] 75 | self_sides.left <= othr_sides.right [INFO] [stderr] 76 | ) || ( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `return` value [INFO] [stderr] --> src/geo/mask.rs:71:12 [INFO] [stderr] | [INFO] [stderr] 71 | return ( [INFO] [stderr] | ____________^ [INFO] [stderr] 72 | | ( [INFO] [stderr] 73 | | ( [INFO] [stderr] 74 | | self_sides.left >= othr_sides.left && [INFO] [stderr] ... | [INFO] [stderr] 88 | | ) [INFO] [stderr] 89 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 71 | return [INFO] [stderr] 72 | ( [INFO] [stderr] 73 | ( [INFO] [stderr] 74 | self_sides.left >= othr_sides.left && [INFO] [stderr] 75 | self_sides.left <= othr_sides.right [INFO] [stderr] 76 | ) || ( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / return match side { [INFO] [stderr] 120 | | 't' => top_left.y, [INFO] [stderr] 121 | | 'b' => top_left.y + self.size.h, [INFO] [stderr] 122 | | 'l' => top_left.x, [INFO] [stderr] 123 | | 'r' => top_left.x + self.size.w, [INFO] [stderr] 124 | | _ => panic!["geo::Mask::side() expected one of 't', 'b', 'l', or 'r'"], [INFO] [stderr] 125 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | match side { [INFO] [stderr] 120 | 't' => top_left.y, [INFO] [stderr] 121 | 'b' => top_left.y + self.size.h, [INFO] [stderr] 122 | 'l' => top_left.x, [INFO] [stderr] 123 | 'r' => top_left.x + self.size.w, [INFO] [stderr] 124 | _ => panic!["geo::Mask::side() expected one of 't', 'b', 'l', or 'r'"], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused imports: `EntityManager`, `GameManager` [INFO] [stderr] --> src/entity/mod.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | use ::game::game_manager::{GameManager, EntityManager}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return &self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return &mut self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return &self.color; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | return &self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return &mut self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return &self.color; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Solid` [INFO] [stderr] --> src/game/game_manager.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | Solid [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Point` [INFO] [stderr] --> src/game/game_manager.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | use ::geo::{Point}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/game_manager.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / return Self { [INFO] [stderr] 45 | | player, [INFO] [stderr] 46 | | walls [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | Self { [INFO] [stderr] 45 | player, [INFO] [stderr] 46 | walls [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/game_manager.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/game_manager.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/game/mod.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | if repeat { return (); } [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/game/mod.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | if repeat { return (); } [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / return [ [INFO] [stderr] 62 | | top_left.x, top_left.y, [INFO] [stderr] 63 | | self.size.w, self.size.h [INFO] [stderr] 64 | | ].into(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | [ [INFO] [stderr] 62 | top_left.x, top_left.y, [INFO] [stderr] 63 | self.size.w, self.size.h [INFO] [stderr] 64 | ].into() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / return ( [INFO] [stderr] 72 | | ( [INFO] [stderr] 73 | | ( [INFO] [stderr] 74 | | self_sides.left >= othr_sides.left && [INFO] [stderr] ... | [INFO] [stderr] 88 | | ) [INFO] [stderr] 89 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | ( [INFO] [stderr] 72 | ( [INFO] [stderr] 73 | ( [INFO] [stderr] 74 | self_sides.left >= othr_sides.left && [INFO] [stderr] 75 | self_sides.left <= othr_sides.right [INFO] [stderr] 76 | ) || ( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `return` value [INFO] [stderr] --> src/geo/mask.rs:71:12 [INFO] [stderr] | [INFO] [stderr] 71 | return ( [INFO] [stderr] | ____________^ [INFO] [stderr] 72 | | ( [INFO] [stderr] 73 | | ( [INFO] [stderr] 74 | | self_sides.left >= othr_sides.left && [INFO] [stderr] ... | [INFO] [stderr] 88 | | ) [INFO] [stderr] 89 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 71 | return [INFO] [stderr] 72 | ( [INFO] [stderr] 73 | ( [INFO] [stderr] 74 | self_sides.left >= othr_sides.left && [INFO] [stderr] 75 | self_sides.left <= othr_sides.right [INFO] [stderr] 76 | ) || ( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo/mask.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / return match side { [INFO] [stderr] 120 | | 't' => top_left.y, [INFO] [stderr] 121 | | 'b' => top_left.y + self.size.h, [INFO] [stderr] 122 | | 'l' => top_left.x, [INFO] [stderr] 123 | | 'r' => top_left.x + self.size.w, [INFO] [stderr] 124 | | _ => panic!["geo::Mask::side() expected one of 't', 'b', 'l', or 'r'"], [INFO] [stderr] 125 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | match side { [INFO] [stderr] 120 | 't' => top_left.y, [INFO] [stderr] 121 | 'b' => top_left.y + self.size.h, [INFO] [stderr] 122 | 'l' => top_left.x, [INFO] [stderr] 123 | 'r' => top_left.x + self.size.w, [INFO] [stderr] 124 | _ => panic!["geo::Mask::side() expected one of 't', 'b', 'l', or 'r'"], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused imports: `EntityManager`, `GameManager` [INFO] [stderr] --> src/entity/mod.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | use ::game::game_manager::{GameManager, EntityManager}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return &self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return &mut self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return &self.color; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | return &self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return &mut self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entity/mod.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return &self.color; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Solid` [INFO] [stderr] --> src/game/game_manager.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | Solid [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Point` [INFO] [stderr] --> src/game/game_manager.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | use ::geo::{Point}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/game_manager.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / return Self { [INFO] [stderr] 45 | | player, [INFO] [stderr] 46 | | walls [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | Self { [INFO] [stderr] 45 | player, [INFO] [stderr] 46 | walls [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/game_manager.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/game_manager.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/game/mod.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | if repeat { return (); } [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/game/mod.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | if repeat { return (); } [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo/mod.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new(w: f32, h: f32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TopRight` [INFO] [stderr] --> src/geo/mask.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | TopRight, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BottomLeft` [INFO] [stderr] --> src/geo/mask.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | BottomLeft, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BottomRight` [INFO] [stderr] --> src/geo/mask.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | BottomRight, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Side` [INFO] [stderr] --> src/geo/mask.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | enum Side { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SideCollection` [INFO] [stderr] --> src/geo/mask.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | struct SideCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo/mask.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(top: f32, bottom: f32, left: f32, right: f32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `point` [INFO] [stderr] --> src/geo/mask.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn point(&self) -> &Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_point` [INFO] [stderr] --> src/geo/mask.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn set_point(&mut self, point: Point) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `intersects` [INFO] [stderr] --> src/geo/mask.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn intersects(&self, mask: &Mask) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `side` [INFO] [stderr] --> src/geo/mask.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | fn side(&self, side: char) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sides` [INFO] [stderr] --> src/geo/mask.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | fn sides(&self) -> SideCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLACK` [INFO] [stderr] --> src/color.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const BLACK: Color = [0.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `WHITE` [INFO] [stderr] --> src/color.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const WHITE: Color = [1.0, 1.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/color.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub const RED: Color = [1.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/color.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub const GREEN: Color = [0.0, 1.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLUE` [INFO] [stderr] --> src/color.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub const BLUE: Color = [0.0, 0.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo/mod.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new(w: f32, h: f32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TopRight` [INFO] [stderr] --> src/geo/mask.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | TopRight, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BottomLeft` [INFO] [stderr] --> src/geo/mask.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | BottomLeft, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BottomRight` [INFO] [stderr] --> src/geo/mask.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | BottomRight, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Side` [INFO] [stderr] --> src/geo/mask.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | enum Side { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SideCollection` [INFO] [stderr] --> src/geo/mask.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | struct SideCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo/mask.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(top: f32, bottom: f32, left: f32, right: f32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `point` [INFO] [stderr] --> src/geo/mask.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn point(&self) -> &Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_point` [INFO] [stderr] --> src/geo/mask.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn set_point(&mut self, point: Point) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `intersects` [INFO] [stderr] --> src/geo/mask.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn intersects(&self, mask: &Mask) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `side` [INFO] [stderr] --> src/geo/mask.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | fn side(&self, side: char) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sides` [INFO] [stderr] --> src/geo/mask.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | fn sides(&self) -> SideCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLACK` [INFO] [stderr] --> src/color.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const BLACK: Color = [0.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `WHITE` [INFO] [stderr] --> src/color.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const WHITE: Color = [1.0, 1.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/color.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub const RED: Color = [1.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/color.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub const GREEN: Color = [0.0, 1.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLUE` [INFO] [stderr] --> src/color.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub const BLUE: Color = [0.0, 0.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity/mod.rs:90:42 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn key_pressed(&mut self, keycode: &Keycode) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Keycode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:16:51 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(control_type: ControlType, keycodes: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/control.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is(&self, keycode: &Keycode) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Keycode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:39 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:60 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:82 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/control.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn find(&self, keycode: &Keycode) -> Option<&ControlType> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Keycode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::game_manager::GameManager` [INFO] [stderr] --> src/game/game_manager.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | let player: Player = Player::new(WINDOW_SIZE.w / 2.0, WINDOW_SIZE.h / 2.0); [INFO] [stderr] 29 | | let wall_size = ::settings::entity::wall::SIZE; [INFO] [stderr] 30 | | let offset_x: f32 = 64.0; [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for game::game_manager::GameManager { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/game_manager.rs:50:44 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn keys_pressed(&mut self, keycodes: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game/mod.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Self { [INFO] [stderr] 22 | | let ctx: Context = ggez::ContextBuilder::new( [INFO] [stderr] 23 | | TITLE, AUTHOR [INFO] [stderr] 24 | | ).window_setup( [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for game::Game { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity/mod.rs:90:42 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn key_pressed(&mut self, keycode: &Keycode) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Keycode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:16:51 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(control_type: ControlType, keycodes: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/control.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is(&self, keycode: &Keycode) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Keycode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:39 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:60 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:33:82 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(up: &Vec, down: &Vec, left: &Vec, right: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/control.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn find(&self, keycode: &Keycode) -> Option<&ControlType> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Keycode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::game_manager::GameManager` [INFO] [stderr] --> src/game/game_manager.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | let player: Player = Player::new(WINDOW_SIZE.w / 2.0, WINDOW_SIZE.h / 2.0); [INFO] [stderr] 29 | | let wall_size = ::settings::entity::wall::SIZE; [INFO] [stderr] 30 | | let offset_x: f32 = 64.0; [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for game::game_manager::GameManager { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/game_manager.rs:50:44 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn keys_pressed(&mut self, keycodes: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Keycode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game/mod.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Self { [INFO] [stderr] 22 | | let ctx: Context = ggez::ContextBuilder::new( [INFO] [stderr] 23 | | TITLE, AUTHOR [INFO] [stderr] 24 | | ).window_setup( [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for game::Game { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.77s [INFO] running `"docker" "inspect" "3fc64e05c78b9c7c78ba05eb521f77a9d4ae8046ab1425e9ae855686f9bbf5bf"` [INFO] running `"docker" "rm" "-f" "3fc64e05c78b9c7c78ba05eb521f77a9d4ae8046ab1425e9ae855686f9bbf5bf"` [INFO] [stdout] 3fc64e05c78b9c7c78ba05eb521f77a9d4ae8046ab1425e9ae855686f9bbf5bf