[INFO] updating cached repository NoLifeDev/wztonx-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NoLifeDev/wztonx-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NoLifeDev/wztonx-rs" "work/ex/clippy-test-run/sources/stable/gh/NoLifeDev/wztonx-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NoLifeDev/wztonx-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NoLifeDev/wztonx-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NoLifeDev/wztonx-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NoLifeDev/wztonx-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef5a58ad49263fe1fd796779094c5bfe9d3934b5 [INFO] sha for GitHub repo NoLifeDev/wztonx-rs: ef5a58ad49263fe1fd796779094c5bfe9d3934b5 [INFO] validating manifest of NoLifeDev/wztonx-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NoLifeDev/wztonx-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NoLifeDev/wztonx-rs [INFO] finished frobbing NoLifeDev/wztonx-rs [INFO] frobbed toml for NoLifeDev/wztonx-rs written to work/ex/clippy-test-run/sources/stable/gh/NoLifeDev/wztonx-rs/Cargo.toml [INFO] started frobbing NoLifeDev/wztonx-rs [INFO] finished frobbing NoLifeDev/wztonx-rs [INFO] frobbed toml for NoLifeDev/wztonx-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NoLifeDev/wztonx-rs/Cargo.toml [INFO] crate NoLifeDev/wztonx-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NoLifeDev/wztonx-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NoLifeDev/wztonx-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa3e3c0b4305d5c1533f4925e1f78159e8040107ed4639c480122840c4eab2b4 [INFO] running `"docker" "start" "-a" "fa3e3c0b4305d5c1533f4925e1f78159e8040107ed4639c480122840c4eab2b4"` [INFO] [stderr] Checking wztonx v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | fin: fin, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | fin: fin, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(magic, 0x31474B50, "not a valid WZ file"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3147_4B50` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(magic, 0x31474B50, "not a valid WZ file"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3147_4B50` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `outpath` [INFO] [stderr] --> src/main.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | fn new(inpath: &Path, outpath: &Path) -> WzToNx { [INFO] [stderr] | ^^^^^^^ help: consider using `_outpath` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `outpath` [INFO] [stderr] --> src/main.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | fn new(inpath: &Path, outpath: &Path) -> WzToNx { [INFO] [stderr] | ^^^^^^^ help: consider using `_outpath` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tell` [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn tell(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_u8` [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | fn read_u8(&mut self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tell` [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn tell(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_u8` [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | fn read_u8(&mut self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | if n != -128 { n as i32 } else { self.read_i32() } [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | if n != -128 { n as i32 } else { self.read_i32() } [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.67s [INFO] running `"docker" "inspect" "fa3e3c0b4305d5c1533f4925e1f78159e8040107ed4639c480122840c4eab2b4"` [INFO] running `"docker" "rm" "-f" "fa3e3c0b4305d5c1533f4925e1f78159e8040107ed4639c480122840c4eab2b4"` [INFO] [stdout] fa3e3c0b4305d5c1533f4925e1f78159e8040107ed4639c480122840c4eab2b4