[INFO] updating cached repository Nimaoth/EPLScript [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Nimaoth/EPLScript [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Nimaoth/EPLScript" "work/ex/clippy-test-run/sources/stable/gh/Nimaoth/EPLScript"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nimaoth/EPLScript'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Nimaoth/EPLScript" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nimaoth/EPLScript"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nimaoth/EPLScript'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb52110b98f7566a109ba574d6b5442b3a3ff168 [INFO] sha for GitHub repo Nimaoth/EPLScript: cb52110b98f7566a109ba574d6b5442b3a3ff168 [INFO] validating manifest of Nimaoth/EPLScript on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Nimaoth/EPLScript on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Nimaoth/EPLScript [INFO] finished frobbing Nimaoth/EPLScript [INFO] frobbed toml for Nimaoth/EPLScript written to work/ex/clippy-test-run/sources/stable/gh/Nimaoth/EPLScript/Cargo.toml [INFO] started frobbing Nimaoth/EPLScript [INFO] finished frobbing Nimaoth/EPLScript [INFO] frobbed toml for Nimaoth/EPLScript written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nimaoth/EPLScript/Cargo.toml [INFO] crate Nimaoth/EPLScript has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Nimaoth/EPLScript against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Nimaoth/EPLScript:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33684272573a229c78156b1092022ce220c60fca4bd2d64968637f13023ebf29 [INFO] running `"docker" "start" "-a" "33684272573a229c78156b1092022ce220c60fca4bd2d64968637f13023ebf29"` [INFO] [stderr] Checking eplscipt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:242:37 [INFO] [stderr] | [INFO] [stderr] 242 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:256:37 [INFO] [stderr] | [INFO] [stderr] 256 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:270:37 [INFO] [stderr] | [INFO] [stderr] 270 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:284:37 [INFO] [stderr] | [INFO] [stderr] 284 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:242:37 [INFO] [stderr] | [INFO] [stderr] 242 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:256:37 [INFO] [stderr] | [INFO] [stderr] 256 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:270:37 [INFO] [stderr] | [INFO] [stderr] 270 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:284:37 [INFO] [stderr] | [INFO] [stderr] 284 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lexer.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / fn parseToken(&mut self) -> Option { [INFO] [stderr] 116 | | self.skipWC(false); [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | if self.index >= self.chars.len() { [INFO] [stderr] ... | [INFO] [stderr] 298 | | } [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | None => Err(format!("Failed to parse statement: reached end of file")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to parse statement: reached end of file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | Err(format!("Failed to parse primary expression: reached end of file")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to parse primary expression: reached end of file".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match stmt { [INFO] [stderr] 46 | | &mut Print(ref mut expr) => { [INFO] [stderr] 47 | | println!("{:?}", self.visitExpr(expr)); [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *stmt { [INFO] [stderr] 46 | Print(ref mut expr) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match expr { [INFO] [stderr] 55 | | &mut Int(i) => Value::Int(i), [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | &mut Add(ref mut a, ref mut b) => mExprBinary!(self, a + b), [INFO] [stderr] ... | [INFO] [stderr] 61 | | &mut Rem(ref mut a, ref mut b) => mExprBinary!(self, a % b) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *expr { [INFO] [stderr] 55 | Int(i) => Value::Int(i), [INFO] [stderr] 56 | [INFO] [stderr] 57 | Add(ref mut a, ref mut b) => mExprBinary!(self, a + b), [INFO] [stderr] 58 | Sub(ref mut a, ref mut b) => mExprBinary!(self, a - b), [INFO] [stderr] 59 | Mul(ref mut a, ref mut b) => mExprBinary!(self, a * b), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lexer.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / fn parseToken(&mut self) -> Option { [INFO] [stderr] 116 | | self.skipWC(false); [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | if self.index >= self.chars.len() { [INFO] [stderr] ... | [INFO] [stderr] 298 | | } [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | None => Err(format!("Failed to parse statement: reached end of file")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to parse statement: reached end of file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | Err(format!("Failed to parse primary expression: reached end of file")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to parse primary expression: reached end of file".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match stmt { [INFO] [stderr] 46 | | &mut Print(ref mut expr) => { [INFO] [stderr] 47 | | println!("{:?}", self.visitExpr(expr)); [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *stmt { [INFO] [stderr] 46 | Print(ref mut expr) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match expr { [INFO] [stderr] 55 | | &mut Int(i) => Value::Int(i), [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | &mut Add(ref mut a, ref mut b) => mExprBinary!(self, a + b), [INFO] [stderr] ... | [INFO] [stderr] 61 | | &mut Rem(ref mut a, ref mut b) => mExprBinary!(self, a % b) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *expr { [INFO] [stderr] 55 | Int(i) => Value::Int(i), [INFO] [stderr] 56 | [INFO] [stderr] 57 | Add(ref mut a, ref mut b) => mExprBinary!(self, a + b), [INFO] [stderr] 58 | Sub(ref mut a, ref mut b) => mExprBinary!(self, a - b), [INFO] [stderr] 59 | Mul(ref mut a, ref mut b) => mExprBinary!(self, a * b), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "33684272573a229c78156b1092022ce220c60fca4bd2d64968637f13023ebf29"` [INFO] running `"docker" "rm" "-f" "33684272573a229c78156b1092022ce220c60fca4bd2d64968637f13023ebf29"` [INFO] [stdout] 33684272573a229c78156b1092022ce220c60fca4bd2d64968637f13023ebf29