[INFO] updating cached repository NiklasJonsson/timelog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NiklasJonsson/timelog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NiklasJonsson/timelog" "work/ex/clippy-test-run/sources/stable/gh/NiklasJonsson/timelog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NiklasJonsson/timelog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NiklasJonsson/timelog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NiklasJonsson/timelog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NiklasJonsson/timelog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9bec22941151deeccff30a3101a904369edf83fd [INFO] sha for GitHub repo NiklasJonsson/timelog: 9bec22941151deeccff30a3101a904369edf83fd [INFO] validating manifest of NiklasJonsson/timelog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NiklasJonsson/timelog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NiklasJonsson/timelog [INFO] finished frobbing NiklasJonsson/timelog [INFO] frobbed toml for NiklasJonsson/timelog written to work/ex/clippy-test-run/sources/stable/gh/NiklasJonsson/timelog/Cargo.toml [INFO] started frobbing NiklasJonsson/timelog [INFO] finished frobbing NiklasJonsson/timelog [INFO] frobbed toml for NiklasJonsson/timelog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NiklasJonsson/timelog/Cargo.toml [INFO] crate NiklasJonsson/timelog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NiklasJonsson/timelog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NiklasJonsson/timelog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19b47ff4ac1662a2f14fea946c631034b7298204505dafc94f4b78644edaf0cd [INFO] running `"docker" "start" "-a" "19b47ff4ac1662a2f14fea946c631034b7298204505dafc94f4b78644edaf0cd"` [INFO] [stderr] Checking timelog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | TimeLogEntry{date: date, entry_type: entry_type, start: Some(time), end: None} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:171:34 [INFO] [stderr] | [INFO] [stderr] 171 | TimeLogEntry{date: date, entry_type: entry_type, start: Some(time), end: None} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:175:22 [INFO] [stderr] | [INFO] [stderr] 175 | TimeLogEntry{date: date, entry_type: entry_type, start: None, end: Some(time)} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | TimeLogEntry{date: date, entry_type: entry_type, start: None, end: Some(time)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:44 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:68 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:82 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:341:20 [INFO] [stderr] | [INFO] [stderr] 341 | TimeLogDay{date: date, entries: Vec::new()} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | TimeLogEntry{date: date, entry_type: entry_type, start: Some(time), end: None} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:171:34 [INFO] [stderr] | [INFO] [stderr] 171 | TimeLogEntry{date: date, entry_type: entry_type, start: Some(time), end: None} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:175:22 [INFO] [stderr] | [INFO] [stderr] 175 | TimeLogEntry{date: date, entry_type: entry_type, start: None, end: Some(time)} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | TimeLogEntry{date: date, entry_type: entry_type, start: None, end: Some(time)} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:44 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:68 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:242:82 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timelog.rs:341:20 [INFO] [stderr] | [INFO] [stderr] 341 | TimeLogDay{date: date, entries: Vec::new()} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | _ => return Err(TimeLogError::parse_error(format!("Can't parse: {} as TimeLogEntryType", s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TimeLogError::parse_error(format!("Can't parse: {} as TimeLogEntryType", s)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | return self.date; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | return NaiveTime::from_str(s).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NaiveTime::from_str(s).ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | return is_weekday(date); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_weekday(date)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return Ok(dur); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dur)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:400:9 [INFO] [stderr] | [INFO] [stderr] 400 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return monday; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `monday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return sunday; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sunday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | return Ok(tl); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | return self.compute_loggable_time_between(start_date, end_date, TimeLogEntryType::Work) - logged_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.compute_loggable_time_between(start_date, end_date, TimeLogEntryType::Work) - logged_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return tld.time_logged_with(with, etype); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tld.time_logged_with(with, etype)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | return Err(TimeLogError::io_error_extra_msg(e, format!("Failed to write to file (restoring backup): {}", e).as_str())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TimeLogError::io_error_extra_msg(e, format!("Failed to write to file (restoring backup): {}", e).as_str()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return days; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `days` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return date; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return ret.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ret.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return date; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/timelogger.rs:211:28 [INFO] [stderr] | [INFO] [stderr] 211 | let mut path_buf = std::env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | _ => return Err(TimeLogError::parse_error(format!("Can't parse: {} as TimeLogEntryType", s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TimeLogError::parse_error(format!("Can't parse: {} as TimeLogEntryType", s)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | return self.date; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | return NaiveTime::from_str(s).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NaiveTime::from_str(s).ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(TimeLogEntry{date: date, entry_type: entry_type, start: start, end:end})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | return is_weekday(date); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_weekday(date)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return Ok(dur); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dur)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelog.rs:400:9 [INFO] [stderr] | [INFO] [stderr] 400 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelog.rs:625:43 [INFO] [stderr] | [INFO] [stderr] 625 | day.set_start(NaiveTime::from_hms(06,30,00), TimeLogEntryType::Work); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 625 | day.set_start(NaiveTime::from_hms(6,30,00), TimeLogEntryType::Work); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 625 | day.set_start(NaiveTime::from_hms(0o6,30,00), TimeLogEntryType::Work); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelog.rs:662:43 [INFO] [stderr] | [INFO] [stderr] 662 | day.set_start(NaiveTime::from_hms(06,30,00), TimeLogEntryType::Work); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 662 | day.set_start(NaiveTime::from_hms(6,30,00), TimeLogEntryType::Work); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 662 | day.set_start(NaiveTime::from_hms(0o6,30,00), TimeLogEntryType::Work); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return monday; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `monday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return sunday; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sunday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | return Ok(tl); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | return self.compute_loggable_time_between(start_date, end_date, TimeLogEntryType::Work) - logged_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.compute_loggable_time_between(start_date, end_date, TimeLogEntryType::Work) - logged_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return tld.time_logged_with(with, etype); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tld.time_logged_with(with, etype)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | return Err(TimeLogError::io_error_extra_msg(e, format!("Failed to write to file (restoring backup): {}", e).as_str())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TimeLogError::io_error_extra_msg(e, format!("Failed to write to file (restoring backup): {}", e).as_str()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timelogger.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return days; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `days` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelogger.rs:498:46 [INFO] [stderr] | [INFO] [stderr] 498 | let today = NaiveDate::from_ymd(2018,01,01); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 498 | let today = NaiveDate::from_ymd(2018,1,01); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 498 | let today = NaiveDate::from_ymd(2018,0o1,01); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelogger.rs:498:49 [INFO] [stderr] | [INFO] [stderr] 498 | let today = NaiveDate::from_ymd(2018,01,01); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 498 | let today = NaiveDate::from_ymd(2018,01,1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 498 | let today = NaiveDate::from_ymd(2018,01,0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelogger.rs:539:45 [INFO] [stderr] | [INFO] [stderr] 539 | let mon3 = NaiveDate::from_ymd(2018,01,01); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 539 | let mon3 = NaiveDate::from_ymd(2018,1,01); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 539 | let mon3 = NaiveDate::from_ymd(2018,0o1,01); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelogger.rs:539:48 [INFO] [stderr] | [INFO] [stderr] 539 | let mon3 = NaiveDate::from_ymd(2018,01,01); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 539 | let mon3 = NaiveDate::from_ymd(2018,01,1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 539 | let mon3 = NaiveDate::from_ymd(2018,01,0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelogger.rs:540:45 [INFO] [stderr] | [INFO] [stderr] 540 | let tue3 = NaiveDate::from_ymd(2018,01,02); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 540 | let tue3 = NaiveDate::from_ymd(2018,1,02); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 540 | let tue3 = NaiveDate::from_ymd(2018,0o1,02); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/timelogger.rs:540:48 [INFO] [stderr] | [INFO] [stderr] 540 | let tue3 = NaiveDate::from_ymd(2018,01,02); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 540 | let tue3 = NaiveDate::from_ymd(2018,01,2); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 540 | let tue3 = NaiveDate::from_ymd(2018,01,0o2); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return date; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return ret.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ret.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return date; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/timelogger.rs:211:28 [INFO] [stderr] | [INFO] [stderr] 211 | let mut path_buf = std::env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/timelog.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | ETYPES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/timelog.rs:353:12 [INFO] [stderr] | [INFO] [stderr] 353 | if self.entries.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/timelog.rs:431:29 [INFO] [stderr] | [INFO] [stderr] 431 | while let Some(l) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for l in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/timelog.rs:434:23 [INFO] [stderr] | [INFO] [stderr] 434 | debug_assert!(v.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/timelogger.rs:180:32 [INFO] [stderr] | [INFO] [stderr] 180 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/timelogger.rs:232:12 [INFO] [stderr] | [INFO] [stderr] 232 | if keys.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/timelogger.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let ref last_tld = self.date2logday[&last_date_with_entries]; [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------- help: try: `let last_tld = &self.date2logday[&last_date_with_entries];` [INFO] [stderr] ... [INFO] [stderr] 271 | gen_time_logged_in_timeperiod_with!(time_logged_in_week_of_with, get_monday_in_week_of, get_sunday_in_week_of); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/timelogger.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let ref last_tld = self.date2logday[&last_date_with_entries]; [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------- help: try: `let last_tld = &self.date2logday[&last_date_with_entries];` [INFO] [stderr] ... [INFO] [stderr] 272 | gen_time_logged_in_timeperiod_with!(time_logged_in_month_of_with, get_first_day_in_month_of, get_last_day_in_month_of); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/timelogger.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | return match bad_entries.is_empty() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 156 | | true => None, [INFO] [stderr] 157 | | false => Some(bad_entries) [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if bad_entries.is_empty() { gen_verify_entries!(verify_entries_in_month_of, get_first_day_in_month_of, get_last_day_in_month_of); } else { gen_verify_entries!(verify_entries_in_month_of, get_first_day_in_month_of, get_last_day_in_month_of); }` [INFO] [stderr] ... [INFO] [stderr] 316 | gen_verify_entries!(verify_entries_in_month_of, get_first_day_in_month_of, get_last_day_in_month_of); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/timelogger.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | return match bad_entries.is_empty() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 156 | | true => None, [INFO] [stderr] 157 | | false => Some(bad_entries) [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if bad_entries.is_empty() { gen_verify_entries!(verify_entries_in_week_of, get_monday_in_week_of, get_sunday_in_week_of); } else { gen_verify_entries!(verify_entries_in_week_of, get_monday_in_week_of, get_sunday_in_week_of); }` [INFO] [stderr] ... [INFO] [stderr] 317 | gen_verify_entries!(verify_entries_in_week_of, get_monday_in_week_of, get_sunday_in_week_of); [INFO] [stderr] | --------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | fn parse_time_arg(s: &String) -> ParseResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | .or(NaiveTime::parse_from_str(s, "%H")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| NaiveTime::parse_from_str(s, "%H"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | .or(NaiveTime::parse_from_str(s, "%H.%M")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| NaiveTime::parse_from_str(s, "%H.%M"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / match args.flag_last { [INFO] [stderr] 122 | | true => "last", [INFO] [stderr] 123 | | false => "this" [INFO] [stderr] 124 | | }.to_string() [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_last { "last" } else { "this" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match args.flag_last { [INFO] [stderr] 144 | | false => today, [INFO] [stderr] 145 | | true => NaiveDate::from_ymd(today.year(), today.month(), 1).pred() [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_last { NaiveDate::from_ymd(today.year(), today.month(), 1).pred() } else { today }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:199:24 [INFO] [stderr] | [INFO] [stderr] 199 | let time_opt = match this_month { [INFO] [stderr] | ________________________^ [INFO] [stderr] 200 | | true => Some(time), [INFO] [stderr] 201 | | false => None, [INFO] [stderr] 202 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if this_month { Some(time) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:242:24 [INFO] [stderr] | [INFO] [stderr] 242 | let time_opt = match this_week { [INFO] [stderr] | ________________________^ [INFO] [stderr] 243 | | true => Some(time), [INFO] [stderr] 244 | | false => None, [INFO] [stderr] 245 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if this_week { Some(time) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:280:24 [INFO] [stderr] | [INFO] [stderr] 280 | let time_opt = match today { [INFO] [stderr] | ________________________^ [INFO] [stderr] 281 | | true => Some(time), [INFO] [stderr] 282 | | false => None, [INFO] [stderr] 283 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if today { Some(time) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:300:5 [INFO] [stderr] | [INFO] [stderr] 300 | / match tl.save() { [INFO] [stderr] 301 | | Err(x) => { [INFO] [stderr] 302 | | println!("Failed to save to logfile: {}", x); [INFO] [stderr] 303 | | return 1; [INFO] [stderr] 304 | | }, [INFO] [stderr] 305 | | Ok(_) => (), [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 300 | if let Err(x) = tl.save() { [INFO] [stderr] 301 | println!("Failed to save to logfile: {}", x); [INFO] [stderr] 302 | return 1; [INFO] [stderr] 303 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `timelog`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/timelog.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | ETYPES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/timelog.rs:353:12 [INFO] [stderr] | [INFO] [stderr] 353 | if self.entries.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/timelog.rs:431:29 [INFO] [stderr] | [INFO] [stderr] 431 | while let Some(l) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for l in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/timelog.rs:434:23 [INFO] [stderr] | [INFO] [stderr] 434 | debug_assert!(v.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/timelogger.rs:180:32 [INFO] [stderr] | [INFO] [stderr] 180 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/timelogger.rs:232:12 [INFO] [stderr] | [INFO] [stderr] 232 | if keys.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/timelogger.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let ref last_tld = self.date2logday[&last_date_with_entries]; [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------- help: try: `let last_tld = &self.date2logday[&last_date_with_entries];` [INFO] [stderr] ... [INFO] [stderr] 271 | gen_time_logged_in_timeperiod_with!(time_logged_in_week_of_with, get_monday_in_week_of, get_sunday_in_week_of); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/timelogger.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let ref last_tld = self.date2logday[&last_date_with_entries]; [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------- help: try: `let last_tld = &self.date2logday[&last_date_with_entries];` [INFO] [stderr] ... [INFO] [stderr] 272 | gen_time_logged_in_timeperiod_with!(time_logged_in_month_of_with, get_first_day_in_month_of, get_last_day_in_month_of); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/timelogger.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | return match bad_entries.is_empty() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 156 | | true => None, [INFO] [stderr] 157 | | false => Some(bad_entries) [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if bad_entries.is_empty() { gen_verify_entries!(verify_entries_in_month_of, get_first_day_in_month_of, get_last_day_in_month_of); } else { gen_verify_entries!(verify_entries_in_month_of, get_first_day_in_month_of, get_last_day_in_month_of); }` [INFO] [stderr] ... [INFO] [stderr] 316 | gen_verify_entries!(verify_entries_in_month_of, get_first_day_in_month_of, get_last_day_in_month_of); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/timelogger.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | return match bad_entries.is_empty() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 156 | | true => None, [INFO] [stderr] 157 | | false => Some(bad_entries) [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if bad_entries.is_empty() { gen_verify_entries!(verify_entries_in_week_of, get_monday_in_week_of, get_sunday_in_week_of); } else { gen_verify_entries!(verify_entries_in_week_of, get_monday_in_week_of, get_sunday_in_week_of); }` [INFO] [stderr] ... [INFO] [stderr] 317 | gen_verify_entries!(verify_entries_in_week_of, get_monday_in_week_of, get_sunday_in_week_of); [INFO] [stderr] | --------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/timelogger.rs:387:5 [INFO] [stderr] | [INFO] [stderr] 387 | / fn timelogger_compute_loggable_time_between() { [INFO] [stderr] 388 | | let mon_1 = "2017/12/18 Mon | Work 06:31:00 07:00:00"; [INFO] [stderr] 389 | | let mon_2 = "2017/12/18 Mon | Work 07:31:00 UNDEF"; [INFO] [stderr] 390 | | let tue_1 = "2017/12/19 Tue | Work 07:31:00 11:50:00"; [INFO] [stderr] ... | [INFO] [stderr] 446 | | assert_eq!(logger.compute_loggable_time_between(prev_fri, fri, TimeLogEntryType::Work), d48hr); [INFO] [stderr] 447 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/timelogger.rs:530:23 [INFO] [stderr] | [INFO] [stderr] 530 | for d in days.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/timelogger.rs:559:23 [INFO] [stderr] | [INFO] [stderr] 559 | for d in days.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | fn parse_time_arg(s: &String) -> ParseResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | .or(NaiveTime::parse_from_str(s, "%H")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| NaiveTime::parse_from_str(s, "%H"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | .or(NaiveTime::parse_from_str(s, "%H.%M")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| NaiveTime::parse_from_str(s, "%H.%M"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / match args.flag_last { [INFO] [stderr] 122 | | true => "last", [INFO] [stderr] 123 | | false => "this" [INFO] [stderr] 124 | | }.to_string() [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_last { "last" } else { "this" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match args.flag_last { [INFO] [stderr] 144 | | false => today, [INFO] [stderr] 145 | | true => NaiveDate::from_ymd(today.year(), today.month(), 1).pred() [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_last { NaiveDate::from_ymd(today.year(), today.month(), 1).pred() } else { today }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:199:24 [INFO] [stderr] | [INFO] [stderr] 199 | let time_opt = match this_month { [INFO] [stderr] | ________________________^ [INFO] [stderr] 200 | | true => Some(time), [INFO] [stderr] 201 | | false => None, [INFO] [stderr] 202 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if this_month { Some(time) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:242:24 [INFO] [stderr] | [INFO] [stderr] 242 | let time_opt = match this_week { [INFO] [stderr] | ________________________^ [INFO] [stderr] 243 | | true => Some(time), [INFO] [stderr] 244 | | false => None, [INFO] [stderr] 245 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if this_week { Some(time) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:280:24 [INFO] [stderr] | [INFO] [stderr] 280 | let time_opt = match today { [INFO] [stderr] | ________________________^ [INFO] [stderr] 281 | | true => Some(time), [INFO] [stderr] 282 | | false => None, [INFO] [stderr] 283 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if today { Some(time) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:300:5 [INFO] [stderr] | [INFO] [stderr] 300 | / match tl.save() { [INFO] [stderr] 301 | | Err(x) => { [INFO] [stderr] 302 | | println!("Failed to save to logfile: {}", x); [INFO] [stderr] 303 | | return 1; [INFO] [stderr] 304 | | }, [INFO] [stderr] 305 | | Ok(_) => (), [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 300 | if let Err(x) = tl.save() { [INFO] [stderr] 301 | println!("Failed to save to logfile: {}", x); [INFO] [stderr] 302 | return 1; [INFO] [stderr] 303 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `timelog`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "19b47ff4ac1662a2f14fea946c631034b7298204505dafc94f4b78644edaf0cd"` [INFO] running `"docker" "rm" "-f" "19b47ff4ac1662a2f14fea946c631034b7298204505dafc94f4b78644edaf0cd"` [INFO] [stdout] 19b47ff4ac1662a2f14fea946c631034b7298204505dafc94f4b78644edaf0cd