[INFO] updating cached repository Niedzwiedzw/rust_blockchain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Niedzwiedzw/rust_blockchain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Niedzwiedzw/rust_blockchain" "work/ex/clippy-test-run/sources/stable/gh/Niedzwiedzw/rust_blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Niedzwiedzw/rust_blockchain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Niedzwiedzw/rust_blockchain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Niedzwiedzw/rust_blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Niedzwiedzw/rust_blockchain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 803a90b0b6eee337b1fd8cb679a935cdaa318423 [INFO] sha for GitHub repo Niedzwiedzw/rust_blockchain: 803a90b0b6eee337b1fd8cb679a935cdaa318423 [INFO] validating manifest of Niedzwiedzw/rust_blockchain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Niedzwiedzw/rust_blockchain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Niedzwiedzw/rust_blockchain [INFO] finished frobbing Niedzwiedzw/rust_blockchain [INFO] frobbed toml for Niedzwiedzw/rust_blockchain written to work/ex/clippy-test-run/sources/stable/gh/Niedzwiedzw/rust_blockchain/Cargo.toml [INFO] started frobbing Niedzwiedzw/rust_blockchain [INFO] finished frobbing Niedzwiedzw/rust_blockchain [INFO] frobbed toml for Niedzwiedzw/rust_blockchain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Niedzwiedzw/rust_blockchain/Cargo.toml [INFO] crate Niedzwiedzw/rust_blockchain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Niedzwiedzw/rust_blockchain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Niedzwiedzw/rust_blockchain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af9ddd927cd24a6b6f6bd513e201feab42adf5c1379f78b2177c30e690e532dd [INFO] running `"docker" "start" "-a" "af9ddd927cd24a6b6f6bd513e201feab42adf5c1379f78b2177c30e690e532dd"` [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking rust-blockchain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Sha256` [INFO] [stderr] --> src/blockchain.rs:2:12 [INFO] [stderr] | [INFO] [stderr] 2 | use sha2::{Sha256, Digest}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/proof.rs:61:22 [INFO] [stderr] | [INFO] [stderr] 61 | let target = target << HASH_SIZE - DIFFICULTY as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `target << (HASH_SIZE - DIFFICULTY as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused import: `to_text` [INFO] [stderr] --> src/main.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | use self::blockchain::{BlockChain, to_text}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Sha256` [INFO] [stderr] --> src/blockchain.rs:2:12 [INFO] [stderr] | [INFO] [stderr] 2 | use sha2::{Sha256, Digest}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/proof.rs:61:22 [INFO] [stderr] | [INFO] [stderr] 61 | let target = target << HASH_SIZE - DIFFICULTY as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `target << (HASH_SIZE - DIFFICULTY as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused import: `to_text` [INFO] [stderr] --> src/main.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | use self::blockchain::{BlockChain, to_text}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Digest` [INFO] [stderr] --> src/blockchain.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | use sha2::{Sha256, Digest}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BUFF_SIZE` [INFO] [stderr] --> src/main.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const BUFF_SIZE: usize = DATA_SIZE + HASH_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `BlockBuff` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | type BlockBuff = [u8; BUFF_SIZE]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/blockchain.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn add(&mut self, data: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `Digest` [INFO] [stderr] --> src/blockchain.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | use sha2::{Sha256, Digest}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/blockchain.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn new(data: &String, nonce: u32) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/blockchain.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | fn create_block(data: &String, prev: &Block) -> Block { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/proof.rs:70:27 [INFO] [stderr] | [INFO] [stderr] 70 | .chain(to_hex(nonce as u64).iter()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(nonce)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BUFF_SIZE` [INFO] [stderr] --> src/main.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const BUFF_SIZE: usize = DATA_SIZE + HASH_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `BlockBuff` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | type BlockBuff = [u8; BUFF_SIZE]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/blockchain.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn add(&mut self, data: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/blockchain.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn new(data: &String, nonce: u32) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/blockchain.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | fn create_block(data: &String, prev: &Block) -> Block { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/proof.rs:70:27 [INFO] [stderr] | [INFO] [stderr] 70 | .chain(to_hex(nonce as u64).iter()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(nonce)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.04s [INFO] running `"docker" "inspect" "af9ddd927cd24a6b6f6bd513e201feab42adf5c1379f78b2177c30e690e532dd"` [INFO] running `"docker" "rm" "-f" "af9ddd927cd24a6b6f6bd513e201feab42adf5c1379f78b2177c30e690e532dd"` [INFO] [stdout] af9ddd927cd24a6b6f6bd513e201feab42adf5c1379f78b2177c30e690e532dd