[INFO] updating cached repository NickMyers217/project-euler-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NickMyers217/project-euler-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NickMyers217/project-euler-rust" "work/ex/clippy-test-run/sources/stable/gh/NickMyers217/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NickMyers217/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NickMyers217/project-euler-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NickMyers217/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NickMyers217/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ae1ab11ba0f8d39351076a448ed5bc7bb797638 [INFO] sha for GitHub repo NickMyers217/project-euler-rust: 7ae1ab11ba0f8d39351076a448ed5bc7bb797638 [INFO] validating manifest of NickMyers217/project-euler-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NickMyers217/project-euler-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NickMyers217/project-euler-rust [INFO] finished frobbing NickMyers217/project-euler-rust [INFO] frobbed toml for NickMyers217/project-euler-rust written to work/ex/clippy-test-run/sources/stable/gh/NickMyers217/project-euler-rust/Cargo.toml [INFO] started frobbing NickMyers217/project-euler-rust [INFO] finished frobbing NickMyers217/project-euler-rust [INFO] frobbed toml for NickMyers217/project-euler-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NickMyers217/project-euler-rust/Cargo.toml [INFO] crate NickMyers217/project-euler-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NickMyers217/project-euler-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NickMyers217/project-euler-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed8f8df1a5c662797c2d02bee099745f0161d44825c1f66b6ee3e415428f2f1f [INFO] running `"docker" "start" "-a" "ed8f8df1a5c662797c2d02bee099745f0161d44825c1f66b6ee3e415428f2f1f"` [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/p12.rs:4:8 [INFO] [stderr] | [INFO] [stderr] 4 | .map(|i| get_tri_num(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_tri_num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/p12.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | (1..i + 1).fold(0, |acc, n| acc + n) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((1..i + 1).fold(0, |acc, n| acc + n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/p12.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | (1..i + 1).fold(0, |acc, n| acc + n) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p12.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | (1..i + 1).fold(0, |acc, n| acc + n) as u64 [INFO] [stderr] | ^^^^^^^^^^ help: use: `(1..=i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/p12.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | .collect::>() [INFO] [stderr] | _____^ [INFO] [stderr] 19 | | .len() as u32 * 2 [INFO] [stderr] | |__________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p12.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | (1..(i as f64).sqrt() as u64 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=(i as f64).sqrt() as u64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/p12.rs:4:8 [INFO] [stderr] | [INFO] [stderr] 4 | .map(|i| get_tri_num(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_tri_num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/p12.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | (1..i + 1).fold(0, |acc, n| acc + n) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((1..i + 1).fold(0, |acc, n| acc + n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/p12.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | (1..i + 1).fold(0, |acc, n| acc + n) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p12.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | (1..i + 1).fold(0, |acc, n| acc + n) as u64 [INFO] [stderr] | ^^^^^^^^^^ help: use: `(1..=i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/p12.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | .collect::>() [INFO] [stderr] | _____^ [INFO] [stderr] 19 | | .len() as u32 * 2 [INFO] [stderr] | |__________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p12.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | (1..(i as f64).sqrt() as u64 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=(i as f64).sqrt() as u64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "ed8f8df1a5c662797c2d02bee099745f0161d44825c1f66b6ee3e415428f2f1f"` [INFO] running `"docker" "rm" "-f" "ed8f8df1a5c662797c2d02bee099745f0161d44825c1f66b6ee3e415428f2f1f"` [INFO] [stdout] ed8f8df1a5c662797c2d02bee099745f0161d44825c1f66b6ee3e415428f2f1f