[INFO] updating cached repository Nercury/bytecache-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Nercury/bytecache-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Nercury/bytecache-rs" "work/ex/clippy-test-run/sources/stable/gh/Nercury/bytecache-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nercury/bytecache-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Nercury/bytecache-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nercury/bytecache-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nercury/bytecache-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dc3c876e25e93a9cbc50907ddbe03189d22cb637 [INFO] sha for GitHub repo Nercury/bytecache-rs: dc3c876e25e93a9cbc50907ddbe03189d22cb637 [INFO] validating manifest of Nercury/bytecache-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Nercury/bytecache-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Nercury/bytecache-rs [INFO] finished frobbing Nercury/bytecache-rs [INFO] frobbed toml for Nercury/bytecache-rs written to work/ex/clippy-test-run/sources/stable/gh/Nercury/bytecache-rs/Cargo.toml [INFO] started frobbing Nercury/bytecache-rs [INFO] finished frobbing Nercury/bytecache-rs [INFO] frobbed toml for Nercury/bytecache-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nercury/bytecache-rs/Cargo.toml [INFO] crate Nercury/bytecache-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Nercury/bytecache-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Nercury/bytecache-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9831c06a83dd28039ead118af28ea3814eb1f6478c890c03bfdeb9f8831a729a [INFO] running `"docker" "start" "-a" "9831c06a83dd28039ead118af28ea3814eb1f6478c890c03bfdeb9f8831a729a"` [INFO] [stderr] Checking bytecache v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/history.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | max_bucket_usage: max_bucket_usage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_bucket_usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/history.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | bucket_count: bucket_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bucket_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/history.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | max_bucket_usage: max_bucket_usage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_bucket_usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/history.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | bucket_count: bucket_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bucket_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/path.rs:90:64 [INFO] [stderr] | [INFO] [stderr] 90 | let name: String = [name.as_ref(), "meta"].connect("."); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/mem.rs:136:30 [INFO] [stderr] | [INFO] [stderr] 136 | fn fetch(&self, key: K) -> Result { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/mem.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | fn store(&self, key: K, required_mem: u64) -> Result { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `required_mem` [INFO] [stderr] --> src/mem.rs:140:39 [INFO] [stderr] | [INFO] [stderr] 140 | fn store(&self, key: K, required_mem: u64) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_required_mem` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mem.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | if spilled.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `spilled.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/mem.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | if let Some(_) = self.items.remove(&key) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 112 | | self.history.remove(&key); [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________- help: try this: `if self.items.remove(&key).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `history::Bucket` [INFO] [stderr] --> src/history.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Bucket { [INFO] [stderr] 20 | | Bucket:: { [INFO] [stderr] 21 | | items: HashMap::new(), [INFO] [stderr] 22 | | usage: 0, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/history.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | let maybe_bytes = self.next_bucket.get(&key).map(|v| *v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.next_bucket.get(&key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/path.rs:90:64 [INFO] [stderr] | [INFO] [stderr] 90 | let name: String = [name.as_ref(), "meta"].connect("."); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/mem.rs:136:30 [INFO] [stderr] | [INFO] [stderr] 136 | fn fetch(&self, key: K) -> Result { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/mem.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | fn store(&self, key: K, required_mem: u64) -> Result { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `required_mem` [INFO] [stderr] --> src/mem.rs:140:39 [INFO] [stderr] | [INFO] [stderr] 140 | fn store(&self, key: K, required_mem: u64) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_required_mem` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mem.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | if spilled.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `spilled.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/mem.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | if let Some(_) = self.items.remove(&key) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 112 | | self.history.remove(&key); [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________- help: try this: `if self.items.remove(&key).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `history::Bucket` [INFO] [stderr] --> src/history.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Bucket { [INFO] [stderr] 20 | | Bucket:: { [INFO] [stderr] 21 | | items: HashMap::new(), [INFO] [stderr] 22 | | usage: 0, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/history.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | let maybe_bytes = self.next_bucket.get(&key).map(|v| *v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.next_bucket.get(&key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/cacher.rs:24:75 [INFO] [stderr] | [INFO] [stderr] 24 | let kv = (&line["set".len()..]).trim_left().splitn(2, " ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.09s [INFO] running `"docker" "inspect" "9831c06a83dd28039ead118af28ea3814eb1f6478c890c03bfdeb9f8831a729a"` [INFO] running `"docker" "rm" "-f" "9831c06a83dd28039ead118af28ea3814eb1f6478c890c03bfdeb9f8831a729a"` [INFO] [stdout] 9831c06a83dd28039ead118af28ea3814eb1f6478c890c03bfdeb9f8831a729a