[INFO] updating cached repository NathanFrasier/rust-rep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NathanFrasier/rust-rep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NathanFrasier/rust-rep" "work/ex/clippy-test-run/sources/stable/gh/NathanFrasier/rust-rep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NathanFrasier/rust-rep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NathanFrasier/rust-rep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NathanFrasier/rust-rep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NathanFrasier/rust-rep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 206db942fb56c9936f7ac78cc417ae4351a738bb [INFO] sha for GitHub repo NathanFrasier/rust-rep: 206db942fb56c9936f7ac78cc417ae4351a738bb [INFO] validating manifest of NathanFrasier/rust-rep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NathanFrasier/rust-rep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NathanFrasier/rust-rep [INFO] finished frobbing NathanFrasier/rust-rep [INFO] frobbed toml for NathanFrasier/rust-rep written to work/ex/clippy-test-run/sources/stable/gh/NathanFrasier/rust-rep/Cargo.toml [INFO] started frobbing NathanFrasier/rust-rep [INFO] finished frobbing NathanFrasier/rust-rep [INFO] frobbed toml for NathanFrasier/rust-rep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NathanFrasier/rust-rep/Cargo.toml [INFO] crate NathanFrasier/rust-rep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NathanFrasier/rust-rep against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NathanFrasier/rust-rep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c10336767d258fcb71a8a3caea9e8ab6baedb7ac08353dc97ec62d07c9422795 [INFO] running `"docker" "start" "-a" "c10336767d258fcb71a8a3caea9e8ab6baedb7ac08353dc97ec62d07c9422795"` [INFO] [stderr] Checking libc v0.2.35 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking rust_rep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / { [INFO] [stderr] 49 | | if args.cmd_serve [INFO] [stderr] 50 | | { [INFO] [stderr] 51 | | serve(&args.flag_f, &args.flag_c) [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | if args.cmd_serve [INFO] [stderr] 49 | { [INFO] [stderr] 50 | serve(&args.flag_f, &args.flag_c) [INFO] [stderr] 51 | } [INFO] [stderr] 52 | else if args.cmd_seed [INFO] [stderr] 53 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/main.rs:68:10 [INFO] [stderr] | [INFO] [stderr] 68 | fn serve(filename:&str, connection:&str) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `connection` [INFO] [stderr] --> src/main.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | fn serve(filename:&str, connection:&str) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_connection` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_info` [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | fn seed(server_info:&str, connection:&str, output:&str) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_server_info` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `connection` [INFO] [stderr] --> src/main.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | fn seed(server_info:&str, connection:&str, output:&str) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_connection` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/main.rs:71:44 [INFO] [stderr] | [INFO] [stderr] 71 | fn seed(server_info:&str, connection:&str, output:&str) { [INFO] [stderr] | ^^^^^^ help: consider using `_output` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_info` [INFO] [stderr] --> src/main.rs:75:10 [INFO] [stderr] | [INFO] [stderr] 75 | fn leech(server_info:&str, output:&str) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_server_info` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/main.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | fn leech(server_info:&str, output:&str) { [INFO] [stderr] | ^^^^^^ help: consider using `_output` instead [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / { [INFO] [stderr] 49 | | if args.cmd_serve [INFO] [stderr] 50 | | { [INFO] [stderr] 51 | | serve(&args.flag_f, &args.flag_c) [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | if args.cmd_serve [INFO] [stderr] 49 | { [INFO] [stderr] 50 | serve(&args.flag_f, &args.flag_c) [INFO] [stderr] 51 | } [INFO] [stderr] 52 | else if args.cmd_seed [INFO] [stderr] 53 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/main.rs:68:10 [INFO] [stderr] | [INFO] [stderr] 68 | fn serve(filename:&str, connection:&str) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `connection` [INFO] [stderr] --> src/main.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | fn serve(filename:&str, connection:&str) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_connection` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_info` [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | fn seed(server_info:&str, connection:&str, output:&str) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_server_info` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `connection` [INFO] [stderr] --> src/main.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | fn seed(server_info:&str, connection:&str, output:&str) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_connection` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/main.rs:71:44 [INFO] [stderr] | [INFO] [stderr] 71 | fn seed(server_info:&str, connection:&str, output:&str) { [INFO] [stderr] | ^^^^^^ help: consider using `_output` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_info` [INFO] [stderr] --> src/main.rs:75:10 [INFO] [stderr] | [INFO] [stderr] 75 | fn leech(server_info:&str, output:&str) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_server_info` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/main.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | fn leech(server_info:&str, output:&str) { [INFO] [stderr] | ^^^^^^ help: consider using `_output` instead [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.12s [INFO] running `"docker" "inspect" "c10336767d258fcb71a8a3caea9e8ab6baedb7ac08353dc97ec62d07c9422795"` [INFO] running `"docker" "rm" "-f" "c10336767d258fcb71a8a3caea9e8ab6baedb7ac08353dc97ec62d07c9422795"` [INFO] [stdout] c10336767d258fcb71a8a3caea9e8ab6baedb7ac08353dc97ec62d07c9422795