[INFO] updating cached repository Nashenas88/geoalg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Nashenas88/geoalg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Nashenas88/geoalg" "work/ex/clippy-test-run/sources/stable/gh/Nashenas88/geoalg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nashenas88/geoalg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Nashenas88/geoalg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nashenas88/geoalg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nashenas88/geoalg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd5a0a4a14fcf214c2ec6cc44bf29cb5a94c7bd3 [INFO] sha for GitHub repo Nashenas88/geoalg: cd5a0a4a14fcf214c2ec6cc44bf29cb5a94c7bd3 [INFO] validating manifest of Nashenas88/geoalg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Nashenas88/geoalg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Nashenas88/geoalg [INFO] finished frobbing Nashenas88/geoalg [INFO] frobbed toml for Nashenas88/geoalg written to work/ex/clippy-test-run/sources/stable/gh/Nashenas88/geoalg/Cargo.toml [INFO] started frobbing Nashenas88/geoalg [INFO] finished frobbing Nashenas88/geoalg [INFO] frobbed toml for Nashenas88/geoalg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nashenas88/geoalg/Cargo.toml [INFO] crate Nashenas88/geoalg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Nashenas88/geoalg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Nashenas88/geoalg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 140fc853c5803bbde57e0a6bde764b8bcf08d964e0c2e36abaa29919c18acaa2 [INFO] running `"docker" "start" "-a" "140fc853c5803bbde57e0a6bde764b8bcf08d964e0c2e36abaa29919c18acaa2"` [INFO] [stderr] Checking geoalg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:59 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:68 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:77 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:86 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:59 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:68 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:77 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:449:86 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:209:37 [INFO] [stderr] | [INFO] [stderr] 209 | negative: self.negative ^ other.negative, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | var_param.negative = var_param.negative ^ negative; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `var_param.negative ^= negative` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | fin += &format!(" - "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" - ".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:321:25 [INFO] [stderr] | [INFO] [stderr] 321 | fin += &format!(" + "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" + ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:341:29 [INFO] [stderr] | [INFO] [stderr] 341 | fin += &format!(" - "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" - ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:343:29 [INFO] [stderr] | [INFO] [stderr] 343 | fin += &format!(" + "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" + ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:449:5 [INFO] [stderr] | [INFO] [stderr] 449 | / pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] 450 | | Self { [INFO] [stderr] 451 | | params: vec![ [INFO] [stderr] 452 | | Param::new(VarParam::from_scalar(a), vec![]), [INFO] [stderr] ... | [INFO] [stderr] 461 | | } [INFO] [stderr] 462 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:548:12 [INFO] [stderr] | [INFO] [stderr] 548 | if self.params.len() == 0 || self.params.iter().map(|p| p.var_params.len()).sum::() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:603:16 [INFO] [stderr] | [INFO] [stderr] 603 | if param.var_params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `param.var_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:209:37 [INFO] [stderr] | [INFO] [stderr] 209 | negative: self.negative ^ other.negative, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | var_param.negative = var_param.negative ^ negative; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `var_param.negative ^= negative` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | fin += &format!(" - "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" - ".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:321:25 [INFO] [stderr] | [INFO] [stderr] 321 | fin += &format!(" + "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" + ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:341:29 [INFO] [stderr] | [INFO] [stderr] 341 | fin += &format!(" - "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" - ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:343:29 [INFO] [stderr] | [INFO] [stderr] 343 | fin += &format!(" + "); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `" + ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: Could not compile `geoalg`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:449:5 [INFO] [stderr] | [INFO] [stderr] 449 | / pub fn from_rotor(a: char, b: char, c: char, d: char, e: char, f: char, g: char, h: char) -> Self { [INFO] [stderr] 450 | | Self { [INFO] [stderr] 451 | | params: vec![ [INFO] [stderr] 452 | | Param::new(VarParam::from_scalar(a), vec![]), [INFO] [stderr] ... | [INFO] [stderr] 461 | | } [INFO] [stderr] 462 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:548:12 [INFO] [stderr] | [INFO] [stderr] 548 | if self.params.len() == 0 || self.params.iter().map(|p| p.var_params.len()).sum::() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:603:16 [INFO] [stderr] | [INFO] [stderr] 603 | if param.var_params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `param.var_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `geoalg`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "140fc853c5803bbde57e0a6bde764b8bcf08d964e0c2e36abaa29919c18acaa2"` [INFO] running `"docker" "rm" "-f" "140fc853c5803bbde57e0a6bde764b8bcf08d964e0c2e36abaa29919c18acaa2"` [INFO] [stdout] 140fc853c5803bbde57e0a6bde764b8bcf08d964e0c2e36abaa29919c18acaa2