[INFO] updating cached repository Narigo/keepass-diff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Narigo/keepass-diff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Narigo/keepass-diff" "work/ex/clippy-test-run/sources/stable/gh/Narigo/keepass-diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Narigo/keepass-diff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Narigo/keepass-diff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Narigo/keepass-diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Narigo/keepass-diff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 127004f3e1197a3f0fa8609ac3c1b330d48028f9 [INFO] sha for GitHub repo Narigo/keepass-diff: 127004f3e1197a3f0fa8609ac3c1b330d48028f9 [INFO] validating manifest of Narigo/keepass-diff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Narigo/keepass-diff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Narigo/keepass-diff [INFO] finished frobbing Narigo/keepass-diff [INFO] frobbed toml for Narigo/keepass-diff written to work/ex/clippy-test-run/sources/stable/gh/Narigo/keepass-diff/Cargo.toml [INFO] started frobbing Narigo/keepass-diff [INFO] finished frobbing Narigo/keepass-diff [INFO] frobbed toml for Narigo/keepass-diff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Narigo/keepass-diff/Cargo.toml [INFO] crate Narigo/keepass-diff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Narigo/keepass-diff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Narigo/keepass-diff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb2a6f0e4fbfe0d47627b1b3dea3a666aa751e64e626642e180574a5b0298c88 [INFO] running `"docker" "start" "-a" "fb2a6f0e4fbfe0d47627b1b3dea3a666aa751e64e626642e180574a5b0298c88"` [INFO] [stderr] Checking secstr v0.2.1 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking keepass v0.1.2 [INFO] [stderr] Checking keepass-diff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | ) -> Result, Option, Option, Option)>, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/diff/mod.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | .map_err(|e| OpenDBError::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpenDBError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | ) -> Vec<(Vec, Option, Option, Option)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | accumulated: &mut Vec<(Vec, Option, Option, Option)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:34:6 [INFO] [stderr] | [INFO] [stderr] 34 | ) -> Vec<(Vec, Option, Option, Option)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | a_idx = a_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `a_idx += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | b_idx = b_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `b_idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | a_idx = a_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `a_idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | b_idx = b_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `b_idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | ) -> Result, Option, Option, Option)>, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/diff/mod.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | .map_err(|e| OpenDBError::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpenDBError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | ) -> Vec<(Vec, Option, Option, Option)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | accumulated: &mut Vec<(Vec, Option, Option, Option)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff/mod.rs:34:6 [INFO] [stderr] | [INFO] [stderr] 34 | ) -> Vec<(Vec, Option, Option, Option)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | a_idx = a_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `a_idx += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | b_idx = b_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `b_idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | a_idx = a_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `a_idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | b_idx = b_idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `b_idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.75s [INFO] running `"docker" "inspect" "fb2a6f0e4fbfe0d47627b1b3dea3a666aa751e64e626642e180574a5b0298c88"` [INFO] running `"docker" "rm" "-f" "fb2a6f0e4fbfe0d47627b1b3dea3a666aa751e64e626642e180574a5b0298c88"` [INFO] [stdout] fb2a6f0e4fbfe0d47627b1b3dea3a666aa751e64e626642e180574a5b0298c88