[INFO] updating cached repository Nanoteck137/Rust-Compiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Nanoteck137/Rust-Compiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Nanoteck137/Rust-Compiler" "work/ex/clippy-test-run/sources/stable/gh/Nanoteck137/Rust-Compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nanoteck137/Rust-Compiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Nanoteck137/Rust-Compiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nanoteck137/Rust-Compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nanoteck137/Rust-Compiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dab658ae2a66cc6342762b434b750b65e689278a [INFO] sha for GitHub repo Nanoteck137/Rust-Compiler: dab658ae2a66cc6342762b434b750b65e689278a [INFO] validating manifest of Nanoteck137/Rust-Compiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Nanoteck137/Rust-Compiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Nanoteck137/Rust-Compiler [INFO] finished frobbing Nanoteck137/Rust-Compiler [INFO] frobbed toml for Nanoteck137/Rust-Compiler written to work/ex/clippy-test-run/sources/stable/gh/Nanoteck137/Rust-Compiler/Cargo.toml [INFO] started frobbing Nanoteck137/Rust-Compiler [INFO] finished frobbing Nanoteck137/Rust-Compiler [INFO] frobbed toml for Nanoteck137/Rust-Compiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nanoteck137/Rust-Compiler/Cargo.toml [INFO] crate Nanoteck137/Rust-Compiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Nanoteck137/Rust-Compiler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Nanoteck137/Rust-Compiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a47ab63db4d43931fc75fb46eca44ec198c983e6060e365266e28510b35e30b [INFO] running `"docker" "start" "-a" "5a47ab63db4d43931fc75fb46eca44ec198c983e6060e365266e28510b35e30b"` [INFO] [stderr] Checking rust_compiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | tokenizer: tokenizer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tokenizer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | tokenizer: tokenizer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tokenizer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return match self.at.chars().nth(self.index as usize) { [INFO] [stderr] 41 | | Some(c) => c, [INFO] [stderr] 42 | | None => '\0', [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | match self.at.chars().nth(self.index as usize) { [INFO] [stderr] 41 | Some(c) => c, [INFO] [stderr] 42 | None => '\0', [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / return match c { [INFO] [stderr] 65 | | '\0' => Token::EOF, [INFO] [stderr] 66 | | '+' => Token::Plus, [INFO] [stderr] 67 | | '-' => Token::Minus, [INFO] [stderr] ... | [INFO] [stderr] 96 | | }, [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match c { [INFO] [stderr] 65 | '\0' => Token::EOF, [INFO] [stderr] 66 | '+' => Token::Plus, [INFO] [stderr] 67 | '-' => Token::Minus, [INFO] [stderr] 68 | '*' => Token::Multiply, [INFO] [stderr] 69 | '/' => Token::Divide, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / return match self.op { [INFO] [stderr] 166 | | Token::Plus => self.left.eval() + self.right.eval(), [INFO] [stderr] 167 | | _ => { [INFO] [stderr] 168 | | panic!("Unknown operation"); [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 165 | match self.op { [INFO] [stderr] 166 | Token::Plus => self.left.eval() + self.right.eval(), [INFO] [stderr] 167 | _ => { [INFO] [stderr] 168 | panic!("Unknown operation"); [INFO] [stderr] 169 | } [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / return match state.current_token { [INFO] [stderr] 190 | | Token::Number(n) => { [INFO] [stderr] 191 | | let res = Box::new(ExprNumber { number: n }); [INFO] [stderr] 192 | | state.get_token(); [INFO] [stderr] ... | [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 189 | match state.current_token { [INFO] [stderr] 190 | Token::Number(n) => { [INFO] [stderr] 191 | let res = Box::new(ExprNumber { number: n }); [INFO] [stderr] 192 | state.get_token(); [INFO] [stderr] 193 | res [INFO] [stderr] 194 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_all_tokens` [INFO] [stderr] --> src/main.rs:100:1 [INFO] [stderr] | [INFO] [stderr] 100 | fn get_all_tokens(tokenizer: &mut Tokenizer) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | num += c.to_digit(10).unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | num += c.to_digit(10).unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return match self.at.chars().nth(self.index as usize) { [INFO] [stderr] 41 | | Some(c) => c, [INFO] [stderr] 42 | | None => '\0', [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | match self.at.chars().nth(self.index as usize) { [INFO] [stderr] 41 | Some(c) => c, [INFO] [stderr] 42 | None => '\0', [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / return match c { [INFO] [stderr] 65 | | '\0' => Token::EOF, [INFO] [stderr] 66 | | '+' => Token::Plus, [INFO] [stderr] 67 | | '-' => Token::Minus, [INFO] [stderr] ... | [INFO] [stderr] 96 | | }, [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match c { [INFO] [stderr] 65 | '\0' => Token::EOF, [INFO] [stderr] 66 | '+' => Token::Plus, [INFO] [stderr] 67 | '-' => Token::Minus, [INFO] [stderr] 68 | '*' => Token::Multiply, [INFO] [stderr] 69 | '/' => Token::Divide, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / return match self.op { [INFO] [stderr] 166 | | Token::Plus => self.left.eval() + self.right.eval(), [INFO] [stderr] 167 | | _ => { [INFO] [stderr] 168 | | panic!("Unknown operation"); [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 165 | match self.op { [INFO] [stderr] 166 | Token::Plus => self.left.eval() + self.right.eval(), [INFO] [stderr] 167 | _ => { [INFO] [stderr] 168 | panic!("Unknown operation"); [INFO] [stderr] 169 | } [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / return match state.current_token { [INFO] [stderr] 190 | | Token::Number(n) => { [INFO] [stderr] 191 | | let res = Box::new(ExprNumber { number: n }); [INFO] [stderr] 192 | | state.get_token(); [INFO] [stderr] ... | [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 189 | match state.current_token { [INFO] [stderr] 190 | Token::Number(n) => { [INFO] [stderr] 191 | let res = Box::new(ExprNumber { number: n }); [INFO] [stderr] 192 | state.get_token(); [INFO] [stderr] 193 | res [INFO] [stderr] 194 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_all_tokens` [INFO] [stderr] --> src/main.rs:100:1 [INFO] [stderr] | [INFO] [stderr] 100 | fn get_all_tokens(tokenizer: &mut Tokenizer) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | num += c.to_digit(10).unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | num += c.to_digit(10).unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "5a47ab63db4d43931fc75fb46eca44ec198c983e6060e365266e28510b35e30b"` [INFO] running `"docker" "rm" "-f" "5a47ab63db4d43931fc75fb46eca44ec198c983e6060e365266e28510b35e30b"` [INFO] [stdout] 5a47ab63db4d43931fc75fb46eca44ec198c983e6060e365266e28510b35e30b