[INFO] updating cached repository Nalorokk/robot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Nalorokk/robot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Nalorokk/robot" "work/ex/clippy-test-run/sources/stable/gh/Nalorokk/robot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nalorokk/robot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Nalorokk/robot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nalorokk/robot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nalorokk/robot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 753188cc39e60093fc9f262f4401df521ea6ba28
[INFO] sha for GitHub repo Nalorokk/robot: 753188cc39e60093fc9f262f4401df521ea6ba28
[INFO] validating manifest of Nalorokk/robot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Nalorokk/robot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Nalorokk/robot
[INFO] finished frobbing Nalorokk/robot
[INFO] frobbed toml for Nalorokk/robot written to work/ex/clippy-test-run/sources/stable/gh/Nalorokk/robot/Cargo.toml
[INFO] started frobbing Nalorokk/robot
[INFO] finished frobbing Nalorokk/robot
[INFO] frobbed toml for Nalorokk/robot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nalorokk/robot/Cargo.toml
[INFO] crate Nalorokk/robot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Nalorokk/robot against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Nalorokk/robot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 152f38bed70869869f31006b3e7b7e01eb7c4feca800d1e15d81908b35fb695f
[INFO] running `"docker" "start" "-a" "152f38bed70869869f31006b3e7b7e01eb7c4feca800d1e15d81908b35fb695f"`
[INFO] [stderr]    Compiling httparse v1.3.1
[INFO] [stderr]     Checking mio-extras v2.0.5
[INFO] [stderr]    Compiling serde_json v1.0.22
[INFO] [stderr]     Checking h2 v0.1.10
[INFO] [stderr]     Checking rppal v0.6.0
[INFO] [stderr]    Compiling cargo_metadata v0.5.6
[INFO] [stderr]    Compiling skeptic v0.13.3
[INFO] [stderr]    Compiling actix v0.5.8
[INFO] [stderr]     Checking actix-web v0.6.14
[INFO] [stderr]     Checking bot v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 | /         return App::with_state(AppState {
[INFO] [stderr] 121 | |             cmd: cmd_mutex,
[INFO] [stderr] 122 | |             power: power_atomic,
[INFO] [stderr] 123 | |         }).route("/cmd/power/{power}", http::Method::GET, on_power)
[INFO] [stderr] ...   |
[INFO] [stderr] 127 | |                 fs::StaticFiles::new("./static/").index_file("index.html"),
[INFO] [stderr] 128 | |             );
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 120 |         App::with_state(AppState {
[INFO] [stderr] 121 |             cmd: cmd_mutex,
[INFO] [stderr] 122 |             power: power_atomic,
[INFO] [stderr] 123 |         }).route("/cmd/power/{power}", http::Method::GET, on_power)
[INFO] [stderr] 124 |             .route("/cmd/{cmd}", http::Method::GET, on_cmd)
[INFO] [stderr] 125 |             .handler(
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 |     return gpio;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `gpio`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 | /                 let mut job: Option<Box<Fn(&Gpio)>> = None;
[INFO] [stderr] 71 | |                 //let mut job = Fn(&Gpio);
[INFO] [stderr] 72 | |
[INFO] [stderr] 73 | |                 if cmd == "stop" {
[INFO] [stderr] 74 | |                     job = Some(Box::new(|gp| stop(&gp)));
[INFO] [stderr] 75 | |                 }
[INFO] [stderr]    | |_________________^ help: it is more idiomatic to write: `let <mut> job = if cmd == "stop" { Some(Box::new(|gp| stop(&gp))) } else { None };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 | /         return App::with_state(AppState {
[INFO] [stderr] 121 | |             cmd: cmd_mutex,
[INFO] [stderr] 122 | |             power: power_atomic,
[INFO] [stderr] 123 | |         }).route("/cmd/power/{power}", http::Method::GET, on_power)
[INFO] [stderr] ...   |
[INFO] [stderr] 127 | |                 fs::StaticFiles::new("./static/").index_file("index.html"),
[INFO] [stderr] 128 | |             );
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 120 |         App::with_state(AppState {
[INFO] [stderr] 121 |             cmd: cmd_mutex,
[INFO] [stderr] 122 |             power: power_atomic,
[INFO] [stderr] 123 |         }).route("/cmd/power/{power}", http::Method::GET, on_power)
[INFO] [stderr] 124 |             .route("/cmd/{cmd}", http::Method::GET, on_cmd)
[INFO] [stderr] 125 |             .handler(
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 |     return gpio;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `gpio`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 | /                 let mut job: Option<Box<Fn(&Gpio)>> = None;
[INFO] [stderr] 71 | |                 //let mut job = Fn(&Gpio);
[INFO] [stderr] 72 | |
[INFO] [stderr] 73 | |                 if cmd == "stop" {
[INFO] [stderr] 74 | |                     job = Some(Box::new(|gp| stop(&gp)));
[INFO] [stderr] 75 | |                 }
[INFO] [stderr]    | |_________________^ help: it is more idiomatic to write: `let <mut> job = if cmd == "stop" { Some(Box::new(|gp| stop(&gp))) } else { None };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 57.78s
[INFO] running `"docker" "inspect" "152f38bed70869869f31006b3e7b7e01eb7c4feca800d1e15d81908b35fb695f"`
[INFO] running `"docker" "rm" "-f" "152f38bed70869869f31006b3e7b7e01eb7c4feca800d1e15d81908b35fb695f"`
[INFO] [stdout] 152f38bed70869869f31006b3e7b7e01eb7c4feca800d1e15d81908b35fb695f