[INFO] updating cached repository NaNuNoo/Souffle
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/NaNuNoo/Souffle
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/NaNuNoo/Souffle" "work/ex/clippy-test-run/sources/stable/gh/NaNuNoo/Souffle"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NaNuNoo/Souffle'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/NaNuNoo/Souffle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NaNuNoo/Souffle"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NaNuNoo/Souffle'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e4cbd9c0bd72076dbedda9c4d02dac42959020b0
[INFO] sha for GitHub repo NaNuNoo/Souffle: e4cbd9c0bd72076dbedda9c4d02dac42959020b0
[INFO] validating manifest of NaNuNoo/Souffle on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of NaNuNoo/Souffle on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing NaNuNoo/Souffle
[INFO] finished frobbing NaNuNoo/Souffle
[INFO] frobbed toml for NaNuNoo/Souffle written to work/ex/clippy-test-run/sources/stable/gh/NaNuNoo/Souffle/Cargo.toml
[INFO] started frobbing NaNuNoo/Souffle
[INFO] finished frobbing NaNuNoo/Souffle
[INFO] frobbed toml for NaNuNoo/Souffle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NaNuNoo/Souffle/Cargo.toml
[INFO] crate NaNuNoo/Souffle has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting NaNuNoo/Souffle against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/NaNuNoo/Souffle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fc3dc02585eb8d1ec34b47cf9a455e6780495de0d79e551db92321e4cd109948
[INFO] running `"docker" "start" "-a" "fc3dc02585eb8d1ec34b47cf9a455e6780495de0d79e551db92321e4cd109948"`
[INFO] [stderr]     Checking unicode-xid v0.0.3
[INFO] [stderr]     Checking ipnetwork v0.12.6
[INFO] [stderr]     Checking pnet_macros_support v0.2.0
[INFO] [stderr]    Compiling memchr v1.0.1
[INFO] [stderr]     Checking syntex_pos v0.42.0
[INFO] [stderr]    Compiling syntex_errors v0.42.0
[INFO] [stderr]    Compiling thread_local v0.3.4
[INFO] [stderr]    Compiling aho-corasick v0.6.3
[INFO] [stderr]    Compiling syntex_syntax v0.42.0
[INFO] [stderr]    Compiling regex v0.2.2
[INFO] [stderr]     Checking syntex v0.42.2
[INFO] [stderr]     Checking pnet_macros v0.15.0
[INFO] [stderr]    Compiling pnet v0.19.0
[INFO] [stderr]     Checking souffle v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:47:7
[INFO] [stderr]    |
[INFO] [stderr] 47 |       interface: interface,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:48:7
[INFO] [stderr]    |
[INFO] [stderr] 48 |       sender: sender,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `sender`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:49:7
[INFO] [stderr]    |
[INFO] [stderr] 49 |       ipv4_net: ipv4_net,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^ help: replace it with: `ipv4_net`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:50:7
[INFO] [stderr]    |
[INFO] [stderr] 50 |       step: step,
[INFO] [stderr]    |       ^^^^^^^^^^ help: replace it with: `step`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:47:7
[INFO] [stderr]    |
[INFO] [stderr] 47 |       interface: interface,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:48:7
[INFO] [stderr]    |
[INFO] [stderr] 48 |       sender: sender,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `sender`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:49:7
[INFO] [stderr]    |
[INFO] [stderr] 49 |       ipv4_net: ipv4_net,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^ help: replace it with: `ipv4_net`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/arp/mod.rs:50:7
[INFO] [stderr]    |
[INFO] [stderr] 50 |       step: step,
[INFO] [stderr]    |       ^^^^^^^^^^ help: replace it with: `step`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ArpOperation`
[INFO] [stderr]   --> src/arp/mod.rs:16:64
[INFO] [stderr]    |
[INFO] [stderr] 16 | use self::pnet::packet::arp::{ArpHardwareTypes, ArpOperations, ArpOperation, ArpPacket};
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return arp_net;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `arp_net`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return ipv4_vec;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ipv4_vec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:72:3
[INFO] [stderr]    |
[INFO] [stderr] 72 | /   return datalink::interfaces()
[INFO] [stderr] 73 | |     .into_iter()
[INFO] [stderr] 74 | |     .filter(|itf| {
[INFO] [stderr] 75 | |       return !regex.is_match(&itf.name) &&
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |     })
[INFO] [stderr] 79 | |     .collect();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 72 |   datalink::interfaces()
[INFO] [stderr] 73 |     .into_iter()
[INFO] [stderr] 74 |     .filter(|itf| {
[INFO] [stderr] 75 |       return !regex.is_match(&itf.name) &&
[INFO] [stderr] 76 |         ((libc::IFF_LOOPBACK as u32) & itf.flags == 0) &&
[INFO] [stderr] 77 |         ((libc::IFF_NOARP as u32) & itf.flags == 0);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:75:7
[INFO] [stderr]    |
[INFO] [stderr] 75 | /       return !regex.is_match(&itf.name) &&
[INFO] [stderr] 76 | |         ((libc::IFF_LOOPBACK as u32) & itf.flags == 0) &&
[INFO] [stderr] 77 | |         ((libc::IFF_NOARP as u32) & itf.flags == 0);
[INFO] [stderr]    | |____________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 75 |       !regex.is_match(&itf.name) &&
[INFO] [stderr] 76 |         ((libc::IFF_LOOPBACK as u32) & itf.flags == 0) &&
[INFO] [stderr] 77 |         ((libc::IFF_NOARP as u32) & itf.flags == 0)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:95:3
[INFO] [stderr]    |
[INFO] [stderr] 95 |   return arp_net_vec;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `arp_net_vec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/arp/mod.rs:40:10
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let (mut sender, _) = match datalink::channel(&interface, Default::default()) {
[INFO] [stderr]    |          ----^^^^^^
[INFO] [stderr]    |          |
[INFO] [stderr]    |          help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/arp/mod.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     let mut step = wanted_step;
[INFO] [stderr] 36 | |     if (net_size / wanted_step) > MAX_PROGRESS {
[INFO] [stderr] 37 | |       step = net_size / 256;
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> step = if (net_size / wanted_step) > MAX_PROGRESS { net_size / 256 } else { wanted_step };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/arp/mod.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     self.progress = self.progress + self.step;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.progress += self.step`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/arp/mod.rs:89:7
[INFO] [stderr]    |
[INFO] [stderr] 89 | /       if let &IpNetwork::V4(ipv4_net) = ip_net {
[INFO] [stderr] 90 | |         let arp_net = ArpNetWork::new(interface.clone(), ipv4_net.clone(), wanted_step);
[INFO] [stderr] 91 | |         arp_net_vec.push(arp_net);
[INFO] [stderr] 92 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 89 |       if let IpNetwork::V4(ipv4_net) = *ip_net {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/arp/mod.rs:90:58
[INFO] [stderr]    |
[INFO] [stderr] 90 |         let arp_net = ArpNetWork::new(interface.clone(), ipv4_net.clone(), wanted_step);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ipv4_net`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/arp/mod.rs:100:11
[INFO] [stderr]     |
[INFO] [stderr] 100 |   sender: &mut Box<EthernetDataLinkSender>,
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EthernetDataLinkSender`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/arp/mod.rs:149:56
[INFO] [stderr]     |
[INFO] [stderr] 149 |     let mac = interface.mac.map(|mac| mac.to_string()).unwrap_or("N/A".to_owned());
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "N/A".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you probably are missing some parameter in your format string
[INFO] [stderr]    --> src/arp/mod.rs:188:21
[INFO] [stderr]     |
[INFO] [stderr] 188 |     Ok(_) => panic!("packetdump: unhandled channel type: {}"),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::panic_params)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ArpOperation`
[INFO] [stderr]   --> src/arp/mod.rs:16:64
[INFO] [stderr]    |
[INFO] [stderr] 16 | use self::pnet::packet::arp::{ArpHardwareTypes, ArpOperations, ArpOperation, ArpPacket};
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return arp_net;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `arp_net`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return ipv4_vec;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ipv4_vec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:72:3
[INFO] [stderr]    |
[INFO] [stderr] 72 | /   return datalink::interfaces()
[INFO] [stderr] 73 | |     .into_iter()
[INFO] [stderr] 74 | |     .filter(|itf| {
[INFO] [stderr] 75 | |       return !regex.is_match(&itf.name) &&
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |     })
[INFO] [stderr] 79 | |     .collect();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 72 |   datalink::interfaces()
[INFO] [stderr] 73 |     .into_iter()
[INFO] [stderr] 74 |     .filter(|itf| {
[INFO] [stderr] 75 |       return !regex.is_match(&itf.name) &&
[INFO] [stderr] 76 |         ((libc::IFF_LOOPBACK as u32) & itf.flags == 0) &&
[INFO] [stderr] 77 |         ((libc::IFF_NOARP as u32) & itf.flags == 0);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:75:7
[INFO] [stderr]    |
[INFO] [stderr] 75 | /       return !regex.is_match(&itf.name) &&
[INFO] [stderr] 76 | |         ((libc::IFF_LOOPBACK as u32) & itf.flags == 0) &&
[INFO] [stderr] 77 | |         ((libc::IFF_NOARP as u32) & itf.flags == 0);
[INFO] [stderr]    | |____________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 75 |       !regex.is_match(&itf.name) &&
[INFO] [stderr] 76 |         ((libc::IFF_LOOPBACK as u32) & itf.flags == 0) &&
[INFO] [stderr] 77 |         ((libc::IFF_NOARP as u32) & itf.flags == 0)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arp/mod.rs:95:3
[INFO] [stderr]    |
[INFO] [stderr] 95 |   return arp_net_vec;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `arp_net_vec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/arp/mod.rs:40:10
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let (mut sender, _) = match datalink::channel(&interface, Default::default()) {
[INFO] [stderr]    |          ----^^^^^^
[INFO] [stderr]    |          |
[INFO] [stderr]    |          help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/arp/mod.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     let mut step = wanted_step;
[INFO] [stderr] 36 | |     if (net_size / wanted_step) > MAX_PROGRESS {
[INFO] [stderr] 37 | |       step = net_size / 256;
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> step = if (net_size / wanted_step) > MAX_PROGRESS { net_size / 256 } else { wanted_step };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/arp/mod.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     self.progress = self.progress + self.step;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.progress += self.step`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/arp/mod.rs:89:7
[INFO] [stderr]    |
[INFO] [stderr] 89 | /       if let &IpNetwork::V4(ipv4_net) = ip_net {
[INFO] [stderr] 90 | |         let arp_net = ArpNetWork::new(interface.clone(), ipv4_net.clone(), wanted_step);
[INFO] [stderr] 91 | |         arp_net_vec.push(arp_net);
[INFO] [stderr] 92 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 89 |       if let IpNetwork::V4(ipv4_net) = *ip_net {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/arp/mod.rs:90:58
[INFO] [stderr]    |
[INFO] [stderr] 90 |         let arp_net = ArpNetWork::new(interface.clone(), ipv4_net.clone(), wanted_step);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ipv4_net`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/arp/mod.rs:100:11
[INFO] [stderr]     |
[INFO] [stderr] 100 |   sender: &mut Box<EthernetDataLinkSender>,
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EthernetDataLinkSender`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/arp/mod.rs:149:56
[INFO] [stderr]     |
[INFO] [stderr] 149 |     let mac = interface.mac.map(|mac| mac.to_string()).unwrap_or("N/A".to_owned());
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "N/A".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you probably are missing some parameter in your format string
[INFO] [stderr]    --> src/arp/mod.rs:188:21
[INFO] [stderr]     |
[INFO] [stderr] 188 |     Ok(_) => panic!("packetdump: unhandled channel type: {}"),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::panic_params)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 14s
[INFO] running `"docker" "inspect" "fc3dc02585eb8d1ec34b47cf9a455e6780495de0d79e551db92321e4cd109948"`
[INFO] running `"docker" "rm" "-f" "fc3dc02585eb8d1ec34b47cf9a455e6780495de0d79e551db92321e4cd109948"`
[INFO] [stdout] fc3dc02585eb8d1ec34b47cf9a455e6780495de0d79e551db92321e4cd109948