[INFO] updating cached repository MyLordAngus/cryptopals-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MyLordAngus/cryptopals-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MyLordAngus/cryptopals-rust" "work/ex/clippy-test-run/sources/stable/gh/MyLordAngus/cryptopals-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MyLordAngus/cryptopals-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MyLordAngus/cryptopals-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MyLordAngus/cryptopals-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MyLordAngus/cryptopals-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 430829d199295a538fc5843af2e97ed5c13f0847 [INFO] sha for GitHub repo MyLordAngus/cryptopals-rust: 430829d199295a538fc5843af2e97ed5c13f0847 [INFO] validating manifest of MyLordAngus/cryptopals-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MyLordAngus/cryptopals-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MyLordAngus/cryptopals-rust [INFO] finished frobbing MyLordAngus/cryptopals-rust [INFO] frobbed toml for MyLordAngus/cryptopals-rust written to work/ex/clippy-test-run/sources/stable/gh/MyLordAngus/cryptopals-rust/Cargo.toml [INFO] started frobbing MyLordAngus/cryptopals-rust [INFO] finished frobbing MyLordAngus/cryptopals-rust [INFO] frobbed toml for MyLordAngus/cryptopals-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MyLordAngus/cryptopals-rust/Cargo.toml [INFO] crate MyLordAngus/cryptopals-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MyLordAngus/cryptopals-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MyLordAngus/cryptopals-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 319bc5ed983ecc1af06ab79b9e6f12e9ff33808bec26f5cde24dd216dfbd07d4 [INFO] running `"docker" "start" "-a" "319bc5ed983ecc1af06ab79b9e6f12e9ff33808bec26f5cde24dd216dfbd07d4"` [INFO] [stderr] Compiling openssl v0.10.2 [INFO] [stderr] Checking cryptopals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cryptography/aes.rs:22:6 [INFO] [stderr] | [INFO] [stderr] 22 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base64.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(u32_to_u8_slice(0x12345678), slice); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/cryptography/aes.rs:22:6 [INFO] [stderr] | [INFO] [stderr] 22 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64.rs:147:14 [INFO] [stderr] | [INFO] [stderr] 147 | "AQID".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"AQID"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | "hyKTqvCyAA==".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hyKTqvCyAA=="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bit_utils.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(hamming_distance("this is a test".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bit_utils.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | "wokka wokka!!!".as_bytes()), 37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"wokka wokka!!!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cryptography/pkcs.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | let string = "YELLOW SUBMARINE".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"YELLOW SUBMARINE"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cryptography/pkcs.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | to_pad_buffer = "".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> tests/set2.rs:20:6 [INFO] [stderr] | [INFO] [stderr] 20 | let output = Command::new("./target/debug/set2_challenge10") [INFO] [stderr] | ^^^^^^ help: consider using `_output` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.69s [INFO] running `"docker" "inspect" "319bc5ed983ecc1af06ab79b9e6f12e9ff33808bec26f5cde24dd216dfbd07d4"` [INFO] running `"docker" "rm" "-f" "319bc5ed983ecc1af06ab79b9e6f12e9ff33808bec26f5cde24dd216dfbd07d4"` [INFO] [stdout] 319bc5ed983ecc1af06ab79b9e6f12e9ff33808bec26f5cde24dd216dfbd07d4