[INFO] updating cached repository Morichan/a_to_z_of_programming_language [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Morichan/a_to_z_of_programming_language [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Morichan/a_to_z_of_programming_language" "work/ex/clippy-test-run/sources/stable/gh/Morichan/a_to_z_of_programming_language"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Morichan/a_to_z_of_programming_language'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Morichan/a_to_z_of_programming_language" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Morichan/a_to_z_of_programming_language"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Morichan/a_to_z_of_programming_language'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f08e5c0c7583ef5aa290036f98f546d9480ca96 [INFO] sha for GitHub repo Morichan/a_to_z_of_programming_language: 3f08e5c0c7583ef5aa290036f98f546d9480ca96 [INFO] validating manifest of Morichan/a_to_z_of_programming_language on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Morichan/a_to_z_of_programming_language on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Morichan/a_to_z_of_programming_language [INFO] finished frobbing Morichan/a_to_z_of_programming_language [INFO] frobbed toml for Morichan/a_to_z_of_programming_language written to work/ex/clippy-test-run/sources/stable/gh/Morichan/a_to_z_of_programming_language/Cargo.toml [INFO] started frobbing Morichan/a_to_z_of_programming_language [INFO] finished frobbing Morichan/a_to_z_of_programming_language [INFO] frobbed toml for Morichan/a_to_z_of_programming_language written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Morichan/a_to_z_of_programming_language/Cargo.toml [INFO] crate Morichan/a_to_z_of_programming_language has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Morichan/a_to_z_of_programming_language against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Morichan/a_to_z_of_programming_language:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71c3b1ce016ec8fb781fed6137107debc459fd7a055b19eace11cbfd43584cbd [INFO] running `"docker" "start" "-a" "71c3b1ce016ec8fb781fed6137107debc459fd7a055b19eace11cbfd43584cbd"` [INFO] [stderr] Checking a_to_z_of_programming_language v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/a_star/node.rs:27:45 [INFO] [stderr] | [INFO] [stderr] 27 | self.point = UnsafeCell::new(Point {x: x, y: y}); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/a_star/node.rs:27:51 [INFO] [stderr] | [INFO] [stderr] 27 | self.point = UnsafeCell::new(Point {x: x, y: y}); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/a_star/node.rs:27:45 [INFO] [stderr] | [INFO] [stderr] 27 | self.point = UnsafeCell::new(Point {x: x, y: y}); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/a_star/node.rs:27:51 [INFO] [stderr] | [INFO] [stderr] 27 | self.point = UnsafeCell::new(Point {x: x, y: y}); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/a_star/node.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Point {x: unsafe{ (*p).x }, y: unsafe{ (*p).y}}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point {x: unsafe{ (*p).x }, y: unsafe{ (*p).y}}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `a_star::node::Node` [INFO] [stderr] --> src/a_star/node.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Node { [INFO] [stderr] 15 | | Node {id: 0, point: UnsafeCell::new(Point {x: 0, y: 0})} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for a_star::node::Node { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/a_star/node.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Point {x: unsafe{ (*p).x }, y: unsafe{ (*p).y}}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point {x: unsafe{ (*p).x }, y: unsafe{ (*p).y}}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `a_star::node::Node` [INFO] [stderr] --> src/a_star/node.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Node { [INFO] [stderr] 15 | | Node {id: 0, point: UnsafeCell::new(Point {x: 0, y: 0})} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for a_star::node::Node { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "71c3b1ce016ec8fb781fed6137107debc459fd7a055b19eace11cbfd43584cbd"` [INFO] running `"docker" "rm" "-f" "71c3b1ce016ec8fb781fed6137107debc459fd7a055b19eace11cbfd43584cbd"` [INFO] [stdout] 71c3b1ce016ec8fb781fed6137107debc459fd7a055b19eace11cbfd43584cbd