[INFO] updating cached repository Moraxno/DayPlanner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Moraxno/DayPlanner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Moraxno/DayPlanner" "work/ex/clippy-test-run/sources/stable/gh/Moraxno/DayPlanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Moraxno/DayPlanner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Moraxno/DayPlanner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Moraxno/DayPlanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Moraxno/DayPlanner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e3dd692ad1ad560ca70aa76aa836d85e6c9a8116 [INFO] sha for GitHub repo Moraxno/DayPlanner: e3dd692ad1ad560ca70aa76aa836d85e6c9a8116 [INFO] validating manifest of Moraxno/DayPlanner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Moraxno/DayPlanner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Moraxno/DayPlanner [INFO] finished frobbing Moraxno/DayPlanner [INFO] frobbed toml for Moraxno/DayPlanner written to work/ex/clippy-test-run/sources/stable/gh/Moraxno/DayPlanner/Cargo.toml [INFO] started frobbing Moraxno/DayPlanner [INFO] finished frobbing Moraxno/DayPlanner [INFO] frobbed toml for Moraxno/DayPlanner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Moraxno/DayPlanner/Cargo.toml [INFO] crate Moraxno/DayPlanner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Moraxno/DayPlanner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Moraxno/DayPlanner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3743e3d133e0c9881bd0bbdf365558bddc903495570b9f0dc93c2121d94058e0 [INFO] running `"docker" "start" "-a" "3743e3d133e0c9881bd0bbdf365558bddc903495570b9f0dc93c2121d94058e0"` [INFO] [stderr] Checking num-integer v0.1.38 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking day_planner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tasks/task.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return other_too_early || self_too_early; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `other_too_early || self_too_early` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tasks/task_scheduler.rs:20:41 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn register(&mut self, t: Task) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ts` [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let mut ts = TaskScheduler::new(); [INFO] [stderr] | ^^ help: consider using `_ts` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `self_sta_bef_other_end` [INFO] [stderr] --> src/tasks/task.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let self_sta_bef_other_end = self.start_time < other_end; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `_self_sta_bef_other_end` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut ts = TaskScheduler::new(); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tasks/task.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return other_too_early || self_too_early; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `other_too_early || self_too_early` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tasks/task_scheduler.rs:20:41 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn register(&mut self, t: Task) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tasks::task_scheduler::TaskScheduler` [INFO] [stderr] --> src/tasks/task_scheduler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self [INFO] [stderr] 13 | | { [INFO] [stderr] 14 | | TaskScheduler [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | tasks: Vec::new() [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ts` [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let mut ts = TaskScheduler::new(); [INFO] [stderr] | ^^ help: consider using `_ts` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `self_sta_bef_other_end` [INFO] [stderr] --> src/tasks/task.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let self_sta_bef_other_end = self.start_time < other_end; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `_self_sta_bef_other_end` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut ts = TaskScheduler::new(); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tasks::task_scheduler::TaskScheduler` [INFO] [stderr] --> src/tasks/task_scheduler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self [INFO] [stderr] 13 | | { [INFO] [stderr] 14 | | TaskScheduler [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | tasks: Vec::new() [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.06s [INFO] running `"docker" "inspect" "3743e3d133e0c9881bd0bbdf365558bddc903495570b9f0dc93c2121d94058e0"` [INFO] running `"docker" "rm" "-f" "3743e3d133e0c9881bd0bbdf365558bddc903495570b9f0dc93c2121d94058e0"` [INFO] [stdout] 3743e3d133e0c9881bd0bbdf365558bddc903495570b9f0dc93c2121d94058e0