[INFO] updating cached repository MonsieurMan/atta [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MonsieurMan/atta [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MonsieurMan/atta" "work/ex/clippy-test-run/sources/stable/gh/MonsieurMan/atta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MonsieurMan/atta'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MonsieurMan/atta" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MonsieurMan/atta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MonsieurMan/atta'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 42f01fff4dd1502a28705386d3ae33a954fa2728 [INFO] sha for GitHub repo MonsieurMan/atta: 42f01fff4dd1502a28705386d3ae33a954fa2728 [INFO] validating manifest of MonsieurMan/atta on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MonsieurMan/atta on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MonsieurMan/atta [INFO] finished frobbing MonsieurMan/atta [INFO] frobbed toml for MonsieurMan/atta written to work/ex/clippy-test-run/sources/stable/gh/MonsieurMan/atta/Cargo.toml [INFO] started frobbing MonsieurMan/atta [INFO] finished frobbing MonsieurMan/atta [INFO] frobbed toml for MonsieurMan/atta written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MonsieurMan/atta/Cargo.toml [INFO] crate MonsieurMan/atta has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MonsieurMan/atta against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MonsieurMan/atta:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 870d92b3d35fbfca68e2e6c9d9593c0569997d352721d8012e3244c692129988 [INFO] running `"docker" "start" "-a" "870d92b3d35fbfca68e2e6c9d9593c0569997d352721d8012e3244c692129988"` [INFO] [stderr] Checking xattr v0.1.11 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tar v0.4.14 [INFO] [stderr] Checking hyper v0.11.20 [INFO] [stderr] Checking rhino v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `store::Store` [INFO] [stderr] --> src/store.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Store { [INFO] [stderr] 10 | | Store { [INFO] [stderr] 11 | | packages: HashMap::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/store.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self.packages.get(name) { [INFO] [stderr] 20 | | Some(_p) => panic!("Cannot add same package twice to the store"), [INFO] [stderr] 21 | | None => (), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(_p) = self.packages.get(name) { panic!("Cannot add same package twice to the store") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `store::Store` [INFO] [stderr] --> src/store.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Store { [INFO] [stderr] 10 | | Store { [INFO] [stderr] 11 | | packages: HashMap::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/store.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self.packages.get(name) { [INFO] [stderr] 20 | | Some(_p) => panic!("Cannot add same package twice to the store"), [INFO] [stderr] 21 | | None => (), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(_p) = self.packages.get(name) { panic!("Cannot add same package twice to the store") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.90s [INFO] running `"docker" "inspect" "870d92b3d35fbfca68e2e6c9d9593c0569997d352721d8012e3244c692129988"` [INFO] running `"docker" "rm" "-f" "870d92b3d35fbfca68e2e6c9d9593c0569997d352721d8012e3244c692129988"` [INFO] [stdout] 870d92b3d35fbfca68e2e6c9d9593c0569997d352721d8012e3244c692129988