[INFO] updating cached repository Mitchell-Nuckols/corner-detection [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Mitchell-Nuckols/corner-detection [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Mitchell-Nuckols/corner-detection" "work/ex/clippy-test-run/sources/stable/gh/Mitchell-Nuckols/corner-detection"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mitchell-Nuckols/corner-detection'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Mitchell-Nuckols/corner-detection" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mitchell-Nuckols/corner-detection"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mitchell-Nuckols/corner-detection'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 46702b55be0d4080fc5218f37f0481f4c884d7fb [INFO] sha for GitHub repo Mitchell-Nuckols/corner-detection: 46702b55be0d4080fc5218f37f0481f4c884d7fb [INFO] validating manifest of Mitchell-Nuckols/corner-detection on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Mitchell-Nuckols/corner-detection on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Mitchell-Nuckols/corner-detection [INFO] finished frobbing Mitchell-Nuckols/corner-detection [INFO] frobbed toml for Mitchell-Nuckols/corner-detection written to work/ex/clippy-test-run/sources/stable/gh/Mitchell-Nuckols/corner-detection/Cargo.toml [INFO] started frobbing Mitchell-Nuckols/corner-detection [INFO] finished frobbing Mitchell-Nuckols/corner-detection [INFO] frobbed toml for Mitchell-Nuckols/corner-detection written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mitchell-Nuckols/corner-detection/Cargo.toml [INFO] crate Mitchell-Nuckols/corner-detection has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Mitchell-Nuckols/corner-detection against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mitchell-Nuckols/corner-detection:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3912bfc343252960957cb9608b6003a1b4a91cd9f5bc2781f6019c94e6dfa7bc [INFO] running `"docker" "start" "-a" "3912bfc343252960957cb9608b6003a1b4a91cd9f5bc2781f6019c94e6dfa7bc"` [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking corner-detection v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::num::*` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::num::*; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | if (x * y == img.width() * img.height()) {break;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ops::*` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | use ops::*; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `mat_sum` is assigned to, but never used [INFO] [stderr] --> src/main.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let mut mat_sum: f32 = 0.0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_mat_sum` instead [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | acc += c * (img.get_pixel((x+i)-1, (y+j)-1).data[0] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel((x+i)-1, (y+j)-1).data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | let c = 0.30 * (img.get_pixel(x, y).data[0] as f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel(x, y).data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | + 0.59 * (img.get_pixel(x, y).data[1] as f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel(x, y).data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | + 0.11 * (img.get_pixel(x, y).data[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel(x, y).data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | *p = image::Luma([(ixtemp.get_pixel(x, y).data[0] as f32 * ixtemp.get_pixel(x, y).data[0] as f32) as u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(ixtemp.get_pixel(x, y).data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:72 [INFO] [stderr] | [INFO] [stderr] 86 | *p = image::Luma([(ixtemp.get_pixel(x, y).data[0] as f32 * ixtemp.get_pixel(x, y).data[0] as f32) as u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(ixtemp.get_pixel(x, y).data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::num::*` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::num::*; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | if (x * y == img.width() * img.height()) {break;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ops::*` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | use ops::*; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `mat_sum` is assigned to, but never used [INFO] [stderr] --> src/main.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let mut mat_sum: f32 = 0.0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_mat_sum` instead [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | acc += c * (img.get_pixel((x+i)-1, (y+j)-1).data[0] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel((x+i)-1, (y+j)-1).data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | let c = 0.30 * (img.get_pixel(x, y).data[0] as f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel(x, y).data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | + 0.59 * (img.get_pixel(x, y).data[1] as f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel(x, y).data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | + 0.11 * (img.get_pixel(x, y).data[2] as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(img.get_pixel(x, y).data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | *p = image::Luma([(ixtemp.get_pixel(x, y).data[0] as f32 * ixtemp.get_pixel(x, y).data[0] as f32) as u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(ixtemp.get_pixel(x, y).data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:72 [INFO] [stderr] | [INFO] [stderr] 86 | *p = image::Luma([(ixtemp.get_pixel(x, y).data[0] as f32 * ixtemp.get_pixel(x, y).data[0] as f32) as u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(ixtemp.get_pixel(x, y).data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.22s [INFO] running `"docker" "inspect" "3912bfc343252960957cb9608b6003a1b4a91cd9f5bc2781f6019c94e6dfa7bc"` [INFO] running `"docker" "rm" "-f" "3912bfc343252960957cb9608b6003a1b4a91cd9f5bc2781f6019c94e6dfa7bc"` [INFO] [stdout] 3912bfc343252960957cb9608b6003a1b4a91cd9f5bc2781f6019c94e6dfa7bc