[INFO] updating cached repository Mistra/A.S.D. [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Mistra/A.S.D. [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Mistra/A.S.D." "work/ex/clippy-test-run/sources/stable/gh/Mistra/A.S.D."` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mistra/A.S.D.'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Mistra/A.S.D." "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mistra/A.S.D."` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mistra/A.S.D.'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0afb343b19427165a490e0a5e3accee1c427a12f [INFO] sha for GitHub repo Mistra/A.S.D.: 0afb343b19427165a490e0a5e3accee1c427a12f [INFO] validating manifest of Mistra/A.S.D. on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Mistra/A.S.D. on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Mistra/A.S.D. [INFO] finished frobbing Mistra/A.S.D. [INFO] frobbed toml for Mistra/A.S.D. written to work/ex/clippy-test-run/sources/stable/gh/Mistra/A.S.D./Cargo.toml [INFO] started frobbing Mistra/A.S.D. [INFO] finished frobbing Mistra/A.S.D. [INFO] frobbed toml for Mistra/A.S.D. written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mistra/A.S.D./Cargo.toml [INFO] crate Mistra/A.S.D. has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Mistra/A.S.D. against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mistra/A.S.D.:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 177a4759384fade575822dfb1faed217d1827d290c45e88a1e7645a132f35716 [INFO] running `"docker" "start" "-a" "177a4759384fade575822dfb1faed217d1827d290c45e88a1e7645a132f35716"` [INFO] [stderr] Checking asd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memo/list/list.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memo/list/list.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/memo/tree/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod tree; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/memo/list/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod list; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/memo/tree/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod tree; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/memo/list/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod list; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: function is never used: `horner` [INFO] [stderr] --> src/algo/misc/horner.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn horner(variables: &mut[isize], x: isize) -> isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `power` [INFO] [stderr] --> src/algo/misc/horner.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn power(x: isize, pow: usize) -> isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `polynome` [INFO] [stderr] --> src/algo/misc/horner.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn polynome(variables: &mut[isize], x: isize) -> isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memo::tree::tree::Tree` [INFO] [stderr] --> src/memo/tree/tree.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Self { [INFO] [stderr] 39 | | Tree { head: None } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/memo/tree/tree.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match *link { [INFO] [stderr] 65 | | None => false, [INFO] [stderr] 66 | | Some(_) => true, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ help: try this: `*link.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memo::list::list::List` [INFO] [stderr] --> src/memo/list/list.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | List { head: None } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algo/misc/fibonacci.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | curr = curr + prev; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `curr += prev` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memo::tree::tree::Tree` [INFO] [stderr] --> src/memo/tree/tree.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Self { [INFO] [stderr] 39 | | Tree { head: None } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/memo/tree/tree.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match *link { [INFO] [stderr] 65 | | None => false, [INFO] [stderr] 66 | | Some(_) => true, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ help: try this: `*link.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memo::list::list::List` [INFO] [stderr] --> src/memo/list/list.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | List { head: None } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algo/misc/fibonacci.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | curr = curr + prev; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `curr += prev` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.69s [INFO] running `"docker" "inspect" "177a4759384fade575822dfb1faed217d1827d290c45e88a1e7645a132f35716"` [INFO] running `"docker" "rm" "-f" "177a4759384fade575822dfb1faed217d1827d290c45e88a1e7645a132f35716"` [INFO] [stdout] 177a4759384fade575822dfb1faed217d1827d290c45e88a1e7645a132f35716