[INFO] updating cached repository Mistodon/piggy
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Mistodon/piggy
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Mistodon/piggy" "work/ex/clippy-test-run/sources/stable/gh/Mistodon/piggy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mistodon/piggy'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Mistodon/piggy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mistodon/piggy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mistodon/piggy'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ac13b814883d70debeed25f86626d9cec37994b8
[INFO] sha for GitHub repo Mistodon/piggy: ac13b814883d70debeed25f86626d9cec37994b8
[INFO] validating manifest of Mistodon/piggy on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Mistodon/piggy on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Mistodon/piggy
[INFO] finished frobbing Mistodon/piggy
[INFO] frobbed toml for Mistodon/piggy written to work/ex/clippy-test-run/sources/stable/gh/Mistodon/piggy/Cargo.toml
[INFO] started frobbing Mistodon/piggy
[INFO] finished frobbing Mistodon/piggy
[INFO] frobbed toml for Mistodon/piggy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mistodon/piggy/Cargo.toml
[INFO] crate Mistodon/piggy has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Mistodon/piggy against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mistodon/piggy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 85bed35f1ab47f8160b9cb58d18b243c1527267f143c9312df0076917e31e887
[INFO] running `"docker" "start" "-a" "85bed35f1ab47f8160b9cb58d18b243c1527267f143c9312df0076917e31e887"`
[INFO] [stderr]    Compiling structopt-derive v0.1.4
[INFO] [stderr]     Checking structopt v0.1.4
[INFO] [stderr]     Checking piggy v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/data.rs:21:45
[INFO] [stderr]    |
[INFO] [stderr] 21 |             s => NaiveDate::from_str(s).map(|d| Date(d))
[INFO] [stderr]    |                                             ^^^^^^^^^^^ help: remove closure as shown: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/data.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn day(&self) -> u32
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/data.rs:21:45
[INFO] [stderr]    |
[INFO] [stderr] 21 |             s => NaiveDate::from_str(s).map(|d| Date(d))
[INFO] [stderr]    |                                             ^^^^^^^^^^^ help: remove closure as shown: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/data.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn day(&self) -> u32
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/lib.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 | /             match occurrence < monthly.start_date.0
[INFO] [stderr] 73 | |             {
[INFO] [stderr] 74 | |                 true => get_next_day(monthly.day, occurrence),
[INFO] [stderr] 75 | |                 false => occurrence
[INFO] [stderr] 76 | |             }
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if occurrence < monthly.start_date.0 { get_next_day(monthly.day, occurrence) } else { occurrence }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/lib.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 | /             match occurrence < monthly.start_date.0
[INFO] [stderr] 73 | |             {
[INFO] [stderr] 74 | |                 true => get_next_day(monthly.day, occurrence),
[INFO] [stderr] 75 | |                 false => occurrence
[INFO] [stderr] 76 | |             }
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if occurrence < monthly.start_date.0 { get_next_day(monthly.day, occurrence) } else { occurrence }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:135:40
[INFO] [stderr]     |
[INFO] [stderr] 135 |                 let mut home = expect!(env::home_dir(), "Failed to find home directory");
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:135:40
[INFO] [stderr]     |
[INFO] [stderr] 135 |                 let mut home = expect!(env::home_dir(), "Failed to find home directory");
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.80s
[INFO] running `"docker" "inspect" "85bed35f1ab47f8160b9cb58d18b243c1527267f143c9312df0076917e31e887"`
[INFO] running `"docker" "rm" "-f" "85bed35f1ab47f8160b9cb58d18b243c1527267f143c9312df0076917e31e887"`
[INFO] [stdout] 85bed35f1ab47f8160b9cb58d18b243c1527267f143c9312df0076917e31e887