[INFO] updating cached repository MishalAlajmi-psu/CS410_Rust_chatApp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MishalAlajmi-psu/CS410_Rust_chatApp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MishalAlajmi-psu/CS410_Rust_chatApp" "work/ex/clippy-test-run/sources/stable/gh/MishalAlajmi-psu/CS410_Rust_chatApp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MishalAlajmi-psu/CS410_Rust_chatApp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MishalAlajmi-psu/CS410_Rust_chatApp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MishalAlajmi-psu/CS410_Rust_chatApp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MishalAlajmi-psu/CS410_Rust_chatApp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0ff3dd8090dbc424cd916b07ac51621cec26b160 [INFO] sha for GitHub repo MishalAlajmi-psu/CS410_Rust_chatApp: 0ff3dd8090dbc424cd916b07ac51621cec26b160 [INFO] validating manifest of MishalAlajmi-psu/CS410_Rust_chatApp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MishalAlajmi-psu/CS410_Rust_chatApp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MishalAlajmi-psu/CS410_Rust_chatApp [INFO] finished frobbing MishalAlajmi-psu/CS410_Rust_chatApp [INFO] frobbed toml for MishalAlajmi-psu/CS410_Rust_chatApp written to work/ex/clippy-test-run/sources/stable/gh/MishalAlajmi-psu/CS410_Rust_chatApp/Cargo.toml [INFO] started frobbing MishalAlajmi-psu/CS410_Rust_chatApp [INFO] finished frobbing MishalAlajmi-psu/CS410_Rust_chatApp [INFO] frobbed toml for MishalAlajmi-psu/CS410_Rust_chatApp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MishalAlajmi-psu/CS410_Rust_chatApp/Cargo.toml [INFO] crate MishalAlajmi-psu/CS410_Rust_chatApp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MishalAlajmi-psu/CS410_Rust_chatApp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MishalAlajmi-psu/CS410_Rust_chatApp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e9a2ef865a09af8c2c4969c66b0c925cf67505469c3388b2baec055e00ed472 [INFO] running `"docker" "start" "-a" "2e9a2ef865a09af8c2c4969c66b0c925cf67505469c3388b2baec055e00ed472"` [INFO] [stderr] Checking chat_app v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server.rs:74:40 [INFO] [stderr] | [INFO] [stderr] 74 | if let Ok(_) = client.write(b"\n") { [INFO] [stderr] | _________________________________- ^^^^^ [INFO] [stderr] 75 | | if let Ok(_) = client.flush() { [INFO] [stderr] 76 | | clientscopy.push(client); [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________________________- help: try this: `if client.write(b"\n").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | if let Ok(_) = client.flush() { [INFO] [stderr] | _____________________________________- ^^^^^ [INFO] [stderr] 76 | | clientscopy.push(client); [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________________________________- help: try this: `if client.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server.rs:118:24 [INFO] [stderr] | [INFO] [stderr] 118 | if let Ok(_) = reader.read_line(&mut buffern) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 119 | | if buffern.trim() == "OK" { [INFO] [stderr] 120 | | println!("Handshake: SUCCESS\n"); [INFO] [stderr] 121 | | return Ok(name.trim().to_string()); [INFO] [stderr] ... | [INFO] [stderr] 127 | | return Err("Error: Connection failed"); [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________________- help: try this: `if reader.read_line(&mut buffern).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | writer.write(user_id.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server.rs:74:40 [INFO] [stderr] | [INFO] [stderr] 74 | if let Ok(_) = client.write(b"\n") { [INFO] [stderr] | _________________________________- ^^^^^ [INFO] [stderr] 75 | | if let Ok(_) = client.flush() { [INFO] [stderr] 76 | | clientscopy.push(client); [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________________________- help: try this: `if client.write(b"\n").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | if let Ok(_) = client.flush() { [INFO] [stderr] | _____________________________________- ^^^^^ [INFO] [stderr] 76 | | clientscopy.push(client); [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________________________________- help: try this: `if client.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/client.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | if let Ok(_) = reader.read_line(&mut buffer) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 51 | | if buffer.trim() == "OK" { [INFO] [stderr] 52 | | writer.write(b"OK\n").unwrap(); [INFO] [stderr] 53 | | writer.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | return Err("Error: Unable to connect"); [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_line(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/client.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if let Ok(_) = inp.read_line(&mut message) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 82 | | match send.write(message.as_bytes()) { [INFO] [stderr] 83 | | Ok(_) => { [INFO] [stderr] 84 | | send.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________- help: try this: `if inp.read_line(&mut message).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server.rs:118:24 [INFO] [stderr] | [INFO] [stderr] 118 | if let Ok(_) = reader.read_line(&mut buffern) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 119 | | if buffern.trim() == "OK" { [INFO] [stderr] 120 | | println!("Handshake: SUCCESS\n"); [INFO] [stderr] 121 | | return Ok(name.trim().to_string()); [INFO] [stderr] ... | [INFO] [stderr] 127 | | return Err("Error: Connection failed"); [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________________- help: try this: `if reader.read_line(&mut buffern).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | writer.write(user_id.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/client.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | if let Ok(_) = reader.read_line(&mut buffer) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 51 | | if buffer.trim() == "OK" { [INFO] [stderr] 52 | | writer.write(b"OK\n").unwrap(); [INFO] [stderr] 53 | | writer.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | return Err("Error: Unable to connect"); [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_line(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: Could not compile `chat_app`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/client.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if let Ok(_) = inp.read_line(&mut message) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 82 | | match send.write(message.as_bytes()) { [INFO] [stderr] 83 | | Ok(_) => { [INFO] [stderr] 84 | | send.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________- help: try this: `if inp.read_line(&mut message).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `chat_app`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2e9a2ef865a09af8c2c4969c66b0c925cf67505469c3388b2baec055e00ed472"` [INFO] running `"docker" "rm" "-f" "2e9a2ef865a09af8c2c4969c66b0c925cf67505469c3388b2baec055e00ed472"` [INFO] [stdout] 2e9a2ef865a09af8c2c4969c66b0c925cf67505469c3388b2baec055e00ed472