[INFO] updating cached repository Minq/cache-destroyer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Minq/cache-destroyer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Minq/cache-destroyer" "work/ex/clippy-test-run/sources/stable/gh/Minq/cache-destroyer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Minq/cache-destroyer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Minq/cache-destroyer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Minq/cache-destroyer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Minq/cache-destroyer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b062b8b42b19364e9ea1b18f10ee9b6e55c3e8d [INFO] sha for GitHub repo Minq/cache-destroyer: 9b062b8b42b19364e9ea1b18f10ee9b6e55c3e8d [INFO] validating manifest of Minq/cache-destroyer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Minq/cache-destroyer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Minq/cache-destroyer [INFO] finished frobbing Minq/cache-destroyer [INFO] frobbed toml for Minq/cache-destroyer written to work/ex/clippy-test-run/sources/stable/gh/Minq/cache-destroyer/Cargo.toml [INFO] started frobbing Minq/cache-destroyer [INFO] finished frobbing Minq/cache-destroyer [INFO] frobbed toml for Minq/cache-destroyer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Minq/cache-destroyer/Cargo.toml [INFO] crate Minq/cache-destroyer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Minq/cache-destroyer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Minq/cache-destroyer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9ad428ece4c24498d3474c6af33740b4601c9526b48f86a0ad1222de48f4468 [INFO] running `"docker" "start" "-a" "c9ad428ece4c24498d3474c6af33740b4601c9526b48f86a0ad1222de48f4468"` [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking cache-destroyer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:80:35 [INFO] [stderr] | [INFO] [stderr] 80 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:163:41 [INFO] [stderr] | [INFO] [stderr] 163 | let mut parts = input.splitn(3, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::single_char_pattern)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:168:40 [INFO] [stderr] | [INFO] [stderr] 168 | None => return Err(format!("GET must be followed by a key")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"GET must be followed by a key".to_string()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::useless_format)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:171:32 [INFO] [stderr] | [INFO] [stderr] 171 | return Err(format!("GET's key must not be followed by anything")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"GET's key must not be followed by anything".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:178:40 [INFO] [stderr] | [INFO] [stderr] 178 | None => return Err(format!("SET must be followed by a key")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SET must be followed by a key".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:182:40 [INFO] [stderr] | [INFO] [stderr] 182 | None => return Err(format!("SET needs a value")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SET needs a value".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | None => Err(format!("empty input")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"empty input".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cache-destroyer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:80:35 [INFO] [stderr] | [INFO] [stderr] 80 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:163:41 [INFO] [stderr] | [INFO] [stderr] 163 | let mut parts = input.splitn(3, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::single_char_pattern)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:168:40 [INFO] [stderr] | [INFO] [stderr] 168 | None => return Err(format!("GET must be followed by a key")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"GET must be followed by a key".to_string()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::useless_format)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:171:32 [INFO] [stderr] | [INFO] [stderr] 171 | return Err(format!("GET's key must not be followed by anything")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"GET's key must not be followed by anything".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:178:40 [INFO] [stderr] | [INFO] [stderr] 178 | None => return Err(format!("SET must be followed by a key")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SET must be followed by a key".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:182:40 [INFO] [stderr] | [INFO] [stderr] 182 | None => return Err(format!("SET needs a value")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SET needs a value".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/main.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | None => Err(format!("empty input")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"empty input".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cache-destroyer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c9ad428ece4c24498d3474c6af33740b4601c9526b48f86a0ad1222de48f4468"` [INFO] running `"docker" "rm" "-f" "c9ad428ece4c24498d3474c6af33740b4601c9526b48f86a0ad1222de48f4468"` [INFO] [stdout] c9ad428ece4c24498d3474c6af33740b4601c9526b48f86a0ad1222de48f4468